diff --git a/web/skins/classic/views/events.php b/web/skins/classic/views/events.php index 17ead385d..d77441875 100644 --- a/web/skins/classic/views/events.php +++ b/web/skins/classic/views/events.php @@ -18,16 +18,14 @@ // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. // -if ( !canView( 'Events' ) || (!empty($_REQUEST['execute']) && !canEdit('Events')) ) -{ - $view = "error"; +if ( !canView( 'Events' ) || (!empty($_REQUEST['execute']) && !canEdit('Events')) ) { + $view = 'error'; return; } require_once( 'includes/Event.php' ); -if ( !empty($_REQUEST['execute']) ) -{ +if ( !empty($_REQUEST['execute']) ) { executeFilter( $tempFilterName ); } @@ -38,16 +36,15 @@ if ( $user['MonitorIds'] ) { $countSql .= $user_monitor_ids; $eventsSql .= $user_monitor_ids; } else { - $countSql .= " 1"; - $eventsSql .= " 1"; + $countSql .= " 1"; + $eventsSql .= " 1"; } parseSort(); parseFilter( $_REQUEST['filter'] ); $filterQuery = $_REQUEST['filter']['query']; -if ( $_REQUEST['filter']['sql'] ) -{ +if ( $_REQUEST['filter']['sql'] ) { $countSql .= $_REQUEST['filter']['sql']; $eventsSql .= $_REQUEST['filter']['sql']; } @@ -63,31 +60,28 @@ else $limit = 0; $nEvents = dbFetchOne( $countSql, 'EventCount' ); -if ( !empty($limit) && $nEvents > $limit ) -{ +if ( !empty($limit) && $nEvents > $limit ) { $nEvents = $limit; } $pages = (int)ceil($nEvents/ZM_WEB_EVENTS_PER_PAGE); if ( !empty($page) ) { - if ( $page < 0 ) - $page = 1; - if ( $page > $pages ) - $page = $pages; + if ( $page < 0 ) + $page = 1; + else if ( $page > $pages ) + $page = $pages; } + if ( !empty($page) ) { - $limitStart = (($page-1)*ZM_WEB_EVENTS_PER_PAGE); - if ( empty( $limit ) ) - { - $limitAmount = ZM_WEB_EVENTS_PER_PAGE; - } - else - { - $limitLeft = $limit - $limitStart; - $limitAmount = ($limitLeft>ZM_WEB_EVENTS_PER_PAGE)?ZM_WEB_EVENTS_PER_PAGE:$limitLeft; - } - $eventsSql .= " limit $limitStart, $limitAmount"; + $limitStart = (($page-1)*ZM_WEB_EVENTS_PER_PAGE); + if ( empty( $limit ) ) { + $limitAmount = ZM_WEB_EVENTS_PER_PAGE; + } else { + $limitLeft = $limit - $limitStart; + $limitAmount = ($limitLeft>ZM_WEB_EVENTS_PER_PAGE)?ZM_WEB_EVENTS_PER_PAGE:$limitLeft; + } + $eventsSql .= " limit $limitStart, $limitAmount"; } elseif ( !empty( $limit ) ) { - $eventsSql .= " limit 0, ".$limit; + $eventsSql .= " limit 0, ".$limit; } $maxWidth = 0; @@ -95,20 +89,19 @@ $maxHeight = 0; $archived = false; $unarchived = false; $events = array(); -foreach ( dbFetchAll( $eventsSql ) as $event_row ) -{ - $events[] = $event = new Event( $event_row ); +foreach ( dbFetchAll( $eventsSql ) as $event_row ) { + $events[] = $event = new Event( $event_row ); - # Doesn this code do anything? - $scale = max( reScale( SCALE_BASE, $event->DefaultScale(), ZM_WEB_DEFAULT_SCALE ), SCALE_BASE ); - $eventWidth = reScale( $event_row['Width'], $scale ); - $eventHeight = reScale( $event_row['Height'], $scale ); - if ( $maxWidth < $eventWidth ) $maxWidth = $eventWidth; - if ( $maxHeight < $eventHeight ) $maxHeight = $eventHeight; - if ( $event_row['Archived'] ) - $archived = true; - else - $unarchived = true; +# Doesn this code do anything? + $scale = max( reScale( SCALE_BASE, $event->DefaultScale(), ZM_WEB_DEFAULT_SCALE ), SCALE_BASE ); + $eventWidth = reScale( $event_row['Width'], $scale ); + $eventHeight = reScale( $event_row['Height'], $scale ); + if ( $maxWidth < $eventWidth ) $maxWidth = $eventWidth; + if ( $maxHeight < $eventHeight ) $maxHeight = $eventHeight; + if ( $event_row['Archived'] ) + $archived = true; + else + $unarchived = true; } $maxShortcuts = 5; @@ -124,16 +117,12 @@ xhtmlHeaders(__FILE__, translate('Events') );