From 426976ddb70580586fdc1f2d2919d136e1b033df Mon Sep 17 00:00:00 2001
From: Isaac Connor <isaac@zoneminder.com>
Date: Tue, 16 Jan 2018 14:04:44 -0500
Subject: [PATCH] cleanup return code

---
 scripts/ZoneMinder/lib/ZoneMinder/Event.pm | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/scripts/ZoneMinder/lib/ZoneMinder/Event.pm b/scripts/ZoneMinder/lib/ZoneMinder/Event.pm
index c01294f8c..8f4a276f7 100644
--- a/scripts/ZoneMinder/lib/ZoneMinder/Event.pm
+++ b/scripts/ZoneMinder/lib/ZoneMinder/Event.pm
@@ -476,16 +476,14 @@ sub MoveTo {
       last;
     }
   } # end foreach file.
+  return $error if $error;
 
-  if ( ! $error ) {
-    # Succeeded in copying all files, so we may now update the Event.
-    $$self{StorageId} = $$NewStorage{Id};    
-    $$self{Storage} = $NewStorage;
-    $error .= $self->save();
-  }
-  if ( ! $error ) {
-    $self->delete_files( $OldStorage );
-  }
+  # Succeeded in copying all files, so we may now update the Event.
+  $$self{StorageId} = $$NewStorage{Id};    
+  $$self{Storage} = $NewStorage;
+  $error .= $self->save();
+  return $error if $error;
+  $self->delete_files( $OldStorage );
   return $error;
 } # end sub MoveTo