From b1b2932238fc354e3fbab96122539c4acbe8108f Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 18 Dec 2025 17:27:21 +0000 Subject: [PATCH] Remove unused log_soap_request_response placeholder function Co-authored-by: connortechnology <925519+connortechnology@users.noreply.github.com> --- src/zm_monitor.h | 1 - src/zm_monitor_onvif.cpp | 15 --------------- 2 files changed, 16 deletions(-) diff --git a/src/zm_monitor.h b/src/zm_monitor.h index 2b0e7249d..deccdba7e 100644 --- a/src/zm_monitor.h +++ b/src/zm_monitor.h @@ -358,7 +358,6 @@ class Monitor : public std::enable_shared_from_this { // Helper methods bool parse_event_message(struct _wsnt__NotificationMessage *msg, std::string &topic, std::string &value, std::string &operation); bool matches_topic_filter(const std::string &topic, const std::string &filter); - void log_soap_request_response(const char *operation); void parse_onvif_options(); // Parse options from parent->onvif_options int get_retry_delay(); // Calculate exponential backoff delay #endif diff --git a/src/zm_monitor_onvif.cpp b/src/zm_monitor_onvif.cpp index 3d1485ee4..91221efbc 100644 --- a/src/zm_monitor_onvif.cpp +++ b/src/zm_monitor_onvif.cpp @@ -774,21 +774,6 @@ bool Monitor::ONVIF::matches_topic_filter(const std::string &topic, const std::s return filter_idx >= filter_parts.size(); } -// Helper function to log SOAP requests/responses for debugging -void Monitor::ONVIF::log_soap_request_response(const char *operation) { - if (config.log_level >= 3) { - std::stringstream ss; - std::ostream *old_stream = soap->os; - soap->os = &ss; - - Debug(3, "ONVIF: SOAP request/response for %s:", operation); - // Note: Actual request/response logging would require intercepting at a lower level - // This is a placeholder for the logging structure - - soap->os = old_stream; - } -} - //GSOAP boilerplate int SOAP_ENV__Fault(struct soap *soap, char *faultcode, char *faultstring, char *faultactor, struct SOAP_ENV__Detail *detail, struct SOAP_ENV__Code *SOAP_ENV__Code, struct SOAP_ENV__Reason *SOAP_ENV__Reason, char *SOAP_ENV__Node, char *SOAP_ENV__Role, struct SOAP_ENV__Detail *SOAP_ENV__Detail) { // populate the fault struct from the operation arguments to print it