From ba4307cb0b46267cb426bd897ebb9839015eaec8 Mon Sep 17 00:00:00 2001 From: Ben Dailey Date: Thu, 15 Jan 2026 14:44:07 -0500 Subject: [PATCH] refactor: use StringToLower from zm_utils.h Replace inline ASCII lowercase conversion with existing StringToLower utility function for consistency with the rest of the codebase. Co-Authored-By: Claude Opus 4.5 --- src/zm_monitor_onvif.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/zm_monitor_onvif.cpp b/src/zm_monitor_onvif.cpp index 5196bc1b4..733540bee 100644 --- a/src/zm_monitor_onvif.cpp +++ b/src/zm_monitor_onvif.cpp @@ -1090,12 +1090,8 @@ bool ONVIF::interpret_alarm_value(const std::string &value) { return false; // Empty value = no alarm } - // Convert to lowercase once for case-insensitive comparison (ASCII-only) - std::string lower_value; - lower_value.reserve(value.size()); - for (char c : value) { - lower_value += (c >= 'A' && c <= 'Z') ? static_cast(c + 32) : c; - } + // Convert to lowercase once for case-insensitive comparison + std::string lower_value = StringToLower(value); // Check for explicit false/inactive values if (lower_value == "false" ||