diff --git a/scripts/zmfilter.pl.in b/scripts/zmfilter.pl.in index e812a3bd9..f83800a30 100644 --- a/scripts/zmfilter.pl.in +++ b/scripts/zmfilter.pl.in @@ -163,16 +163,17 @@ delete @ENV{qw(IFS CDPATH ENV BASH_ENV)}; my $delay = $Config{ZM_FILTER_EXECUTE_INTERVAL}; my $event_id = 0; -if ( ! EVENT_PATH ) { - Error("No event path defined. Config was $Config{ZM_DIR_EVENTS}"); +if ( !EVENT_PATH ) { + Error('No event path defined. Config was '.$Config{ZM_DIR_EVENTS}); die; } # In future, should not be neccessary wrt StorageAreas -chdir( EVENT_PATH ); +chdir(EVENT_PATH); # Should not be neccessary... but nice to get a local var. What if it fails? my $dbh = zmDbConnect(); +$dbh->do('SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED'); if ( $filter_name ) { Info("Scanning for events using filter '$filter_name'"); diff --git a/web/includes/actions/controlcap.php b/web/includes/actions/controlcap.php index 0958a2492..01f80254c 100644 --- a/web/includes/actions/controlcap.php +++ b/web/includes/actions/controlcap.php @@ -24,7 +24,7 @@ if ( !canEdit('Control') ) { return; } // end if !canEdit Controls -if ( $action == 'controlcap' ) { +if ( $action == 'Save' ) { require_once('includes/Control.php'); $Control = new ZM\Control( !empty($_REQUEST['cid']) ? $_REQUEST['cid'] : null ); @@ -82,13 +82,13 @@ if ( $action == 'controlcap' ) { # Checkboxes don't return an element in the POST data, so won't be present in newControl. # So force a value for these fields foreach ( $field_defaults as $field => $value ) { - if ( ! (isset($_REQUEST['newControl'][$field]) and $_REQUEST['newControl'][$field]) ) { - $_REQUEST['newControl'][$field] = $value; + if ( ! (isset($_REQUEST['Control'][$field]) and $_REQUEST['Control'][$field]) ) { + $_REQUEST['Control'][$field] = $value; } } # end foreach type //$changes = getFormChanges( $control, $_REQUEST['newControl'], $types, $columns ); - $Control->save($_REQUEST['newControl']); + $Control->save($_REQUEST['Control']); $redirect = '?view=controlcaps'; } // end if action ?> diff --git a/web/skins/classic/css/base/skin.css b/web/skins/classic/css/base/skin.css index 038547ec9..77658a9b6 100644 --- a/web/skins/classic/css/base/skin.css +++ b/web/skins/classic/css/base/skin.css @@ -168,6 +168,9 @@ input[disabled] { color: #888888; } +.modal img { + max-width: 100%; +} img { display: inline-block; } diff --git a/web/skins/classic/views/controlcap.php b/web/skins/classic/views/controlcap.php index 164d41bc7..194c351c5 100644 --- a/web/skins/classic/views/controlcap.php +++ b/web/skins/classic/views/controlcap.php @@ -37,457 +37,615 @@ $tabs['presets'] = translate('Presets'); $tab = isset($_REQUEST['tab']) ? validHtmlStr($_REQUEST['tab']) :'main'; -if ( isset($_REQUEST['newControl']) ) { - $newControl = $_REQUEST['newControl']; +if ( isset($_REQUEST['Control']) ) { + $Control = $_REQUEST['Control']; } else { - if ( !empty($_REQUEST['cid']) ) { - $control = dbFetchOne('SELECT * FROM Controls WHERE Id = ?', NULL, array($_REQUEST['cid'])); - } else { - $control = array( - 'Name' => translate('New'), - 'Type' => "Local", - 'Protocol' => "", - 'CanWake' => "", - 'CanSleep' => "", - 'CanReset' => "", - 'CanReboot' => "", - 'CanMove' => "", - 'CanMoveDiag' => "", - 'CanMoveMap' => "", - 'CanMoveAbs' => "", - 'CanMoveRel' => "", - 'CanMoveCon' => "", - 'CanPan' => "", - 'MinPanRange' => "", - 'MaxPanRange' => "", - 'MinPanStep' => "", - 'MaxPanStep' => "", - 'HasPanSpeed' => "", - 'MinPanSpeed' => "", - 'MaxPanSpeed' => "", - 'HasTurboPan' => "", - 'TurboPanSpeed' => "", - 'CanTilt' => "", - 'MinTiltRange' => "", - 'MaxTiltRange' => "", - 'MinTiltStep' => "", - 'MaxTiltStep' => "", - 'HasTiltSpeed' => "", - 'MinTiltSpeed' => "", - 'MaxTiltSpeed' => "", - 'HasTurboTilt' => "", - 'TurboTiltSpeed' => "", - 'CanZoom' => "", - 'CanZoomAbs' => "", - 'CanZoomRel' => "", - 'CanZoomCon' => "", - 'MinZoomRange' => "", - 'MaxZoomRange' => "", - 'MinZoomStep' => "", - 'MaxZoomStep' => "", - 'HasZoomSpeed' => "", - 'MinZoomSpeed' => "", - 'MaxZoomSpeed' => "", - 'CanFocus' => "", - 'CanAutoFocus' => "", - 'CanFocusAbs' => "", - 'CanFocusRel' => "", - 'CanFocusCon' => "", - 'MinFocusRange' => "", - 'MaxFocusRange' => "", - 'MinFocusStep' => "", - 'MaxFocusStep' => "", - 'HasFocusSpeed' => "", - 'MinFocusSpeed' => "", - 'MaxFocusSpeed' => "", - 'CanIris' => "", - 'CanAutoIris' => "", - 'CanIrisAbs' => "", - 'CanIrisRel' => "", - 'CanIrisCon' => "", - 'MinIrisRange' => "", - 'MaxIrisRange' => "", - 'MinIrisStep' => "", - 'MaxIrisStep' => "", - 'HasIrisSpeed' => "", - 'MinIrisSpeed' => "", - 'MaxIrisSpeed' => "", - 'CanGain' => "", - 'CanAutoGain' => "", - 'CanGainAbs' => "", - 'CanGainRel' => "", - 'CanGainCon' => "", - 'MinGainRange' => "", - 'MaxGainRange' => "", - 'MinGainStep' => "", - 'MaxGainStep' => "", - 'HasGainSpeed' => "", - 'MinGainSpeed' => "", - 'MaxGainSpeed' => "", - 'CanWhite' => "", - 'CanAutoWhite' => "", - 'CanWhiteAbs' => "", - 'CanWhiteRel' => "", - 'CanWhiteCon' => "", - 'MinWhiteRange' => "", - 'MaxWhiteRange' => "", - 'MinWhiteStep' => "", - 'MaxWhiteStep' => "", - 'HasWhiteSpeed' => "", - 'MinWhiteSpeed' => "", - 'MaxWhiteSpeed' => "", - 'HasPresets' => "", - 'NumPresets' => "", - 'HasHomePreset' => "", - 'CanSetPresets' => "", - ); - } - $newControl = $control; + if ( !empty($_REQUEST['cid']) ) { + $Control = dbFetchOne('SELECT * FROM Controls WHERE Id = ?', NULL, array($_REQUEST['cid'])); + } else { + $Control = array( + 'Name' => translate('New'), + 'Type' => 'Local', + 'Protocol' => '', + 'CanWake' => '', + 'CanSleep' => '', + 'CanReset' => '', + 'CanReboot' => '', + 'CanMove' => '', + 'CanMoveDiag' => '', + 'CanMoveMap' => '', + 'CanMoveAbs' => '', + 'CanMoveRel' => '', + 'CanMoveCon' => '', + 'CanPan' => '', + 'MinPanRange' => '', + 'MaxPanRange' => '', + 'MinPanStep' => '', + 'MaxPanStep' => '', + 'HasPanSpeed' => '', + 'MinPanSpeed' => '', + 'MaxPanSpeed' => '', + 'HasTurboPan' => '', + 'TurboPanSpeed' => '', + 'CanTilt' => '', + 'MinTiltRange' => '', + 'MaxTiltRange' => '', + 'MinTiltStep' => '', + 'MaxTiltStep' => '', + 'HasTiltSpeed' => '', + 'MinTiltSpeed' => '', + 'MaxTiltSpeed' => '', + 'HasTurboTilt' => '', + 'TurboTiltSpeed' => '', + 'CanZoom' => '', + 'CanZoomAbs' => '', + 'CanZoomRel' => '', + 'CanZoomCon' => '', + 'MinZoomRange' => '', + 'MaxZoomRange' => '', + 'MinZoomStep' => '', + 'MaxZoomStep' => '', + 'HasZoomSpeed' => '', + 'MinZoomSpeed' => '', + 'MaxZoomSpeed' => '', + 'CanFocus' => '', + 'CanAutoFocus' => '', + 'CanFocusAbs' => '', + 'CanFocusRel' => '', + 'CanFocusCon' => '', + 'MinFocusRange' => '', + 'MaxFocusRange' => '', + 'MinFocusStep' => '', + 'MaxFocusStep' => '', + 'HasFocusSpeed' => '', + 'MinFocusSpeed' => '', + 'MaxFocusSpeed' => '', + 'CanIris' => '', + 'CanAutoIris' => '', + 'CanIrisAbs' => '', + 'CanIrisRel' => '', + 'CanIrisCon' => '', + 'MinIrisRange' => '', + 'MaxIrisRange' => '', + 'MinIrisStep' => '', + 'MaxIrisStep' => '', + 'HasIrisSpeed' => '', + 'MinIrisSpeed' => '', + 'MaxIrisSpeed' => '', + 'CanGain' => '', + 'CanAutoGain' => '', + 'CanGainAbs' => '', + 'CanGainRel' => '', + 'CanGainCon' => '', + 'MinGainRange' => '', + 'MaxGainRange' => '', + 'MinGainStep' => '', + 'MaxGainStep' => '', + 'HasGainSpeed' => '', + 'MinGainSpeed' => '', + 'MaxGainSpeed' => '', + 'CanWhite' => '', + 'CanAutoWhite' => '', + 'CanWhiteAbs' => '', + 'CanWhiteRel' => '', + 'CanWhiteCon' => '', + 'MinWhiteRange' => '', + 'MaxWhiteRange' => '', + 'MinWhiteStep' => '', + 'MaxWhiteStep' => '', + 'HasWhiteSpeed' => '', + 'MinWhiteSpeed' => '', + 'MaxWhiteSpeed' => '', + 'HasPresets' => '', + 'NumPresets' => '', + 'HasHomePreset' => '', + 'CanSetPresets' => '', + ); + } } -xhtmlHeaders(__FILE__, translate('ControlCap').' - '.$newControl['Name']); +xhtmlHeaders(__FILE__, translate('ControlCap').' - '.$Control['Name']); ?>
- -
-
- -
-
- - +
+ +
+
+ + +
+
+

-

+
-
-

-

-
-
- -
-
- - - - + +
+ + + + + +
$value ) { + echo '
'.PHP_EOL; ?> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - +
- - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - + + + + + + + + + + + + + + + +
translate('Local'), 'Remote'=>translate('Remote'), 'Ffmpeg'=>translate('Ffmpeg'), 'Libvlc'=>translate('Libvlc'), 'cURL'=>'cURL'); - echo buildSelect('newControl[Type]', $types); ?>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
+translate('Local'), + 'Remote'=>translate('Remote'), + 'Ffmpeg'=>translate('Ffmpeg'), + 'Libvlc'=>translate('Libvlc'), + 'cURL'=>'cURL' + ); + echo buildSelect('Control[Type]', $types); +?> +
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked">
checked="checked"/>
checked="checked"/>
checked="checked">
checked="checked"/>
checked="checked"/>
checked="checked">
checked="checked"/>
checked="checked"/>
checked="checked">
checked="checked"/>
checked="checked"/>
checked="checked">
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked">
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked">
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked">
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
checked="checked"/>
+
+ +
- +