Isaac ConnorandClaude Opus 5.5 e99a0531a1 fix: replace and refuse the shipped ZM_AUTH_HASH_SECRET refs GHSA-wmcc-x64g-jr84 GHSA-p2c6-jw8f-ffjc ...

ZM_AUTH_HASH_SECRET signs the JWT access and refresh tokens, and its
default is a fixed string in the public source. Nothing generated a
per-install value and tokens signed with the default verified normally,
so on an install with auth on and the secret untouched anyone could sign
an admin token and be accepted by the web UI, the API and zms.

- ZoneMinder::Config::saveConfigToDB() now replaces an empty or default
  secret with 32 random bytes from /dev/urandom, hex encoded. Package
  installs and upgrades run zmupdate.pl -f, which saves the config, so
  existing installs get a secret on upgrade. A secret the admin set is
  left alone.
- validateToken() in PHP and zmLoadTokenUser() in C++ refuse to verify
  tokens while the secret is empty or the default, and the API refuses to
  issue them, as it already did for an empty secret.
- zmLoadTokenUser() no longer writes the signing key to the debug log.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-09-28 19:47:22 -04:00

..

bindings.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

CMakeLists.txt

refactor: rename rtsp server fifo sources to stream sources

2026-09-16 05:00:44 +10:00

jinclude.h

Migrate svn to git

2013-03-17 00:45:21 +01:00

zm_analysis_thread.cpp

Wait on the packetqueue condition instead of sleeping. Should help analysis keep up with decoding better and offer faster shutdown.

2026-02-04 20:44:17 -05:00

zm_analysis_thread.h

Add Join() function

2024-10-26 14:29:40 -04:00

zm_audio_detector.cpp

feat: measure the audio level on demand, with a meter in the editor

2026-09-20 18:17:44 -05:00

zm_audio_detector.h

feat: measure the audio level on demand, with a meter in the editor

2026-09-20 18:17:44 -05:00

zm_box.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_buffer.cpp

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_buffer.h

fix: prevent null pointer dereference in Buffer::tidy()

2026-02-02 20:34:33 -05:00

zm_camera.cpp

fix: free previously-owned buffer in AssignDirect(AVFrame); nullptr-safe logs (PR #4788)

2026-06-02 21:39:16 -04:00

zm_camera.h

Reapply "fix: replace ZM_COLOUR system with AVPixelFormat for format dispatch"

2026-05-03 12:24:43 -04:00

zm_comms.cpp

fix: repair latent zm::comms bugs exposed by first TcpUnixServer use

2026-09-16 05:00:44 +10:00

zm_comms.h

fix: repair latent zm::comms bugs exposed by first TcpUnixServer use

2026-09-16 05:00:44 +10:00

zm_config_data.h.in

fix: add www-data to video group and font path fallback refs #4642

2026-02-23 18:19:20 -05:00

zm_config.cpp

fix: validate the numeric stream socket settings when reading zm.conf

2026-09-16 05:12:43 +10:00

zm_config.h

feat: add zm.conf settings for stream socket permissions and limits

2026-09-16 05:00:44 +10:00

zm_crypt.cpp

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_crypt.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_crypto_generics.h

Misc: Rename namespace ZM to zm

2021-06-06 19:11:11 +02:00

zm_crypto_gnutls.h

Crypto: Implement SHA1 hashing

2021-05-30 22:56:21 +02:00

zm_crypto_openssl.h

Crypto: Implement SHA1 hashing

2021-05-30 22:56:21 +02:00

zm_db.cpp

fix: retry deadlocked queries with bounded backoff instead of failing them

2026-09-04 07:15:30 -04:00

zm_db.h

fix: retry deadlocked queries with bounded backoff instead of failing them

2026-09-04 07:15:30 -04:00

zm_decoder_thread.cpp

fix: flush decoder_queue on decoder thread exit to avoid stale latency offset across reconnect

2026-05-14 07:38:58 -04:00

zm_decoder_thread.h

Add Join() function

2024-10-26 14:29:40 -04:00

zm_define.h

zm_define: Include cstddef so we have size_t

2021-05-16 16:42:58 +02:00

zm_event_tag.cpp

fix: return the insert id as uint64_t so event ids past 2^31 survive

2026-07-21 18:01:05 -04:00

zm_event_tag.h

fix: return the insert id as uint64_t so event ids past 2^31 survive

2026-07-21 18:01:05 -04:00

zm_event.cpp

feat: persist the peak audio level on each frame row

2026-09-20 18:17:43 -05:00

zm_event.h

fix: do not treat EPERM as missing hard link support on FreeBSD refs #5048

2026-08-18 06:31:14 +05:30

zm_eventstream.cpp

fix: use only the filename part of event DefaultVideo in zms and zma

2026-09-24 23:16:11 -04:00

zm_eventstream.h

perf: reuse Image buffer in EventStream::sendFrame to cut per-frame heap allocations

2026-06-18 17:45:12 -04:00

zm_exception.cpp

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_exception.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_ffmpeg_camera.cpp

feat: allow newlines to separate entries in the monitor Options field

2026-08-08 11:56:43 -04:00

zm_ffmpeg_camera.h

feat: add realtime pacing option for ffmpeg file sources

2026-07-01 10:08:58 -04:00

zm_ffmpeg_input.cpp

fix: restore generic decoder fallback for ffmpeg cameras

2026-07-19 11:26:03 -04:00

zm_ffmpeg_input.h

Cleanup constructor and add the new codec_data stuff to try out multiple codecs

2025-09-22 09:52:25 -04:00

zm_ffmpeg_output.cpp

fix: add null check and fix error message in FFmpeg_Output

2026-02-03 11:03:17 -05:00

zm_ffmpeg_output.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_ffmpeg.cpp

fix: map deprecated YUVJ pixel formats on the swscale output side fixes #5037

2026-08-05 17:44:37 -04:00

zm_ffmpeg.h

fix: map deprecated YUVJ pixel formats on the swscale output side fixes #5037

2026-08-05 17:44:37 -04:00

zm_fifo_debug.cpp

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_fifo_debug.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_fifo_stream.cpp

fix: correct error message and add null check in FifoStream

2026-02-03 11:36:53 -05:00

zm_fifo_stream.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_fifo.cpp

refactor!: remove media FIFO output from zmc

2026-09-16 05:02:24 +10:00

zm_fifo.h

refactor!: remove media FIFO output from zmc

2026-09-16 05:02:24 +10:00

zm_file_camera.cpp

fix: size the buffer for the file's dimensions in Image::ReadJpeg refs GHSA-rpp4-xmqm-84ff

2026-09-28 19:44:57 -04:00

zm_file_camera.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_font.cpp

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_font.h

Utils: Add our own ASSERT macro

2021-05-30 21:41:58 +02:00

zm_frame.cpp

feat: persist the peak audio level on each frame row

2026-09-20 18:17:43 -05:00

zm_frame.h

feat: persist the peak audio level on each frame row

2026-09-20 18:17:43 -05:00

zm_group_permission.cpp

fix: resolve role-based group permissions not granting stream access

2026-03-09 15:07:14 -04:00

zm_group_permission.h

fix: resolve role-based group permissions not granting stream access

2026-03-09 15:07:14 -04:00

zm_group.cpp

fix: correct typo in Group warning message

2026-02-03 11:42:14 -05:00

zm_group.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_image_analyser.cpp

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_image_analyser.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_image.cpp

fix: size the buffer for the file's dimensions in Image::ReadJpeg refs GHSA-rpp4-xmqm-84ff

2026-09-28 19:44:57 -04:00

zm_image.h

fix: carry the zone's alarm colour on the alarmed and filtered pixel methods

2026-09-22 09:57:19 -04:00

zm_jpeg.cpp

Change various cases of int img_buffer_size to size_t

2025-07-19 14:18:32 -04:00

zm_jpeg.h

Change various cases of int img_buffer_size to size_t

2025-07-19 14:18:32 -04:00

zm_libvlc_camera.cpp

feat: allow newlines to separate entries in the monitor Options field

2026-08-08 11:56:43 -04:00

zm_libvlc_camera.h

fix: address review feedback on camera buffer overflow fix

2026-06-18 07:54:15 +10:00

zm_libvnc_camera.cpp

fix: address review feedback on camera buffer overflow fix

2026-06-18 07:54:15 +10:00

zm_libvnc_camera.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_line.h

Polygon: Implement clipping to a boundary box

2021-05-16 19:41:45 +02:00

zm_local_camera.cpp

fix: map deprecated YUVJ pixel formats on the swscale output side fixes #5037

2026-08-05 17:44:37 -04:00

zm_local_camera.h

Make most Fatals into Errors

2026-01-29 18:50:42 -05:00

zm_logger.cpp

fix: rotate logs on SIGWINCH instead of SIGHUP fixes #5063

2026-08-22 15:30:46 -04:00

zm_logger.h

fix: rotate logs on SIGWINCH instead of SIGHUP fixes #5063

2026-08-22 15:30:46 -04:00

zm_mem_utils.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_monitor_amcrest.cpp

fix: add HAVE_LIBCURL preprocessor guards to fix ZM_NO_CURL=ON build

2026-03-05 02:13:59 +00:00

zm_monitor_go2rtc.cpp

refactor: redesign C++ config to use name-based lookup with compiled-in defaults

2026-08-29 14:01:25 -04:00

zm_monitor_janus.cpp

refactor: redesign C++ config to use name-based lookup with compiled-in defaults

2026-08-29 14:01:25 -04:00

zm_monitor_monitorlink.cpp

fix: keep linked event open while source monitor is in ALERT state

2026-06-01 16:31:25 -04:00

zm_monitor_onvif.cpp

Take importance into account when logging failure to subscribe

2026-09-10 11:26:47 -04:00

zm_monitor_onvif.h

refactor: drop the invented fault_code parameter from ONVIFIsAuthError

2026-09-04 06:53:51 -04:00

zm_monitor_permission.cpp

fix: resolve role-based group permissions not granting stream access

2026-03-09 15:07:14 -04:00

zm_monitor_permission.h

fix: resolve role-based group permissions not granting stream access

2026-03-09 15:07:14 -04:00

zm_monitor_rtsp2web.cpp

fix: add HAVE_LIBCURL preprocessor guards to fix ZM_NO_CURL=ON build

2026-03-05 02:13:59 +00:00

zm_monitor.cpp

Merge pull request #5143 from SteveGilvarry/feature/stream-socket-events

2026-09-23 18:17:50 -04:00

zm_monitor.h

Merge pull request #5143 from SteveGilvarry/feature/stream-socket-events

2026-09-23 18:17:50 -04:00

zm_monitorlink_expression.cpp

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_monitorlink_expression.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_monitorlink_token.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_monitorstream.cpp

fix: release held frames and set the terminate flag on every stream exit

2026-09-12 12:44:55 -04:00

zm_monitorstream.h

fix: make MonitorStream playback state shared with the command thread atomic fixes #4939

2026-08-16 16:46:47 +05:30

zm_mpeg.cpp

fix: report AVPixelFormat in Panic messages for actionable diagnosis (PR #4788)

2026-05-26 23:03:33 -04:00

zm_mpeg.h

fix: prevent segfault when MPEG stream codec fails to open

2026-03-05 02:15:08 +00:00

zm_mqtt.cpp

fix: use mosquitto_strerror() for MQTT error codes

2026-02-02 20:53:00 -05:00

zm_mqtt.h

Fix definition of on_publish

2024-10-29 13:30:29 -04:00

zm_packet.cpp

fix: Rotate/Flip honor borrowed source linesize; size Flip dest for 32-aligned planes

2026-06-13 09:35:40 -04:00

zm_packet.h

perf: replace sleep polling with condition wait in Event::Run()

2026-02-15 15:38:07 -05:00

zm_packetqueue.cpp

fix(packetqueue): destroy packets after releasing mutex; drop dead code

2026-06-01 11:54:32 -04:00

zm_packetqueue.h

fix(packetqueue): destroy packets after releasing mutex; drop dead code

2026-06-01 11:54:32 -04:00

zm_pixformat.h

fix: include <libavutil/pixdesc.h> in zm_pixformat.h (PR #4788)

2026-06-06 11:49:30 -04:00

zm_poll_thread.cpp

fix: call Stop() before restarting in PollThread::Start()

2026-02-03 12:13:29 -05:00

zm_poll_thread.h

Adds ONVIF Motion Detection Support

2022-01-06 16:45:15 -06:00

zm_poly.cpp

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_poly.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_regexp.cpp

Port to PCRE2 (Closes: #3384).

2025-02-26 21:04:32 +11:00

zm_regexp.h

Port to PCRE2 (Closes: #3384).

2025-02-26 21:04:32 +11:00

zm_remote_camera_http.cpp

fix: bound HTTP camera response header copies to prevent buffer overflow

2026-07-26 20:30:42 -04:00

zm_remote_camera_http.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_remote_camera_nvsocket.cpp

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_remote_camera_nvsocket.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_remote_camera_rtsp.cpp

fix: nullptr-safe pixfmt name; route GetImage/getSnapshot through ReadShmFrame (PR #4788)

2026-05-31 09:22:09 -04:00

zm_remote_camera_rtsp.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_remote_camera.cpp

fix: check for empty path before accessing first character

2026-02-03 12:25:21 -05:00

zm_remote_camera.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_rgb.h

Reapply "fix: replace ZM_COLOUR system with AVPixelFormat for format dispatch"

2026-05-03 12:24:43 -04:00

zm_rtp_ctrl.cpp

fix: correct NTP timestamp type truncation in RtpCtrlThread

2026-02-03 12:34:21 -05:00

zm_rtp_ctrl.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_rtp_data.cpp

fix: correct type mismatches in RtpDataThread

2026-02-03 12:45:56 -05:00

zm_rtp_data.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_rtp_source.cpp

fix: cast tv_usec for %jd so armhf varargs stay aligned refs #4580

2026-08-26 11:23:11 +05:30

zm_rtp_source.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_rtp.cpp

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_rtp.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_rtsp_auth.cpp

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_rtsp_auth.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_rtsp_server_authenticator.h

Fix Authenticate as nonce is now internal

2026-01-09 11:43:15 -05:00

zm_rtsp_server_frame.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_rtsp_server_session_tracker.h

fix: gate rtsp media on a session confirmed against the latest HELLO set

2026-09-23 15:07:15 +10:00

zm_rtsp_server_stream_adts_source.cpp

feat: drive rtsp server sessions from the monitor stream socket

2026-09-16 05:02:23 +10:00

zm_rtsp_server_stream_adts_source.h

feat: drive rtsp server sessions from the monitor stream socket

2026-09-16 05:02:23 +10:00

zm_rtsp_server_stream_audio_source.cpp

feat: drive rtsp server sessions from the monitor stream socket

2026-09-16 05:02:23 +10:00

zm_rtsp_server_stream_audio_source.h

feat: drive rtsp server sessions from the monitor stream socket

2026-09-16 05:02:23 +10:00

zm_rtsp_server_stream_av1_source.cpp

feat: drive rtsp server sessions from the monitor stream socket

2026-09-16 05:02:23 +10:00

zm_rtsp_server_stream_av1_source.h

feat: drive rtsp server sessions from the monitor stream socket

2026-09-16 05:02:23 +10:00

zm_rtsp_server_stream_h264_source.cpp

feat: drive rtsp server sessions from the monitor stream socket

2026-09-16 05:02:23 +10:00

zm_rtsp_server_stream_h264_source.h

feat: drive rtsp server sessions from the monitor stream socket

2026-09-16 05:02:23 +10:00

zm_rtsp_server_stream_source.cpp

fix: drop superseded-generation media and join rtsp packers safely

2026-09-19 23:00:24 +00:00

zm_rtsp_server_stream_source.h

fix: drop superseded-generation media and join rtsp packers safely

2026-09-19 23:00:24 +00:00

zm_rtsp_server_stream_video_source.cpp

feat: drive rtsp server sessions from the monitor stream socket

2026-09-16 05:02:23 +10:00

zm_rtsp_server_stream_video_source.h

feat: drive rtsp server sessions from the monitor stream socket

2026-09-16 05:02:23 +10:00

zm_rtsp_server.cpp

fix: gate rtsp media on a session confirmed against the latest HELLO set

2026-09-23 15:07:15 +10:00

zm_rtsp.cpp

fix: bound the RTSP handshake field parsing

2026-09-24 19:48:40 -04:00

zm_rtsp.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_sdp.cpp

fix: bound sprop-parameter-sets copy to prevent SDP stack overflow

2026-07-26 22:45:00 -04:00

zm_sdp.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_sendfile.h

Fix complaint

2023-01-18 16:01:42 -05:00

zm_server.cpp

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_server.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_signal.cpp

fix: read instruction pointer from Darwin mcontext in crash handler refs #4998

2026-09-12 15:19:25 +10:00

zm_signal.h

refactor: make zm_terminate a std::atomic<bool>

2026-06-14 19:11:51 -04:00

zm_storage.cpp

fix: add empty checks and use safer string functions in Storage

2026-02-03 12:30:06 -05:00

zm_storage.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_stream_socket_client.cpp

fix: refuse over-long stream socket paths and media for unknown stream ids

2026-09-23 15:07:15 +10:00

zm_stream_socket_client.h

fix: harden stream socket transport and protocol from PR review

2026-09-19 23:00:03 +00:00

zm_stream_socket_protocol.cpp

fix: harden stream socket transport and protocol from PR review

2026-09-19 23:00:03 +00:00

zm_stream_socket_protocol.h

fix: send audio HELLO first and keep rtsp sessions across a zmc restart

2026-09-20 00:36:35 +00:00

zm_stream_socket.cpp

fix: refuse over-long stream socket paths and media for unknown stream ids

2026-09-23 15:07:15 +10:00

zm_stream_socket.h

fix: frame the stream socket snapshot when a consumer connects

2026-09-23 15:07:15 +10:00

zm_stream.cpp

fix: send pre-scaled frames as built when scale or zoom changes refs #3681

2026-08-26 18:22:39 +05:30

zm_stream.h

fix: send pre-scaled frames as built when scale or zoom changes refs #3681

2026-08-26 18:22:39 +05:30

zm_swscale.cpp

fix: map deprecated YUVJ pixel formats on the swscale output side fixes #5037

2026-08-05 17:44:37 -04:00

zm_swscale.h

fix: corrupted scaled/converted output for rotated monitors — SWScale guessed buffer alignment from width

2026-06-13 10:19:09 +10:00

zm_tag.cpp

fix: use the real Tags.LastAssignedDate column in the Tag queries

2026-09-06 00:46:43 +05:30

zm_tag.h

Add tags support to events.

2025-07-05 08:09:09 -04:00

zm_time.cpp

fix: store event StartDateTime with second precision to match disk path refs #4870

2026-06-03 08:42:10 -04:00

zm_time.h

fix: start the monitor stream socket before capture connects

2026-09-19 23:00:14 +00:00

zm_uri.cpp

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_uri.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_user.cpp

fix: replace and refuse the shipped ZM_AUTH_HASH_SECRET refs GHSA-wmcc-x64g-jr84 GHSA-p2c6-jw8f-ffjc

2026-09-28 19:47:22 -04:00

zm_user.h

fix: resolve role-based group permissions not granting stream access

2026-03-09 15:07:14 -04:00

zm_utils.cpp

fix: only trust X-Forwarded-For from configured proxies for auth hash IPs

2026-09-24 19:51:27 -04:00

zm_utils.h

fix: only trust X-Forwarded-For from configured proxies for auth hash IPs

2026-09-24 19:51:27 -04:00

zm_vector2.h

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zm_videostore.cpp

fix: retry the encoder open once a previous event has released its own

2026-09-07 12:20:44 -04:00

zm_videostore.h

fix: fall back to passthrough when no video encoder will open

2026-09-07 12:02:31 -04:00

zm_zone_stats.h

perf: reduce logging overhead and string temporaries in Analyse()

2026-02-07 22:52:15 -05:00

zm_zone.cpp

fix: carry the zone's alarm colour on the alarmed and filtered pixel methods

2026-09-22 09:57:19 -04:00

zm_zone.h

fix: carry the zone's alarm colour on the alarmed and filtered pixel methods

2026-09-22 09:57:19 -04:00

zm.cpp

Move exit_zms to exit_zm in zm.cpp

2026-01-05 16:36:36 -05:00

zm.h

Move exit_zms to exit_zm in zm.cpp

2026-01-05 16:36:36 -05:00

zma.cpp

fix: use only the filename part of event DefaultVideo in zms and zma

2026-09-24 23:16:11 -04:00

zmbenchmark.cpp

Format code using astyle google format

2024-03-26 13:43:58 -05:00

zmc.cpp

fix: start the monitor stream socket before capture connects

2026-09-19 23:00:14 +00:00

zms.cpp

fix: authorize zms event streams on the event's own monitor refs GHSA-4r2m-68p2-phf7

2026-09-28 19:44:57 -04:00

zmu.cpp

Remove unused loop index in zmu list output

2025-12-31 22:29:37 +11:00