mirror of
https://github.com/ZoneMinder/zoneminder.git
synced 2026-10-03 07:55:22 -04:00
Isaac Connor
d73c7b18da
The monitor attribute filters and the event filter terms were unrelated pieces of UI that happened to sit next to each other. They are not independent: Name, Capturing, Analysing, Recording, Status and Source do not filter events at all, they narrow which monitors exist to choose between - which is to say they decide what the Monitor term should offer. Anything they exclude cannot appear in the events either, so offering it in the term is offering a choice that returns nothing. Filter carries the restriction rather than the widget taking it as an argument: monitor_options() is a get/set in the same shape as terms(), so a view states the rule on the filter and then asks that filter for a widget. Unset, the Monitor term offers every monitor the user can view, so events.php and any other caller is unchanged. montagereview sets the monitors that survived its filter bar. Verified on the install this repo matches: the events view still lists all monitors in its Monitor term, montage review renders its event filters as Monitor, Date Time, Date Time, Archive Status, Tags, Notes with Name, Capturing, Analysing, Recording, Status and Source collapsed, and the events, console and filter views all still load.