Files
zoneminder/scripts/zmtrack.pl.in
T
Steve GilvarryandClaude Opus 5 ba49bbb33c fix: make the Perl scripts' taint-safe PATH configurable
The scripts run under -T, so they cannot trust the caller's PATH and set
their own. Sixteen of them hardcoded /bin:/usr/bin:/usr/local/bin, which
assumes everything they shell out to lives under /usr or /usr/local.

ZoneMinder::General::findDbCommand looks for a database client on that
PATH, and zmupdate.pl and zmcamtool.pl run what it finds. So an install
whose client sits anywhere else cannot apply schema changes:

  sh: mysql: command not found
  Command 'mysql -u'zmuser' ... ' exited with status: 127

even with the client on the caller's PATH. Homebrew on Apple Silicon is
the case that surfaced it - the client is in /opt/homebrew/bin - but a
--prefix=/opt install on Linux has the same shape, as does anything that
keeps its database client outside the FHS locations.

Replaced the literal with @ZM_SCRIPT_PATH@, defaulting to the same three
directories plus wherever cmake actually found a client, and overridable
for packagers who want to pin it. Warn at configure time when no client
is found at all, since that failure otherwise appears much later and
says something unrelated.

Nothing changes for an install whose client is already under /usr/bin:
the directory is only appended when it is not in the list, so the
default stays exactly as it was.

Memory.pm is deliberately left alone. It has a narrower PATH of
/bin:/usr/bin, and the only command it runs is uname through an absolute
path from ZM_PATH_UNAME, so it does not need widening.

Verified on macOS across the three cases: with the client in
/opt/homebrew/bin the directory is appended; -DZM_SCRIPT_PATH= is
respected verbatim; and pointing detection at /usr/bin/mariadb leaves
the default untouched. Build clean, suite 146 cases.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B5KL9Xbi7K5aGsauLtd8tG
2026-09-13 13:04:59 +10:00

211 lines
5.2 KiB
Plaintext

#!@PERL_EXECUTABLE@ -wT
#
# ==========================================================================
#
# ZoneMinder Experimental PTZ Tracking Script, $Date: 2009-06-08 10:11:56 +0100 (Mon, 08 Jun 2009) $, $Revision: 2908 $
# Copyright (C) 2001-2008 Philip Coombes
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
#
# ==========================================================================
=head1 NAME
zmtrack.pl - ZoneMinder Experimental PTZ Tracking Script
=head1 SYNOPSIS
zmtrack.pl -m <monitor>
zmtrack.pl --monitor=<monitor>
=head1 OPTIONS
-m<monitor>, --monitor=<monitor> - Id of the monitor to track
=head1 DESCRIPTION
This script is used to trigger and cancel alarms from external sources
using an arbitrary text based format.
=cut
use strict;
use bytes;
# ==========================================================================
#
# User config
#
# ==========================================================================
use constant SLEEP_TIME => 10000; # In microseconds
# ==========================================================================
#
# Don't change anything from here on down
#
# ==========================================================================
@EXTRA_PERL_LIB@
use ZoneMinder;
use DBI;
use POSIX;
use autouse 'Data::Dumper'=>qw(Dumper);
use Getopt::Long;
use autouse 'Pod::Usage'=>qw(pod2usage);
use Time::HiRes qw( usleep );
$| = 1;
$ENV{PATH} = '@ZM_SCRIPT_PATH@';
$ENV{SHELL} = '/bin/sh' if exists $ENV{SHELL};
delete @ENV{qw(IFS CDPATH ENV BASH_ENV)};
my $mid = 0;
GetOptions( 'monitor=s'=>\$mid )
or pod2usage(-exitstatus => -1);
my ( $detaint_mid ) = $mid =~ /^(\d+)$/;
$mid = $detaint_mid;
logInit($mid?(id=>'zmtrack_m'.$mid):());
logSetSignal();
print( "Tracker daemon $mid (experimental) starting at "
.strftime( '%y/%m/%d %H:%M:%S', localtime() )
."\n"
);
my $dbh = zmDbConnect();
my $sql = 'SELECT C.*,M.* FROM Monitors as M
LEFT JOIN Controls as C on M.ControlId = C.Id
WHERE M.Id = ?'
;
my $sth = $dbh->prepare_cached( $sql )
or Fatal("Can't prepare '$sql': ".$dbh->errstr());
my $res = $sth->execute( $mid )
or Fatal("Can't execute '$sql': ".$sth->errstr());
my $monitor = $sth->fetchrow_hashref();
if ( !$monitor ) {
Fatal("Can't find monitor '$mid'");
}
if ( !$monitor->{Controllable} ) {
Fatal("Monitor '$mid' is not controllable");
}
if ( !$monitor->{TrackMotion} ) {
Fatal("Monitor '$mid' is not configured to track motion");
}
if ( !$monitor->{CanMoveMap} ) {
if ( $monitor->{CanMoveRel} ) {
Warning("Monitor '$mid' cannot move in map mode, falling back to pseudo map mode");
} else {
Fatal("Monitor '$mid' cannot move in map mode");
}
}
exit(-1) if !zmMemVerify($monitor);
sub Suspend {
my $monitor = shift;
zmMonitorSuspend($monitor);
}
sub Resume {
my $monitor = shift;
sleep($monitor->{TrackDelay});
zmMonitorResume($monitor);
}
sub Track {
my $monitor = shift;
my ( $x, $y ) = @_;
my ( $detaint_x ) = $x =~ /^(\d+)$/; $x = $detaint_x;
my ( $detaint_y ) = $y =~ /^(\d+)$/; $y = $detaint_y;
my $ctrlCommand = $Config{ZM_PATH_BIN}
.'/zmcontrol.pl -i '
.$monitor->{Id}
;
$ctrlCommand .= ' --command='
.( $monitor->{CanMoveMap} ? 'moveMap'
: 'movePseudoMap'
)
." --xcoord=$x --ycoord=$y"
;
executeShellCommand($ctrlCommand);
}
sub Return {
my $monitor = shift;
my $ctrlCommand = $Config{ZM_PATH_BIN}
.'/zmcontrol.pl -i '
.$monitor->{Id}
;
if ( $monitor->{ReturnLocation} > 0 ) {
$ctrlCommand .= ' --command=presetGoto --preset='
.$monitor->{ReturnLocation}
;
} else {
$ctrlCommand .= ' --command=presetHome';
}
executeShellCommand($ctrlCommand);
}
my $last_alarm = 0;
if ( ($monitor->{ReturnLocation} >= 0) ) {
Suspend($monitor);
Return($monitor);
Resume($monitor);
}
my $alarmed = undef;
while( 1 ) {
if ( zmIsAlarmed($monitor) ) {
my ( $alarm_x, $alarm_y ) = zmGetAlarmLocation($monitor);
if ( $alarm_x >= 0 && $alarm_y >= 0 ) {
Debug("Got alarm at $alarm_x, $alarm_y");
Suspend($monitor);
Track($monitor, $alarm_x, $alarm_y);
Resume($monitor);
$last_alarm = time();
$alarmed = !undef;
}
} else {
if ( logDebugging() && $alarmed ) {
Info('Left alarm state');
$alarmed = undef;
}
if ( ($monitor->{ReturnLocation} >= 0)
&& ($last_alarm > 0)
&& ((time()-$last_alarm) > $monitor->{ReturnDelay})
) {
Debug("Returning to location ".$monitor->{ReturnLocation});
Suspend($monitor);
Return($monitor);
Resume($monitor);
$last_alarm = 0;
}
}
usleep(SLEEP_TIME);
}
1;
__END__