mirror/Android
1
0
Fork 0
mirror of https://github.com/CatimaLoyalty/Android.git synced 2026-05-18 05:36:39 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix findBugs performance warning

Browse Source
This commit is contained in:
Sylvia van Os
2019-12-16 17:03:33 +01:00
parent 43148cb12c
commit 2ef4d3f6e0
2 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java
View File

@@ -30,6 +30,7 @@ import org.json.JSONException;
import java.util.HashMap;
import java.util.Locale;
import java.util.Map;
import protect.card_locker.preferences.Settings;
@@ -307,9 +308,9 @@ public class LoyaltyCardViewActivity extends AppCompatActivity
StringBuilder items = new StringBuilder();
HashMap<String, String> extraValues = loyaltyCard.extras.getAllValues(new String[]{Locale.getDefault().getLanguage(), "en", ""});
for(String key : extraValues.keySet())
for(Map.Entry<String, String> entry : extraValues.entrySet())
{
items.append(extraValues.get(key) + "\n");
items.append(entry.getValue() + "\n");
}
new AlertDialog.Builder(this)

13
app/src/main/java/protect/card_locker/PkpassImporter.java
View File

@@ -19,6 +19,7 @@ import java.io.InputStream;
import java.nio.charset.Charset;
import java.util.Arrays;
import java.util.HashMap;
import java.util.Map;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import java.util.zip.ZipEntry;
@@ -110,18 +111,18 @@ public class PkpassImporter {
extrasHelper.addLanguageValue("", key, formattedUntranslatedValue);
// Try to find translations
for(String language : translations.keySet())
for(Map.Entry<String, HashMap<String, String>> language : translations.entrySet())
{
String translatedLabel = label;
if(translations.get(language).containsKey(label))
if(language.getValue().containsKey(label))
{
translatedLabel = translations.get(language).get(label);
translatedLabel = language.getValue().get(label);
}
String translatedValue = value;
if(translations.get(language).containsKey(value))
if(language.getValue().containsKey(value))
{
translatedValue = translations.get(language).get(value);
translatedValue = language.getValue().get(value);
}
String formattedValue = translatedValue;
@@ -131,7 +132,7 @@ public class PkpassImporter {
formattedValue = translatedLabel + ": " + translatedValue;
}
extrasHelper.addLanguageValue(language, key, formattedValue);
extrasHelper.addLanguageValue(language.getKey(), key, formattedValue);
}
}