#308 Add new constructor for BarcodeImageWriterTask without associated TextView. Make barcode format selectable

This commit is contained in:
Sergio
2020-01-26 01:20:46 +01:00
parent 24061dae97
commit 72c1a57953
4 changed files with 12 additions and 5 deletions

View File

@@ -61,6 +61,11 @@ class BarcodeImageWriterTask extends AsyncTask<Void, Void, Bitmap>
}
}
BarcodeImageWriterTask(ImageView imageView, String cardIdString, BarcodeFormat barcodeFormat)
{
this(imageView, cardIdString, barcodeFormat, null);
}
private int getMaxWidth(BarcodeFormat format)
{
switch(format)
@@ -194,8 +199,9 @@ class BarcodeImageWriterTask extends AsyncTask<Void, Void, Bitmap>
{
Log.i(TAG, "Barcode generation failed, removing image from display");
imageView.setVisibility(View.GONE);
if (textView != null)
if (textView != null) {
textView.setVisibility(View.GONE);
}
}
}
}

View File

@@ -262,14 +262,14 @@ public class LoyaltyCardEditActivity extends AppCompatActivity
}
Log.d(TAG, "ImageView size now known");
new BarcodeImageWriterTask(barcodeImage, cardIdString, format, null).execute();
new BarcodeImageWriterTask(barcodeImage, cardIdString, format).execute();
}
});
}
else
{
Log.d(TAG, "ImageView size known known, creating barcode");
new BarcodeImageWriterTask(barcodeImage, cardIdString, format, null).execute();
new BarcodeImageWriterTask(barcodeImage, cardIdString, format).execute();
}
showBarcode();

View File

@@ -260,14 +260,14 @@ public class LoyaltyCardViewActivity extends AppCompatActivity
barcodeImage.getViewTreeObserver().removeOnGlobalLayoutListener(this);
Log.d(TAG, "ImageView size now known");
new BarcodeImageWriterTask(barcodeImage, cardIdString, format, null).execute();
new BarcodeImageWriterTask(barcodeImage, cardIdString, format).execute();
}
});
}
else
{
Log.d(TAG, "ImageView size known known, creating barcode");
new BarcodeImageWriterTask(barcodeImage, cardIdString, format, null).execute();
new BarcodeImageWriterTask(barcodeImage, cardIdString, format).execute();
}
}
else

View File

@@ -377,6 +377,7 @@
android:layout_width="match_parent"
android:padding="@dimen/inputPadding"
android:textSize="@dimen/inputSize"
android:textIsSelectable="true"
android:layout_toEndOf="@id/barcodeTypeField"
android:layout_toRightOf="@id/barcodeTypeField"
/>