Merge pull request #15 from brarcher/readme

mention barcode types in README.md

README.md

@@ -4,7 +4,19 @@
 [![F-Droid](https://upload.wikimedia.org/wikipedia/commons/thumb/0/0d/Get_it_on_F-Droid.svg/160px-Get_it_on_F-Droid.svg.png)](https://f-droid.org/repository/browse/?fdid=protect.card_locker "Loyalty Card Locker on F-Droid")
 
 
-Stores all of your store loyalty cards on your phone, removing the need to carry them around.  
+Stores all of your store loyalty cards on your phone, removing the need to carry them around.  Currently the following barcode types are supported:
+
+- AZTEC
+- CODABAR
+- CODE_39
+- CODE_128
+- DATA_MATRIX
+- EAN_8
+- EAN_13
+- ITF
+- PDF_417
+- QR_CODE
+- UPC_A
 
 If there is any interest in improving this project, kindly submit a pull request with
 proposed changes.

app/build.gradle

@@ -8,8 +8,8 @@ android {
         applicationId "protect.card_locker"
         minSdkVersion 17
         targetSdkVersion 23
-        versionCode 2
-        versionName "0.2"
+        versionCode 3
+        versionName "0.3"
     }
     buildTypes {
         release {
@@ -31,8 +31,8 @@ dependencies {
     compile fileTree(dir: 'libs', include: ['*.jar'])
     compile 'com.android.support:appcompat-v7:23.1.1'
     compile 'com.android.support:design:23.1.1'
-    compile 'com.journeyapps:zxing-android-embedded:3.0.1@aar'
-    compile 'com.google.zxing:core:3.2.0'
+    compile 'com.journeyapps:zxing-android-embedded:3.2.0@aar'
+    compile 'com.google.zxing:core:3.2.1'
     testCompile 'junit:junit:4.12'
     testCompile "org.robolectric:robolectric:3.0"
 }

app/src/main/AndroidManifest.xml

@@ -35,6 +35,7 @@
             android:name=".LoyaltyCardViewActivity"
             android:theme="@style/AppTheme.NoActionBar"
             android:configChanges="orientation|screenSize"
+            android:windowSoftInputMode="stateHidden"
             android:parentActivityName="protect.card_locker.MainActivity"/>
     </application>
 

app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java

@@ -23,11 +23,32 @@ import com.google.zxing.common.BitMatrix;
 import com.google.zxing.integration.android.IntentIntegrator;
 import com.google.zxing.integration.android.IntentResult;
 
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+
 
 public class LoyaltyCardViewActivity extends AppCompatActivity
 {
     private static final String TAG = "CardLocker";
 
+    // These are all the barcode types that the zxing library
+    // is able to generate a barcode for, and thus should be
+    // the only barcodes which we should attempt to scan.
+    Collection<String> supportedBarcodeTypes = Collections.unmodifiableList(Arrays.asList(
+            BarcodeFormat.AZTEC.name(),
+            BarcodeFormat.CODE_39.name(),
+            BarcodeFormat.CODE_128.name(),
+            BarcodeFormat.CODABAR.name(),
+            BarcodeFormat.DATA_MATRIX.name(),
+            BarcodeFormat.EAN_8.name(),
+            BarcodeFormat.EAN_13.name(),
+            BarcodeFormat.ITF.name(),
+            BarcodeFormat.PDF_417.name(),
+            BarcodeFormat.QR_CODE.name(),
+            BarcodeFormat.UPC_A.name()
+    ));
+
     @Override
     protected void onCreate(Bundle savedInstanceState)
     {
@@ -126,11 +147,14 @@ public class LoyaltyCardViewActivity extends AppCompatActivity
                     throw new IllegalArgumentException("Unrecognized barcode format: " + formatString);
                 }
 
+                int generateWidth = 100;
+                int generateHeight = 100;
+
                 String cardIdString = cardIdField.getText().toString();
 
                 Log.i(TAG, "Card: " + cardIdString);
 
-                result = writer.encode(cardIdString, format, 1500, 400, null);
+                result = writer.encode(cardIdString, format, generateWidth, generateHeight, null);
 
                 final int WHITE = 0xFFFFFFFF;
                 final int BLACK = 0xFF000000;
@@ -170,7 +194,7 @@ public class LoyaltyCardViewActivity extends AppCompatActivity
             public void onClick(View v)
             {
                 IntentIntegrator integrator = new IntentIntegrator(LoyaltyCardViewActivity.this);
-                integrator.setDesiredBarcodeFormats(IntentIntegrator.ONE_D_CODE_TYPES);
+                integrator.setDesiredBarcodeFormats(supportedBarcodeTypes);
 
                 String prompt = getResources().getString(R.string.scanCardBarcode);
                 integrator.setPrompt(prompt);

app/src/main/res/values/dimens.xml

@@ -6,5 +6,5 @@
     <dimen name="no_data_textSize">16sp</dimen>
     <dimen name="no_data_padding">22dp</dimen>
 
-    <dimen name="barcode_disp_height">50dp</dimen>
+    <dimen name="barcode_disp_height">200dp</dimen>
 </resources>