Release 0.4.3

see also #36

README.md

@@ -20,6 +20,7 @@ Features
 - Favorites list, also with availability information
 - No ads, fully open source
 - Compatible with Android 5.0 and above
+- Can use Google Maps or Mapbox (OpenStreetMap) as map backends - the version available on F-Droid only uses Mapbox.
 
 Screenshots
 -----------

app/build.gradle

@@ -13,8 +13,8 @@ android {
         applicationId "net.vonforst.evmap"
         minSdkVersion 21
         targetSdkVersion 30
-        versionCode 34
-        versionName "0.4.2"
+        versionCode 37
+        versionName "0.4.3"
 
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }

app/src/main/java/net/vonforst/evmap/fragment/FavoritesFragment.kt

@@ -86,8 +86,9 @@ class FavoritesFragment : Fragment(), LostApiClient.ConnectionCallbacks {
     }
 
     override fun onConnected() {
+        val context = this.context ?: return
         if (ContextCompat.checkSelfPermission(
-                requireContext(),
+                context,
                 Manifest.permission.ACCESS_FINE_LOCATION
             ) == PackageManager.PERMISSION_GRANTED
         ) {

app/src/main/java/net/vonforst/evmap/fragment/MapFragment.kt

@@ -224,7 +224,11 @@ class MapFragment : Fragment(), OnMapReadyCallback, MapsActivity.FragmentCallbac
         )
 
         if (!PreferenceDataSource(requireContext()).welcomeDialogShown) {
-            navController.navigate(R.id.action_map_to_welcome)
+            try {
+                navController.navigate(R.id.action_map_to_welcome)
+            } catch (ignored: IllegalArgumentException) {
+                // when there is already another navigation going on
+            }
         }
     }
 
@@ -1054,9 +1058,10 @@ class MapFragment : Fragment(), OnMapReadyCallback, MapsActivity.FragmentCallbac
 
     override fun onConnected() {
         val map = this.map ?: return
+        val context = this.context ?: return
         if (vm.myLocationEnabled.value == true) {
             if (ActivityCompat.checkSelfPermission(
-                    requireContext(),
+                    context,
                     ACCESS_FINE_LOCATION
                 ) == PackageManager.PERMISSION_GRANTED
             ) {

app/src/main/java/net/vonforst/evmap/ui/BindingAdapters.kt

@@ -163,8 +163,8 @@ fun setLinkify(textView: TextView, oldValue: Int, newValue: Int) {
     textView.linksClickable = newValue != 0
 
     // remove spans
-    if (newValue == 0) {
-        val text = textView.text as SpannableString
+    val text = textView.text
+    if (newValue == 0 && text != null && text is SpannableString) {
         text.getSpans(0, text.length, Any::class.java).forEach {
             text.removeSpan(it)
         }

fastlane/metadata/android/de-DE/changelogs/36.txt

@@ -0,0 +1,2 @@
+Verbesserungen:
+- Verschiedene Abstürze behoben

fastlane/metadata/android/en-US/changelogs/36.txt

@@ -0,0 +1,2 @@
+Improvements:
+- Fixed various crashes