incorporated code review feedback

This commit is contained in:
Kevin Papst
2017-12-09 13:52:05 +01:00
parent 0480d4331c
commit 452886ea3a
2 changed files with 6 additions and 4 deletions

View File

@@ -8,6 +8,9 @@ define('FRESHRSS_USERAGENT', 'FreshRSS/' . FRESHRSS_VERSION . ' (' . PHP_OS . ';
// PHP text output compression http://php.net/ob_gzhandler (better to do it at Web server level)
define('PHP_COMPRESSION', false);
// maximum log file size, before it will be purged (defaults to 512000 = 500kB)
define('MAX_LOG_SIZE', 512000);
// Constantes de chemins
define('FRESHRSS_PATH', dirname(__FILE__));

View File

@@ -20,8 +20,6 @@ class Minz_Log {
const NOTICE = 8;
const DEBUG = 16;
const MAX_LOG_SIZE = 512000; // 500kB
/**
* Enregistre un message dans un fichier de log spécifique
* Message non loggué si
@@ -91,8 +89,9 @@ class Minz_Log {
* @throws Minz_PermissionDeniedException
*/
protected static function checkLogfileSize($file_name) {
if (file_exists($file_name) && filesize($file_name) > self::MAX_LOG_SIZE) {
if (!unlink($file_name)) {
$maxSize = defined('MAX_LOG_SIZE') ? MAX_LOG_SIZE : 512000;
if (@filesize($file_name) > $maxSize) {
if (file_put_contents($file_name, '') === false) {
throw new Minz_PermissionDeniedException($file_name, Minz_Exception::ERROR);
}
}