Restrict valid paths in ext.php for extensions (#7474)

* Restrict valid paths in ext.php for extensions

* Disallow absolute paths as well
This commit is contained in:
Alexandre Alapetite authored and GitHub committed 2025-04-01 17:53:33 +02:00
1 parent aa3867ae12
commit 5cb73fa220
1 file changed
+5 -4
+5 -4
View File
@@ -76,14 +76,15 @@ function is_valid_path_extension(string $path, string $extensionPath, bool $isSt
*
* @param string $path the path to the file we want to serve.
* @return bool true if it can be served, false otherwise.
*
*/
function is_valid_path(string $path): bool {
return is_valid_path_extension($path, CORE_EXTENSIONS_PATH) || is_valid_path_extension($path, THIRDPARTY_EXTENSIONS_PATH)
|| is_valid_path_extension($path, USERS_PATH, false);
return !str_contains($path, '..') && !str_starts_with($path, '/') && !str_starts_with($path, '\\') && (
is_valid_path_extension($path, CORE_EXTENSIONS_PATH) ||
is_valid_path_extension($path, THIRDPARTY_EXTENSIONS_PATH) ||
is_valid_path_extension($path, USERS_PATH, false));
}
function sendBadRequestResponse(string $message = null): never {
function sendBadRequestResponse(?string $message = null): never {
header('HTTP/1.1 400 Bad Request');
die($message);
}