mirror/FreshRSS
0
0 Fork 0
mirror of https://github.com/FreshRSS/FreshRSS.git synced 2026-10-24 03:58:33 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add a deprecation log error for extensions (#3335)

Browse Source 
Extensions must override some parent methods. The rule is just a
guideline because only described in comments. The idea is to
deprecate that flexibility and add it to the code. To warn users
beforehand, we log error message regarding incomplete extensions.

See #3333
This commit is contained in:
Alexis Degrugillier authored and GitHub committed 2021-01-04 23:59:36 +01:00
1 parent 739080ff10
commit 9aa3c03844
1 file changed
+8
Download Patch File Download Diff File Expand all files Collapse all files
lib/Minz/ExtensionManager.php
+8
View File
@@ -172,6 +172,14 @@ class Minz_ExtensionManager {
'` is not an instance of `Minz_Extension`');
return null;
}
$reflector = new ReflectionClass($extension);
$className = $reflector->getName();
if ('Minz_Extension' === $reflector->getMethod('handleConfigureAction')->class ||
'Minz_Extension' === $reflector->getMethod('install')->class ||
'Minz_Extension' === $reflector->getMethod('init')->class ||
'Minz_Extension' === $reflector->getMethod('uninstall')->class) {
Minz_Log::error("The '{$className}' extension class definition is deprecated. It will continue to work with the current version but will break in the future. The '{$className}' extension class needs to override the 'handleConfigurationAction' method, the 'install' method, the 'init' method, and the 'uninstall' method to work properly.");
}
return $extension;
}