mirror/FreshRSS
0
0
Fork 0
mirror of https://github.com/FreshRSS/FreshRSS.git synced 2026-04-26 01:07:40 -04:00
Code Issues Packages Projects Releases Wiki Activity

Faster $simplePie->get_items() (#4263)

Browse Source 
Implement one of the TODOs from https://github.com/FreshRSS/FreshRSS/pull/4220 :
use `$simplePie->get_items()` instead of very slow `$simplePie->get_item($i)`
This commit is contained in:
Alexandre Alapetite
2022-03-06 23:36:35 +01:00
committed by GitHub
parent a9e23bd120
commit cc6deadf69
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
app/Models/Feed.php
View File

@@ -395,9 +395,12 @@ class FreshRSS_Feed extends Minz_Model {
$guids = [];
$hasBadGuids = $this->attributes('hasBadGuids');
// TODO: Replace very slow $simplePie->get_item($i) by getting all items at once
for ($i = $simplePie->get_item_quantity() - 1; $i >= 0; $i--) {
$item = $simplePie->get_item($i);
$items = $simplePie->get_items();
if (empty($items)) {
return $guids;
}
for ($i = count($items) - 1; $i >= 0; $i--) {
$item = $items[$i];
if ($item == null) {
continue;
}
@@ -423,10 +426,13 @@ class FreshRSS_Feed extends Minz_Model {
public function loadEntries(SimplePie $simplePie) {
$hasBadGuids = $this->attributes('hasBadGuids');
$items = $simplePie->get_items();
if (empty($items)) {
return;
}
// We want chronological order and SimplePie uses reverse order.
// TODO: Replace very slow $simplePie->get_item($i) by getting all items at once
for ($i = $simplePie->get_item_quantity() - 1; $i >= 0; $i--) {
$item = $simplePie->get_item($i);
for ($i = count($items) - 1; $i >= 0; $i--) {
$item = $items[$i];
if ($item == null) {
continue;
}