Commit Graph

5492 Commits

Author SHA1 Message Date
Alexandre Alapetite
07efaf71ea Fix error handling when updating URL (#5039)
Fix 3 related error handling when updating the feed URL with an invalid URL. Previously leading to unclear 500 page with additional PHP errors.
2023-01-26 08:59:34 +01:00
Alexandre Alapetite
2f02754522 Increase max feed URL length and drop unicity (#5038)
* Increase max feed URL length and drop unicity
#fix https://github.com/FreshRSS/FreshRSS/issues/4338
Drop the unicity constraint on our feed URL. In practice, this did not add much value as identical feeds could have different URLs. And it generated several problems, for instance during renaming or automatic redirections such as from HTTP to HTTPS, with collisions for which we dot not have any elegant handling.
I have kept a high limit of 32768 because cURL does not seem to have any limit except memory, which might lead to memory problems. This is the highest server-side value reported by https://www.sistrix.com/ask-sistrix/technical-seo/site-structure/url-length-how-long-can-a-url-be

* Same for Web site URL
For consistency
2023-01-26 08:13:38 +01:00
maTh
1c4b328ae1 Improved: expanding inputs (#5040)
* fix

* wider input element
2023-01-25 22:23:51 +01:00
maTh
1aab0459fa fix "Mark selection as unread" CSS (#5034) 2023-01-22 23:57:11 +01:00
Alexandre Alapetite
1c434971d4 statsController at phpStan level 9 (#5028)
Follow up of https://github.com/FreshRSS/FreshRSS/pull/5024

```
vendor/bin/phpstan analyse --level 9 app/Controllers/statsController.php
```

Contributes to https://github.com/FreshRSS/FreshRSS/issues/4112
2023-01-21 23:20:44 +01:00
Luc SANCHEZ
2216940f00 type hinting javascriptController (#5032) 2023-01-21 23:19:26 +01:00
maTh
4755a12c96 fix: Swage theme dropdown triangle (#5029) 2023-01-21 15:03:00 +01:00
maTh
f31c310a6d fix: Lemmy sharing service parameter (#5020) 2023-01-20 23:52:36 +01:00
Luc SANCHEZ
75a203fff2 Type hinting statsController.php (#5024) 2023-01-20 23:37:41 +01:00
Alexandre Alapetite
c13f1de139 Use paramBoolean consistently (#5025)
* Use paramBoolean consistently
So that we have cleaner values (true booleans) everywhere in user's config.php
2023-01-20 23:14:10 +01:00
Alexandre Alapetite
dbdb7869c4 Safer timezone set (#5021)
* Safer timezone set
Add missing tzdata in Docker :newest
Fallback to UTC if no timezone is defined at all
#fix https://github.com/FreshRSS/FreshRSS/pull/4906#issuecomment-1386747169

* Better refactoring
Show fallback timezone everywhere
2023-01-19 18:26:04 +01:00
Alexandre Alapetite
d105761fec i18n safer vsprintf (#5022)
Fix bug introduced by https://github.com/FreshRSS/FreshRSS/pull/4807
though only for the French i18n, wich has some `%` signs in the URL, making `vsprintf` to crash.

Only use `vsprintf`` when we call the translation with some parameters, otherwise skip it (probably faster as well).
2023-01-18 23:39:30 +01:00
berumuron
daaa391e33 tec: Update the lib_opml (#4403)
* fix: Fix undefined GLOB_BRACE on Alpine

The manual states that:

> Note: The GLOB_BRACE flag is not available on some non GNU systems,
> like Solaris or Alpine Linux.

This generated an error on Alpine.

Reference: https://www.php.net/manual/function.glob.php

* fix: List details of feeds for OPML exportation

The details are necessary to export the XPath information, the CSS full
content path and read actions filters.

* Update LibOpml to 0.4.0

* Refactor OPML importation to be more robust

First, it fixes two regressions introduced by the update of lib_opml:

- title attribute is used when text attribute is missing;
- the OPML category attribute is used as a fallback for feeds categories.

In a related way, if also fixes a problem when a feed had both a parent
category outline and a category attribute. Before, it only considered the
attribute as its category, but now it considers the parent outline.

Then, it counts category limit correctly by not increasing
`$nb_categories` if the category already exists.

* Exclude lib_opml from the CodeSniffer

* Fix variable names when logging some errors

* Fix catch of LibOpml Exception

* Make sure to declare the category

* Exclude lib_opml from PHPStan analyze

* Disable markdownlint for lib_opml

* Fix typos

* Use auto-loading and allow updates via Composer

* Fix broken links to lib_opml

* Bring back the ability to import the OPML frss:opmlUrl attribute

* Refactor the logs of OPML errors

* Update lib_opml to the version 0.5.0

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2023-01-18 10:12:21 +01:00
maTh
216e39c3cc Docs: Explain the "Do not automatically refresh more often than" (#5017)
* reordering, config, TOC

* fix markdownlint

* fix
2023-01-17 23:41:49 +01:00
maTh
33468def4a Improved: navigation menu structure (#4937) 2023-01-17 15:52:29 +01:00
maTh
0ab130eb9c Added: Mark theme as deprecated (#4807)
* i18n + config

* docs

* deprecated marked themes

* fix

* fix markdown

* i18n: fix link params

* i18n: French

* deprecated => no longer supported

* i18n: German

* Docs: deprecated => no longer supported

* Docs: French

* i18n: en-us

* i18n German

* isset() -> !empty()

* i18n: fix German

* i18n: English, delete // TODO
2023-01-17 15:39:55 +01:00
maTh
e67ca8c866 documentation improved: split en/users/03_Main_view.md into 3 parts (#5013)
* documentation

* update the links

* fix
2023-01-17 15:36:43 +01:00
Alexandre Alapetite
cfaaed7e0b Minor dev depenencies update (#5006)
Follow-up of https://github.com/FreshRSS/FreshRSS/pull/4993
New PHPStan version 1.9.9
2023-01-12 23:45:45 +01:00
Alexandre Alapetite
075cf4c800 API avoid logging passwords (#5001)
* API avoid logging passwords
* Strip passwords and tokens from API logs
* Only log failed requests information when in debug mode

* Remove debug SHA

* Clean also Apache logs

* Better comments

* Redact also token parameters

* shfmt

* Simplify whitespace

* redacted
2023-01-11 23:27:14 +01:00
maTh
c75baefe40 fix Automatic dark mode status (#5002) 2023-01-09 16:15:15 +01:00
Alexandre Alapetite
1d9d4e3e3c Update dev dependencies (#4993)
Related to https://github.com/FreshRSS/FreshRSS/pull/4991
Required a few changes in code to pass the tests
2023-01-09 12:59:30 +01:00
Alexandre Alapetite
3fb8ab8eb5 Handling of parentheses as special characters in searches (#4989)
#fix https://github.com/FreshRSS/FreshRSS/issues/4987
2023-01-09 12:59:09 +01:00
maTh
b5a418ec16 Added: Dark mode for Origine +Origine compact themes (#4843)
* first draft

* fix: theme slider: properties box

* improved colors

* option to enable/disable dark mode

* fixes

* Update app/i18n/fr/conf.php

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

* i18n english improved

* fix dark background color for favorites + hover colors

* select list: no, auto

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2023-01-09 10:40:38 +01:00
Sadetdin EYILI
bbe3eb8f41 Lazy load logo on install, logo on header and theme thumbs in config slide (#4998)
* feat: lazy load logo on install, logo on header and theme thumbs in config slide
2023-01-09 10:37:35 +01:00
maTh
7d12ecff01 fix: CSS "content:" (#4985)
* fix

* frss.css

* improve bubble for unread articles in global  view
2023-01-09 10:08:49 +01:00
maTh
5feefe416f fix: Ansum/Mapco theme: updating notification (#4995) 2023-01-09 08:41:01 +01:00
dependabot[bot]
e683d2f7ac build(deps): bump json5 from 1.0.1 to 1.0.2 (#4991)
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](https://github.com/json5/json5/compare/v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-01-08 11:09:25 +01:00
Alexandre Alapetite
8f9c4143fc Better enclosures (#4944)
* Better enclosures
#fix https://github.com/FreshRSS/FreshRSS/issues/4702
Improvement of https://github.com/FreshRSS/FreshRSS/pull/2898

* A few fixes

* Better enclosure titles

* Improve thumbnails

* Implement thumbnail for HTML+XPath

* Avoid duplicate enclosures
#fix https://github.com/FreshRSS/FreshRSS/issues/1668

* Fix regex

* Add basic support for media:credit
And use <figure> for enclosures

* Fix link encoding + simplify code

* Fix some SimplePie bugs
Encoding errors in enclosure links

* Remove debugging syslog

* Remove debugging syslog

* SimplePie fix multiple RSS2 enclosures
#fix https://github.com/FreshRSS/FreshRSS/issues/4974

* Improve thumbnails

* Performance with yield
Avoid generating all enclosures if not used

* API keep providing enclosures inside content
Clients are typically not showing the enclosures to the users (tested with News+, FeedMe, Readrops, Fluent Reader Lite)

* Lint

* Fix API output enclosure

* Fix API content strcut

* API tolerate enclosures without a type
2023-01-06 19:53:43 +01:00
maTh
af8480651d compile Mapco + Ansum again (#4983) 2023-01-03 23:04:45 +01:00
maTh
92d1b0cda7 Keep view for search landing page (#4981) 2023-01-02 21:54:00 +01:00
maTh
ba7cb98bdf open "manage feed" with Ctrl in a new tab (#4980) 2023-01-02 11:04:03 +01:00
maTh
c0a89a99b4 Fix: Nord Theme: "Mark all" menu item (#4979)
* fix font-size

* fix background color
2023-01-02 09:47:04 +01:00
Sadetdin EYILI
2850c0baea Update CREDITS.md (#4976)
Add Sadetdin EYILI
2022-12-31 19:34:00 +01:00
Sadetdin EYILI
914bc62aef fix: favicon after editing feed url (#4975)
refactor: replace `$cat` variable by the `$values['category']` values
2022-12-31 15:57:37 +01:00
Sadetdin EYILI
de5f70c684 docs: fix formating (#4968)
Replace apostrophe backtick
2022-12-29 18:48:17 +01:00
maTh
3c53125b01 fix: Ansum and Mapco: icons_as_emojis (better fix) (#4967)
* fix

* better fix

* fix
2022-12-29 16:05:09 +01:00
maTh
9cb0bbd0c1 fix: Ansum and Mapco: icons_as_emojis (#4966) 2022-12-29 00:02:52 +01:00
Alexandre Alapetite
7330cbab38 chmod +x extensions (#4956)
To ease adding custom extensions such as in https://github.com/FreshRSS/Extensions/issues/37#issuecomment-1363474585
2022-12-28 23:07:52 +01:00
maTh
b64650801f fix: notification box in mobile view (#4960) 2022-12-28 23:07:30 +01:00
maTh
6131aa4479 fix: Misalignment of "There are no articles to show" box (#4959) 2022-12-28 23:06:03 +01:00
maTh
e072411baf Improved: Header (#4927)
* all themes

* fix
2022-12-12 20:50:32 +01:00
maTh
695d6de362 fix: Swage theme (#4936) 2022-12-12 20:47:15 +01:00
maTh
f8ba54a3df Fixed: up.svg in Ansum/Mapco theme (#4938) 2022-12-12 20:46:15 +01:00
Alexandre Alapetite
f5bf654b1e Resume 1.21.0-dev 2022-12-09 23:10:15 +01:00
Alexandre Alapetite
45fb0d6803 Security release FreshRSS 1.20.2 2022-12-08 10:51:08 +01:00
Alexandre Alapetite
ed578f224c Security fix in ext.php (#4928)
Details later.
Due to https://github.com/FreshRSS/FreshRSS/pull/3433 (1.18.0)
2022-12-08 10:25:57 +01:00
maTh
a501cc88e7 fix: Text overflow in article summary (#4923) 2022-12-07 14:46:53 +01:00
maTh
60ffdb0580 Fix: Swage theme (#4922)
* fix link color

* fix nav menu alignment
2022-12-07 14:42:58 +01:00
Alexandre Alapetite
543fa4e76c Docker uniform timezone behaviour (#4905)
* Docker Alpine timezone for :newest and :oldest
Follow-up of https://github.com/FreshRSS/FreshRSS/pull/4903
Forgot the development images Newest and Oldest

* Uniform timezone behaviour

* shellcheck

* A bit more documentation
2022-11-30 20:45:40 +01:00
maTh
f41a574a9f article header: alignment of favicon/tags (#4910) 2022-11-30 20:45:11 +01:00