Commit Graph
2064 Commits
Author SHA1 Message Date
Alexandre Alapetite 800f28a5db Merge branch 'FreshRSS/dev' into dev 2015-03-24 21:11:21 +01:00
Alexandre Alapetite 5376c37907 Merge pull request #812 from aledeg/configuration-save
Add an unsaved changes alert on config pages
2015-03-24 21:08:06 +01:00
Alexandre Alapetite a5e960acbe Merge remote-tracking branch 'origin/Logging' into dev 2015-03-23 21:59:07 +01:00
Alexandre Alapetite 7735471140 SimplePie faster regex for sanitizing URLs
Can simplify the regex (faster because anchored) for cleaning URLs based
on the fact that we only have to deal with HTTP or HTTPS
https://github.com/FreshRSS/FreshRSS/pull/715
2015-03-23 21:58:37 +01:00
Alexandre Alapetite 3aa15d95a8 Merge remote-tracking branch 'origin/Logging' into dev 2015-03-22 23:57:27 +01:00
Alexandre Alapetite 0ed213d97f Revert "SimplePie seems to only supports HTTP schemes"
This reverts commit 1c38e646c3.
2015-03-22 23:56:47 +01:00
Alexandre Alapetite c83d30db64 Merge remote-tracking branch 'origin/Logging' into dev 2015-03-22 23:54:21 +01:00
Alexandre Alapetite 1c38e646c3 SimplePie seems to only supports HTTP schemes
Can simplify the regex (faster because anchored) for cleaning URLs based
on the fact that we only have to deal with HTTP or HTTPS
2015-03-22 23:53:59 +01:00
Alexandre Alapetite b628fb107d Merge remote-tracking branch 'origin/Logging' into dev 2015-03-22 22:54:56 +01:00
Alexandre Alapetite ad9fe52f5a SimplePie sanitize URLs for syslog
https://github.com/FreshRSS/FreshRSS/issues/711
https://github.com/FreshRSS/FreshRSS/pull/715
2015-03-22 22:54:29 +01:00
Alexandre Alapetite 92621345f9 Merge remote-tracking branch 'origin/Logging' into dev 2015-03-21 18:21:21 +01:00
Alexandre Alapetite 1a35e2271d SimplePie option to restaure syslog of HTTP requests
https://github.com/FreshRSS/FreshRSS/issues/711
2015-03-21 18:20:36 +01:00
Alexandre Alapetite 0e08b5ba56 htmlspecialchars_decode for all SIMPLEPIE_CONSTRUCT_MAYBE_HTML
https://github.com/FreshRSS/FreshRSS/issues/754
2015-03-21 15:13:08 +01:00
Alexandre Alapetite ec611d7d54 SimplePie: decode special chars for MAYBE_HTML
https://github.com/FreshRSS/FreshRSS/issues/754
Needs to check with many feeds to see if this does not introduce
incompatibilities with some valid feeds.
2015-03-16 21:37:28 +01:00
Alexis Degrugillier dd4fb519be Add an unsaved changes alert on config pages
Before, you could leave a configuration page without knowing if you saved your changes or not.
Now, there is an alert poping up if you have unsaved changes. It will ask you if you want to stay on the page and save your changes or leave the page and loose your changes.

See #739
2015-03-14 09:43:08 -04:00
Marien Fressinaud dfe781c30b Merge pull request #804 from aledeg/refactor-exceptions
Refactor exceptions
2015-03-07 09:26:35 +01:00
Alexis Degrugillier 24f6c1eabb Fix spacing 2015-03-05 13:29:41 +01:00
Alexis Degrugillier 96d5d9d034 Fix DAO exception
Change the name and messages
2015-03-05 13:29:41 +01:00
Alexis Degrugillier 5b90e1f4a0 Introduce user queries objects
There is now an object to manipulate user queries. It allows to move logic to handle those from the view and the controller in the model.
Thus making the view and the controller easier to read.
I introduced a new interface to start using dependency injection. There is still some rough edges but we are moving in the right direction.
The new object is fully tested but it still need some improvements, for instance, it is still tied to the search object.
There might be a better way to do that.
2015-03-05 13:29:41 +01:00
Alexis Degrugillier 32c439a5d6 Revert inheritance
As I do not have the time at the moment to verify the change of inheritance, I changed it back to the original.
2015-03-05 06:51:16 -05:00
Marien Fressinaud c80627fd4b Merge pull request #803 from aledeg/fix-api-take-2
Fix entry DAO query usage
2015-03-05 08:39:30 +01:00
Alexis Degrugillier aacd1ffd40 Refactor exceptions
I removed unnecessary constructors and unnecessary inheritance
2015-03-04 23:32:20 -05:00
Alexis Degrugillier d1c9378d33 Fix entry DAO query usage
I did not fix the call in the previous commit. I hope this one is the last change needed.

We definitely need a templating engine so we could use the same controller to output different things.
This will remove code duplication between the api and the web interface.
It will allows us to build other type of api, and also refactor the rss feed as a different view of the same dataset.
2015-03-04 23:04:12 -05:00
Marien Fressinaud 0da9ad988c Merge pull request #800 from aledeg/fix-entry-query
Add missing white space
2015-03-04 08:40:39 +01:00
Marien Fressinaud 689af24111 Merge pull request #801 from aledeg/fix-api
Fix API to use the search object
2015-03-04 08:40:00 +01:00
Alexis Degrugillier f3f8d73dda Fix API to use the search object
Since the internal of the listWhere method was changed, the API wasn't working. It was still calling the method with the old parameters.
I didn't test it but now, it should work.
2015-03-03 22:35:22 -05:00
Alexis Degrugillier fe24636e04 Add missing white space 2015-03-02 20:27:15 -05:00
Marien Fressinaud cdd653ce53 Merge branch 'aledeg-change-filter' into dev 2015-02-28 12:33:15 +01:00
Alexis Degrugillier e897afa7cc Change test to verify if there is a filter 2015-02-22 17:38:33 -05:00
Alexis Degrugillier 74c020edc8 Add a default string representation
In some part of the code, the search is displayed as is and crash since there is no way to display the search object as a string.
2015-02-21 09:47:40 -05:00
Alexis Degrugillier 50b6a02578 Add search default raw value
Before, the default value was undefined. Now it always has a value even when no value is provided.
2015-02-21 09:46:25 -05:00
Alexis Degrugillier 1156129593 Use the search object to get values in the search
It is now possible to combine multiple keywords to do a search. The separation of concern is better now since the search extraction is not done in the DAO anymore.
At the moment, a multiple keyword search is stored as this. It could be nice to have it rendered differently in the search page to make it more readable.
At the moment, there is a problem with search enclosed by ". Same search works well when enclosed by '.
2015-02-21 09:46:21 -05:00
Alexis Degrugillier f5028d30d0 Add required library
The lib_date.php library was missing in the Search object file. It is required to make date conversion in that object.
2015-02-21 09:45:19 -05:00
Alexis Degrugillier c59a702c32 Merge pull request #795 from FreshRSS/783-contributing-file
Contributing file
2015-02-18 10:12:47 -05:00
Marien Fressinaud e7a35161e2 Update CONTRIBUTING file
Remove unnecessary sentences in "Contribute to documentation"

See https://github.com/FreshRSS/FreshRSS/issues/783
2015-02-18 16:05:55 +01:00
Marien Fressinaud 8ab8121757 Merge pull request #793 from aledeg/modify-share
Harmonize share configuration view.
2015-02-18 11:05:51 +01:00
Alexis Degrugillier 58bf976f69 Change translation
I change the translation for the 3 languages. German has to be checked since I used Google translate to get the translation.
2015-02-17 21:05:28 -05:00
Marien Fressinaud a952accf8e Rebase 783-contributing-file on branch 'dev' 2015-02-17 14:55:25 +01:00
Marien Fressinaud 3aec3e7171 Improve CONTRIBUTING.md file
Add a section about mailing lists

See https://github.com/FreshRSS/FreshRSS/issues/783
2015-02-17 14:52:18 +01:00
Marien Fressinaud ee56f3607d Improve CONTRIBUTING file
- remove TODO
- simplify info about "fix a bug" (get from https://github.com/github/gitignore
  README)
- add few info

See https://github.com/FreshRSS/FreshRSS/issues/783
2015-02-17 14:45:26 +01:00
Marien Fressinaud edc6816aec Merge pull request #794 from aledeg/auto-remove-when-read
Add a cleaning process in the auto-remove feature.
2015-02-17 13:16:34 +01:00
Marien Fressinaud c0aba0a371 Merge pull request #792 from aledeg/extract-search-from-context
Extract search from context
2015-02-17 13:05:55 +01:00
Alexis Degrugillier 6e7bdb1709 Add a cleaning process in the auto-remove feature.
Before, when the status change was too quick, sometimes, articles weren't removed from the view.
Now they are removed by adding a statement that grabs past articles with specific properties and remove them.

See #738
2015-02-15 18:37:04 -05:00
Alexis Degrugillier b8fd3caf83 Harmonize share configuration view.
Before, for shares that don't need options, only a button to remove it was visible. It was source of confusion for users.
I changed the look of those shares by using the same layout as others (minus the help). As there is no configuration possible for the url, the field is disabled but it is possible to change the name of the share.

See #787
2015-02-14 11:00:26 -05:00
Alexis Degrugillier 964e67d4a4 Add a test to verify if the search input is stored correctly 2015-02-12 21:08:37 -05:00
Alexis Degrugillier 9f83aa5fe7 Refactor the code to make less unnecessaty calls
There were multiple calls made to the cleaning method that were unnecessary since it is useful only on the last call.
It allows to simplify code by returning values ealier.
2015-02-12 21:05:33 -05:00
Alexis Degrugillier 9cee5c1a17 Remove code generated by netbeans 2015-02-11 21:52:10 -05:00
Alexis Degrugillier f30ded2f86 Extract the search code from the context
I figured that the code for the search could be extracted from the context to have separation of concern.
It supports multiple keywords. It suports also multiple tag keywords.
2015-02-11 21:49:21 -05:00
Alexis Degrugillier 4bb8548ecc Add a way to parse search string to extract keywords
This feature is not in use at the moment, but it will be handy to reorganize the query building process. It allows to have more than one keyword in the search box.
Full tests are available as well.

It probably needs a refactoring later, but I think this is the first step to make the application full object oriented and testable.
2015-02-08 20:53:36 -05:00
Marien Fressinaud 694212cce8 Create CONTRIBUTING.md file
See https://github.com/FreshRSS/FreshRSS/issues/783
2015-02-03 15:57:33 +01:00