Commit Graph

320 Commits

Author SHA1 Message Date
Alexandre Alapetite
a5e960acbe Merge remote-tracking branch 'origin/Logging' into dev 2015-03-23 21:59:07 +01:00
Alexandre Alapetite
7735471140 SimplePie faster regex for sanitizing URLs
Can simplify the regex (faster because anchored) for cleaning URLs based
on the fact that we only have to deal with HTTP or HTTPS
https://github.com/FreshRSS/FreshRSS/pull/715
2015-03-23 21:58:37 +01:00
Alexandre Alapetite
3aa15d95a8 Merge remote-tracking branch 'origin/Logging' into dev 2015-03-22 23:57:27 +01:00
Alexandre Alapetite
0ed213d97f Revert "SimplePie seems to only supports HTTP schemes"
This reverts commit 1c38e646c3.
2015-03-22 23:56:47 +01:00
Alexandre Alapetite
c83d30db64 Merge remote-tracking branch 'origin/Logging' into dev 2015-03-22 23:54:21 +01:00
Alexandre Alapetite
1c38e646c3 SimplePie seems to only supports HTTP schemes
Can simplify the regex (faster because anchored) for cleaning URLs based
on the fact that we only have to deal with HTTP or HTTPS
2015-03-22 23:53:59 +01:00
Alexandre Alapetite
b628fb107d Merge remote-tracking branch 'origin/Logging' into dev 2015-03-22 22:54:56 +01:00
Alexandre Alapetite
ad9fe52f5a SimplePie sanitize URLs for syslog
https://github.com/FreshRSS/FreshRSS/issues/711
https://github.com/FreshRSS/FreshRSS/pull/715
2015-03-22 22:54:29 +01:00
Alexandre Alapetite
92621345f9 Merge remote-tracking branch 'origin/Logging' into dev 2015-03-21 18:21:21 +01:00
Alexandre Alapetite
1a35e2271d SimplePie option to restaure syslog of HTTP requests
https://github.com/FreshRSS/FreshRSS/issues/711
2015-03-21 18:20:36 +01:00
Alexandre Alapetite
0e08b5ba56 htmlspecialchars_decode for all SIMPLEPIE_CONSTRUCT_MAYBE_HTML
https://github.com/FreshRSS/FreshRSS/issues/754
2015-03-21 15:13:08 +01:00
Alexandre Alapetite
ec611d7d54 SimplePie: decode special chars for MAYBE_HTML
https://github.com/FreshRSS/FreshRSS/issues/754
Needs to check with many feeds to see if this does not introduce
incompatibilities with some valid feeds.
2015-03-16 21:37:28 +01:00
Marien Fressinaud
01a1179b1a Improve url_remove_credentials
Use @aledeg old function instead

See https://github.com/FreshRSS/FreshRSS/pull/715
See https://github.com/FreshRSS/FreshRSS/issues/711
2015-01-29 11:05:20 +01:00
Marien Fressinaud
8ff3e5363d Use url_remove_credentials to log URL
See https://github.com/FreshRSS/FreshRSS/issues/711
2015-01-29 10:57:11 +01:00
Marien Fressinaud
e078f9fdac Introduce url_remove_credentials() function
See https://github.com/FreshRSS/FreshRSS/issues/711
2015-01-29 10:47:33 +01:00
Marien Fressinaud
40f45c92ed Fix get_user_configuration()
There is no need to prefix namespace by the time: if conf has already been
registered, it will be returned anyway!
2015-01-29 10:26:16 +01:00
Marien Fressinaud
a47ce4f6af Fix including extensions for actualize_script
Extensions could be included multiple times. It resulted in an error.
2015-01-29 10:17:29 +01:00
Marien Fressinaud
59ea9f2a3b Remove calls to syslog()
Temporary fix:

- Change syslog by Minz_Log::notice in most of the files
- Logs are stored in USERS_PATH/_/log.txt for actualize_script.php
- Simply comment syslog in SimplePie

See https://github.com/FreshRSS/FreshRSS/issues/711
2015-01-29 10:14:45 +01:00
Marien Fressinaud
22d7e0d638 Simplify code for cookie dir
See https://github.com/FreshRSS/FreshRSS/issues/700
See eec95ffb6a
2015-01-21 16:28:29 +01:00
Marien Fressinaud
eec95ffb6a Fix bug related to cookie path
Fix https://github.com/FreshRSS/FreshRSS/issues/700
2015-01-21 15:43:25 +01:00
Marien Fressinaud
c741fba06c Update lib_opml.php
- lib_opml was not in its newest version
- FRSS supports OPML file without text attributes

Fix https://github.com/FreshRSS/FreshRSS/issues/758
2015-01-21 10:50:53 +01:00
Alexandre Alapetite
211569ef85 Minz: missing URL key/param encoding
Caused searches such as "intitle:&" to fail after paging, and
possible XSS vulnerabilities.
Discovered during https://github.com/FreshRSS/FreshRSS/issues/754
2015-01-21 00:44:26 +01:00
Alexandre Alapetite
12081f7ba2 Quick fix cron actualization due to problematic FreshRSS constructor/init
https://github.com/FreshRSS/FreshRSS/issues/759
Suggestion: the static objects should be user-independent (or at least
with the possibility to be re-set), while the FreshRSS object and its
attributes should be user-dependent.
2015-01-20 23:29:04 +01:00
Alexandre Alapetite
d30b3becfa Addressed warnings when reading from new files
There were warnings when reading extensions (trying to use e.g. README
and .gitignore as directories), and when reading update file.
https://github.com/FreshRSS/FreshRSS/issues/733
2015-01-19 13:54:57 +01:00
Marien Fressinaud
d91a92434f Fix Minz_Error and error_Controller
- Error code and logs was not propagated from Minz_Error to the controller
- header was bad (200 instead of 404 or 403)

Related to https://github.com/FreshRSS/FreshRSS/issues/751
2015-01-18 11:47:16 +01:00
Marien Fressinaud
2039710d12 Avoid "PHP Strict Standards" error
A "Only variables should be passed by reference" error was raised in the
extension->getFileUrl() method.
2015-01-15 13:43:05 +01:00
Marien Fressinaud
13cf8b5f9f Improve hook calls and add post_update hook
- To the hook is associated a method signature (OneToOne or NoneToNone for now) so
  it is easier to call hooks correctly
- post_update hook is called during the post update moment.
2015-01-15 12:02:42 +01:00
Marien Fressinaud
789d9fc6c8 Fix coding style in extension manager
Yep, same as 8968288...
2015-01-14 23:40:18 +01:00
Marien Fressinaud
8968288600 Fix extension API (coding style)
is_enabled() becomes isEnabled(). Sorry for this coding style mistake :s
2015-01-14 22:22:30 +01:00
Marien Fressinaud
ade1524d43 Fix valid extension entry points.
Add possibility to use underscores (_) in entrypoints.
2015-01-14 21:59:53 +01:00
Marien Fressinaud
806b4de54f Add mechanism at (un)install of an extension
Test if the install or uninstall has been successfully performed.
If these methods return true, all is ok but if a string is returned,
the string must explain the problem. This problem is stored in log file.

A feedback is given to explain to check log file.

This commit fix a problem in the english translation of
feedback.sub.feed.internal_problem.
2015-01-14 21:38:35 +01:00
Marien Fressinaud
b23fc3187c Fix translation bug
A path registered after initialization must be loaded.
2015-01-08 21:32:21 +01:00
Marien Fressinaud
19dfef8b49 Fix bug with Minz_Translate
When a path was registered before initialization, it was not considered unless
by calling reset() method.

This is fixed now.
2015-01-08 16:32:13 +01:00
Marien Fressinaud
85ea5e548a Fix install.php script (choice of lang)
Fix a bug in Minz_Translate too
2015-01-08 15:16:32 +01:00
Marien Fressinaud
8f04cb9d9d Change Minz_Translate::reset() behaviour
- Don't reset the path list (use init() instead)
- init() accept a null lang_name. To use i18n, you'll have to use reset() later.
  It is helpful to load the list of available language before choosing one of them.
2015-01-08 15:05:25 +01:00
Marien Fressinaud
a3f667e586 Fix Minz_Translate::availableLanguages() method 2015-01-08 14:50:21 +01:00
Marien Fressinaud
5bd7997d41 Call handleConfigureAction() even for GET requests
See https://github.com/FreshRSS/FreshRSS/issues/252
2015-01-08 14:30:05 +01:00
Marien Fressinaud
73023bc12b Merge branch 'dev' into 252-extensions
Conflicts:
	app/FreshRSS.php
	app/Models/Configuration.php
	app/views/index/index.phtml
	app/views/index/normal.phtml
	lib/Minz/Configuration.php
	lib/Minz/Translate.php
	lib/lib_rss.php
2015-01-08 14:18:32 +01:00
Marien Fressinaud
fb614ab80c Change way to call configuration setter.
- Add a support($key) method which return if the given key is supported by
  the setter.
- Change handle signature by adding a $data param which must be passed by
  reference.

See https://github.com/FreshRSS/FreshRSS/issues/730
2015-01-07 17:36:29 +01:00
Marien Fressinaud
7f12058fab Add a method to change the configuration setter
See https://github.com/FreshRSS/FreshRSS/issues/730
2015-01-07 16:09:24 +01:00
Marien Fressinaud
91e2d4936d Add support of configuration_setter
A configuration setter must implement only one method: `handle($key, $value)`.
Before setting a value in configuration, the setter will be called with this
method to check its validity.
If a setter has been assigned to a configuration object, it will be called for
each of its data so be careful to always return a value (or null if you want
to delete the key).

See https://github.com/FreshRSS/FreshRSS/issues/730
2015-01-07 15:57:27 +01:00
Marien Fressinaud
09545b0a65 Fix calls to remove_query_by_get()
The function has been moved into lib_rss.php

See https://github.com/FreshRSS/FreshRSS/issues/730
2015-01-07 15:37:24 +01:00
Marien Fressinaud
bd199c6170 If a conf param doesn't exist, log and return null
See https://github.com/FreshRSS/FreshRSS/issues/730
2015-01-07 10:48:47 +01:00
Marien Fressinaud
8e6ab12e89 Fix a bug in FreshRSS_Auth::giveAccess()
See https://github.com/FreshRSS/FreshRSS/issues/730
2015-01-06 22:43:24 +01:00
Marien Fressinaud
dd41642ce6 Fix calls to FreshRSS_Configuration
Replaced by a get_user_configuration() function in lib_rss.
This function register a new configuration based on the given username
and return the corresponding configuration.

See https://github.com/FreshRSS/FreshRSS/issues/730
2015-01-06 21:40:19 +01:00
Marien Fressinaud
17a280230f Change Minz_Configuration::parseFile() in load()
See https://github.com/FreshRSS/FreshRSS/issues/730
2015-01-06 21:16:33 +01:00
Marien Fressinaud
addcea9cd4 Fix i18n loading and availableLanguages calls
- Change the way to init i18n
- Add a availableLanguages() method to Minz_Translate

See https://github.com/FreshRSS/FreshRSS/issues/730
2015-01-06 21:10:51 +01:00
Marien Fressinaud
d3a93ea290 BREAKING FEATURE: Remove general in config
General attribute has been removed from system config.
Now subattributes (e.g. environment, salt, title, etc.) are directly accessible.

YOU HAVE TO FIX YOUR ./data/config.php file!

- Remove the general array
- Values inside this array must be kept
- To see what it must look like, please have a look to ./data/config.default.php
  (but keep your values!!).

See https://github.com/FreshRSS/FreshRSS/issues/730
2015-01-06 18:53:36 +01:00
Marien Fressinaud
d27efeec04 Fix Controllers to use the correct config system
See https://github.com/FreshRSS/FreshRSS/issues/730
2015-01-06 17:38:31 +01:00
Marien Fressinaud
51a71ec4b9 New configuration system (not working yet)
- Use only Minz_Configuration
- register() method to load a new configuration file
- get() to get a configuration
- new exceptions related to configuration
- fix a list configuration calls to have FRSS working

Current problems to resolve:

- How to handle configuration param verifications (i.e. check auth_type
  is a value from none, http_auth, persona or form)
- We must use $conf = Minz_Configuration::get('system'); $general_conf = $conf->general;
  to access global system configuration which is quite annoying. How to change that?

See https://github.com/FreshRSS/FreshRSS/issues/730
2015-01-05 16:54:16 +01:00