Bugfix #1403 : Trash bin actions result in app crashes

Properly disposed of LibationContext (#1403 )
Merge pull request #1401 from rmcrackan/dependabot/github_actions/actions/upload-artifact-5
2026-01-14 16:59:15 -05:00 · 2025-11-01 13:32:19 -04:00 · 2025-10-31 13:45:07 -06:00 · 2025-10-27 11:22:19 -04:00 · 2025-10-27 15:14:03 +00:00 · 2025-10-27 11:07:00 -04:00
6 changed files with 8 additions and 6 deletions
--- a/.github/workflows/build-linux.yml
+++ b/.github/workflows/build-linux.yml
@@ -124,7 +124,7 @@ jobs:
          echo "artifact=${artifact}" >> "${GITHUB_OUTPUT}"

      - name: Publish bundle
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v5
        with:
          name: ${{ steps.bundle.outputs.artifact }}
          path: ./Source/bin/Publish/bundle/${{ steps.bundle.outputs.artifact }}
--- a/.github/workflows/build-windows.yml
+++ b/.github/workflows/build-windows.yml
@@ -110,7 +110,7 @@ jobs:
          Compress-Archive -Path "${bin_dir}*" -DestinationPath "$artifact.zip"

      - name: Publish artifact
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v5
        with:
          name: ${{ steps.zip.outputs.artifact }}.zip
          path: ./Source/bin/Publish/${{ steps.zip.outputs.artifact }}.zip
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -40,7 +40,7 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Download artifacts
-        uses: actions/download-artifact@v5
+        uses: actions/download-artifact@v6
        with:
          path: artifacts
          pattern: "*(Classic-)Libation.*"
--- a/Source/AppScaffolding/AppScaffolding.csproj
+++ b/Source/AppScaffolding/AppScaffolding.csproj
@@ -2,7 +2,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>net9.0</TargetFramework>
-    <Version>12.5.6.1</Version>
+    <Version>12.5.7.1</Version>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Octokit" Version="14.0.0" />
--- a/Source/LibationAvalonia/Dialogs/TrashBinDialog.axaml.cs
+++ b/Source/LibationAvalonia/Dialogs/TrashBinDialog.axaml.cs
@@ -122,7 +122,8 @@ namespace LibationAvalonia.Dialogs

 		private void Reload()
 		{
-			var deletedBooks = DbContexts.GetContext().GetDeletedLibraryBooks();
+			using var context = DbContexts.GetContext();
+			var deletedBooks = context.GetDeletedLibraryBooks();

 			DeletedBooks.Clear();
 			DeletedBooks.AddRange(deletedBooks.Select(lb => new CheckBoxViewModel { Item = lb }));
--- a/Source/LibationWinForms/Dialogs/TrashBinDialog.cs
+++ b/Source/LibationWinForms/Dialogs/TrashBinDialog.cs
@@ -23,7 +23,8 @@ namespace LibationWinForms.Dialogs

 			deletedCheckedTemplate = deletedCheckedLbl.Text;

-			var deletedBooks = DbContexts.GetContext().GetDeletedLibraryBooks();
+			using var context = DbContexts.GetContext();
+			var deletedBooks = context.GetDeletedLibraryBooks();
 			foreach (var lb in deletedBooks)
 				deletedCbl.Items.Add(lb);
Author	SHA1	Message	Date
Robert	f4e7cf3418	Bugfix #1403 : Trash bin actions result in app crashes	2025-11-01 13:32:19 -04:00
MBucari	8492a7ea3a	Properly disposed of LibationContext (#1403 )	2025-10-31 13:45:07 -06:00
rmcrackan	5589a6cbd5	Merge pull request #1401 from rmcrackan/dependabot/github_actions/actions/upload-artifact-5 Bump actions/upload-artifact from 4 to 5	2025-10-27 11:22:19 -04:00
dependabot[bot]	bfbad988c0	Bump actions/upload-artifact from 4 to 5 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](https://github.com/actions/upload-artifact/compare/v4...v5) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>	2025-10-27 15:14:03 +00:00
rmcrackan	8db8615713	Merge pull request #1400 from rmcrackan/dependabot/github_actions/actions/download-artifact-6 Bump actions/download-artifact from 5 to 6	2025-10-27 11:07:00 -04:00
dependabot[bot]	e8fa3f14b3	Bump actions/download-artifact from 5 to 6 Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 5 to 6. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](https://github.com/actions/download-artifact/compare/v5...v6) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>	2025-10-27 14:59:43 +00:00