Bug fix: issues #113 , #114

Forcing a new build order. Seems to fix the issue. Since the issue was already intermittent (race condition?) it's difficult to be sure

AppScaffolding/AppScaffolding.csproj

@@ -3,7 +3,7 @@
 
   <PropertyGroup>
     <TargetFramework>net5.0</TargetFramework>
-    <Version>5.7.1.1</Version>
+    <Version>5.7.4.2</Version>
   </PropertyGroup>
 
   <ItemGroup>

DataLayer/EfClasses/Book.cs

@@ -100,7 +100,7 @@ namespace DataLayer
 
             // simple assigns
             Title = title.Trim();
-            Description = description.Trim();
+            Description = description?.Trim();
             LengthInMinutes = lengthInMinutes;
             ContentType = contentType;
 

Libation.sln

@@ -36,6 +36,9 @@ EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "LibationSearchEngine", "LibationSearchEngine\LibationSearchEngine.csproj", "{2E1F5DB4-40CC-4804-A893-5DCE0193E598}"
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "LibationWinForms", "LibationWinForms\LibationWinForms.csproj", "{635F00E1-AAD1-45F7-BEB7-D909AD33B9F6}"
+	ProjectSection(ProjectDependencies) = postProject
+		{428163C3-D558-4914-B570-A92069521877} = {428163C3-D558-4914-B570-A92069521877}
+	EndProjectSection
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "DtoImporterService", "DtoImporterService\DtoImporterService.csproj", "{401865F5-1942-4713-B230-04544C0A97B0}"
 EndProject

LibationCli/LibationCli.csproj

@@ -12,6 +12,14 @@
     <AppendRuntimeIdentifierToOutputPath>false</AppendRuntimeIdentifierToOutputPath>
   </PropertyGroup>
 
+  <!--
+  When LibationWinForms and LibationCli output to the same dir, LibationCli must build before LibationWinForms
+  
+  VS > rt-clik solution > Project Build Order...
+  Dependencies [tab]
+  Projects: LibationWinForms
+  manually check LibationCli
+  -->
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
     <OutputPath>..\LibationWinForms\bin\Debug</OutputPath>
   </PropertyGroup>

LibationWinForms/Dialogs/SettingsDialog.Designer.cs

@@ -33,25 +33,25 @@
 			this.saveBtn = new System.Windows.Forms.Button();
 			this.cancelBtn = new System.Windows.Forms.Button();
 			this.advancedSettingsGb = new System.Windows.Forms.GroupBox();
+			this.badBookGb = new System.Windows.Forms.GroupBox();
+			this.badBookIgnoreRb = new System.Windows.Forms.RadioButton();
+			this.badBookRetryRb = new System.Windows.Forms.RadioButton();
+			this.badBookAbortRb = new System.Windows.Forms.RadioButton();
+			this.badBookAskRb = new System.Windows.Forms.RadioButton();
+			this.decryptAndConvertGb = new System.Windows.Forms.GroupBox();
+			this.allowLibationFixupCbox = new System.Windows.Forms.CheckBox();
 			this.convertLossyRb = new System.Windows.Forms.RadioButton();
 			this.convertLosslessRb = new System.Windows.Forms.RadioButton();
 			this.inProgressSelectControl = new LibationWinForms.Dialogs.DirectorySelectControl();
-			this.allowLibationFixupCbox = new System.Windows.Forms.CheckBox();
 			this.logsBtn = new System.Windows.Forms.Button();
 			this.booksSelectControl = new LibationWinForms.Dialogs.DirectoryOrCustomSelectControl();
 			this.booksGb = new System.Windows.Forms.GroupBox();
 			this.loggingLevelLbl = new System.Windows.Forms.Label();
 			this.loggingLevelCb = new System.Windows.Forms.ComboBox();
-			this.decryptAndConvertGb = new System.Windows.Forms.GroupBox();
-			this.badBookGb = new System.Windows.Forms.GroupBox();
-			this.badBookAskRb = new System.Windows.Forms.RadioButton();
-			this.badBookAbortRb = new System.Windows.Forms.RadioButton();
-			this.badBookRetryRb = new System.Windows.Forms.RadioButton();
-			this.badBookIgnoreRb = new System.Windows.Forms.RadioButton();
 			this.advancedSettingsGb.SuspendLayout();
-			this.booksGb.SuspendLayout();
-			this.decryptAndConvertGb.SuspendLayout();
 			this.badBookGb.SuspendLayout();
+			this.decryptAndConvertGb.SuspendLayout();
+			this.booksGb.SuspendLayout();
 			this.SuspendLayout();
 			// 
 			// booksLocationDescLbl
@@ -117,6 +117,88 @@
 			this.advancedSettingsGb.TabStop = false;
 			this.advancedSettingsGb.Text = "Advanced settings for control freaks";
 			// 
+			// badBookGb
+			// 
+			this.badBookGb.Controls.Add(this.badBookIgnoreRb);
+			this.badBookGb.Controls.Add(this.badBookRetryRb);
+			this.badBookGb.Controls.Add(this.badBookAbortRb);
+			this.badBookGb.Controls.Add(this.badBookAskRb);
+			this.badBookGb.Location = new System.Drawing.Point(372, 22);
+			this.badBookGb.Name = "badBookGb";
+			this.badBookGb.Size = new System.Drawing.Size(529, 124);
+			this.badBookGb.TabIndex = 11;
+			this.badBookGb.TabStop = false;
+			this.badBookGb.Text = "[bad book desc]";
+			// 
+			// badBookIgnoreRb
+			// 
+			this.badBookIgnoreRb.AutoSize = true;
+			this.badBookIgnoreRb.Location = new System.Drawing.Point(6, 97);
+			this.badBookIgnoreRb.Name = "badBookIgnoreRb";
+			this.badBookIgnoreRb.Size = new System.Drawing.Size(94, 19);
+			this.badBookIgnoreRb.TabIndex = 15;
+			this.badBookIgnoreRb.TabStop = true;
+			this.badBookIgnoreRb.Text = "[ignore desc]";
+			this.badBookIgnoreRb.UseVisualStyleBackColor = true;
+			// 
+			// badBookRetryRb
+			// 
+			this.badBookRetryRb.AutoSize = true;
+			this.badBookRetryRb.Location = new System.Drawing.Point(6, 72);
+			this.badBookRetryRb.Name = "badBookRetryRb";
+			this.badBookRetryRb.Size = new System.Drawing.Size(84, 19);
+			this.badBookRetryRb.TabIndex = 14;
+			this.badBookRetryRb.TabStop = true;
+			this.badBookRetryRb.Text = "[retry desc]";
+			this.badBookRetryRb.UseVisualStyleBackColor = true;
+			// 
+			// badBookAbortRb
+			// 
+			this.badBookAbortRb.AutoSize = true;
+			this.badBookAbortRb.Location = new System.Drawing.Point(6, 47);
+			this.badBookAbortRb.Name = "badBookAbortRb";
+			this.badBookAbortRb.Size = new System.Drawing.Size(88, 19);
+			this.badBookAbortRb.TabIndex = 13;
+			this.badBookAbortRb.TabStop = true;
+			this.badBookAbortRb.Text = "[abort desc]";
+			this.badBookAbortRb.UseVisualStyleBackColor = true;
+			// 
+			// badBookAskRb
+			// 
+			this.badBookAskRb.AutoSize = true;
+			this.badBookAskRb.Location = new System.Drawing.Point(6, 22);
+			this.badBookAskRb.Name = "badBookAskRb";
+			this.badBookAskRb.Size = new System.Drawing.Size(77, 19);
+			this.badBookAskRb.TabIndex = 12;
+			this.badBookAskRb.TabStop = true;
+			this.badBookAskRb.Text = "[ask desc]";
+			this.badBookAskRb.UseVisualStyleBackColor = true;
+			// 
+			// decryptAndConvertGb
+			// 
+			this.decryptAndConvertGb.Controls.Add(this.allowLibationFixupCbox);
+			this.decryptAndConvertGb.Controls.Add(this.convertLossyRb);
+			this.decryptAndConvertGb.Controls.Add(this.convertLosslessRb);
+			this.decryptAndConvertGb.Location = new System.Drawing.Point(7, 22);
+			this.decryptAndConvertGb.Name = "decryptAndConvertGb";
+			this.decryptAndConvertGb.Size = new System.Drawing.Size(359, 124);
+			this.decryptAndConvertGb.TabIndex = 7;
+			this.decryptAndConvertGb.TabStop = false;
+			this.decryptAndConvertGb.Text = "Decrypt and convert";
+			// 
+			// allowLibationFixupCbox
+			// 
+			this.allowLibationFixupCbox.AutoSize = true;
+			this.allowLibationFixupCbox.Checked = true;
+			this.allowLibationFixupCbox.CheckState = System.Windows.Forms.CheckState.Checked;
+			this.allowLibationFixupCbox.Location = new System.Drawing.Point(6, 22);
+			this.allowLibationFixupCbox.Name = "allowLibationFixupCbox";
+			this.allowLibationFixupCbox.Size = new System.Drawing.Size(262, 19);
+			this.allowLibationFixupCbox.TabIndex = 8;
+			this.allowLibationFixupCbox.Text = "Allow Libation to fix up audiobook metadata";
+			this.allowLibationFixupCbox.UseVisualStyleBackColor = true;
+			this.allowLibationFixupCbox.CheckedChanged += new System.EventHandler(this.allowLibationFixupCbox_CheckedChanged);
+			// 
 			// convertLossyRb
 			// 
 			this.convertLossyRb.AutoSize = true;
@@ -148,19 +230,6 @@
 			this.inProgressSelectControl.Size = new System.Drawing.Size(552, 52);
 			this.inProgressSelectControl.TabIndex = 16;
 			// 
-			// allowLibationFixupCbox
-			// 
-			this.allowLibationFixupCbox.AutoSize = true;
-			this.allowLibationFixupCbox.Checked = true;
-			this.allowLibationFixupCbox.CheckState = System.Windows.Forms.CheckState.Checked;
-			this.allowLibationFixupCbox.Location = new System.Drawing.Point(6, 22);
-			this.allowLibationFixupCbox.Name = "allowLibationFixupCbox";
-			this.allowLibationFixupCbox.Size = new System.Drawing.Size(262, 19);
-			this.allowLibationFixupCbox.TabIndex = 8;
-			this.allowLibationFixupCbox.Text = "Allow Libation to fix up audiobook metadata";
-			this.allowLibationFixupCbox.UseVisualStyleBackColor = true;
-			this.allowLibationFixupCbox.CheckedChanged += new System.EventHandler(this.allowLibationFixupCbox_CheckedChanged);
-			// 
 			// logsBtn
 			// 
 			this.logsBtn.Location = new System.Drawing.Point(262, 147);
@@ -211,75 +280,6 @@
 			this.loggingLevelCb.Size = new System.Drawing.Size(129, 23);
 			this.loggingLevelCb.TabIndex = 4;
 			// 
-			// decryptAndConvertGb
-			// 
-			this.decryptAndConvertGb.Controls.Add(this.allowLibationFixupCbox);
-			this.decryptAndConvertGb.Controls.Add(this.convertLossyRb);
-			this.decryptAndConvertGb.Controls.Add(this.convertLosslessRb);
-			this.decryptAndConvertGb.Location = new System.Drawing.Point(7, 22);
-			this.decryptAndConvertGb.Name = "decryptAndConvertGb";
-			this.decryptAndConvertGb.Size = new System.Drawing.Size(359, 124);
-			this.decryptAndConvertGb.TabIndex = 7;
-			this.decryptAndConvertGb.TabStop = false;
-			this.decryptAndConvertGb.Text = "Decrypt and convert";
-			// 
-			// badBookGb
-			// 
-			this.badBookGb.Controls.Add(this.badBookIgnoreRb);
-			this.badBookGb.Controls.Add(this.badBookRetryRb);
-			this.badBookGb.Controls.Add(this.badBookAbortRb);
-			this.badBookGb.Controls.Add(this.badBookAskRb);
-			this.badBookGb.Location = new System.Drawing.Point(372, 22);
-			this.badBookGb.Name = "badBookGb";
-			this.badBookGb.Size = new System.Drawing.Size(529, 124);
-			this.badBookGb.TabIndex = 11;
-			this.badBookGb.TabStop = false;
-			this.badBookGb.Text = "badBookGb";
-			// 
-			// badBookAskRb
-			// 
-			this.badBookAskRb.AutoSize = true;
-			this.badBookAskRb.Location = new System.Drawing.Point(6, 22);
-			this.badBookAskRb.Name = "badBookAskRb";
-			this.badBookAskRb.Size = new System.Drawing.Size(94, 19);
-			this.badBookAskRb.TabIndex = 12;
-			this.badBookAskRb.TabStop = true;
-			this.badBookAskRb.Text = "radioButton1";
-			this.badBookAskRb.UseVisualStyleBackColor = true;
-			// 
-			// badBookAbortRb
-			// 
-			this.badBookAbortRb.AutoSize = true;
-			this.badBookAbortRb.Location = new System.Drawing.Point(6, 47);
-			this.badBookAbortRb.Name = "badBookAbortRb";
-			this.badBookAbortRb.Size = new System.Drawing.Size(94, 19);
-			this.badBookAbortRb.TabIndex = 13;
-			this.badBookAbortRb.TabStop = true;
-			this.badBookAbortRb.Text = "radioButton2";
-			this.badBookAbortRb.UseVisualStyleBackColor = true;
-			// 
-			// badBookRetryRb
-			// 
-			this.badBookRetryRb.AutoSize = true;
-			this.badBookRetryRb.Location = new System.Drawing.Point(6, 72);
-			this.badBookRetryRb.Name = "badBookRetryRb";
-			this.badBookRetryRb.Size = new System.Drawing.Size(94, 19);
-			this.badBookRetryRb.TabIndex = 14;
-			this.badBookRetryRb.TabStop = true;
-			this.badBookRetryRb.Text = "radioButton3";
-			this.badBookRetryRb.UseVisualStyleBackColor = true;
-			// 
-			// badBookIgnoreRb
-			// 
-			this.badBookIgnoreRb.AutoSize = true;
-			this.badBookIgnoreRb.Location = new System.Drawing.Point(6, 97);
-			this.badBookIgnoreRb.Name = "badBookIgnoreRb";
-			this.badBookIgnoreRb.Size = new System.Drawing.Size(94, 19);
-			this.badBookIgnoreRb.TabIndex = 15;
-			this.badBookIgnoreRb.TabStop = true;
-			this.badBookIgnoreRb.Text = "radioButton4";
-			this.badBookIgnoreRb.UseVisualStyleBackColor = true;
-			// 
 			// SettingsDialog
 			// 
 			this.AcceptButton = this.saveBtn;
@@ -302,12 +302,12 @@
 			this.Load += new System.EventHandler(this.SettingsDialog_Load);
 			this.advancedSettingsGb.ResumeLayout(false);
 			this.advancedSettingsGb.PerformLayout();
-			this.booksGb.ResumeLayout(false);
-			this.booksGb.PerformLayout();
-			this.decryptAndConvertGb.ResumeLayout(false);
-			this.decryptAndConvertGb.PerformLayout();
 			this.badBookGb.ResumeLayout(false);
 			this.badBookGb.PerformLayout();
+			this.decryptAndConvertGb.ResumeLayout(false);
+			this.decryptAndConvertGb.PerformLayout();
+			this.booksGb.ResumeLayout(false);
+			this.booksGb.PerformLayout();
 			this.ResumeLayout(false);
 			this.PerformLayout();
 

LibationWinForms/Dialogs/SettingsDialog.resx

@@ -1,5 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
-<root>
+<root>
   <xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
     <xsd:import namespace="http://www.w3.org/XML/1998/namespace" />
     <xsd:element name="root" msdata:IsDataSet="true">

LibationWinForms/LibationWinForms.csproj

@@ -18,6 +18,16 @@
     <!-- Version is now in AppScaffolding.csproj -->
   </PropertyGroup>
 
+  <PropertyGroup>
+    <!--
+    HACK FOR COMPILER BUG  2021-09-14. Hopefully will be fixed in future versions
+    - Not using SatelliteResourceLanguages will load all language packs: works
+    - Specifying 'en' semicolon 1 more should load 1 language pack: works
+    - Specifying only 'en' should load no language packs: broken, still loads all
+    -->
+    <SatelliteResourceLanguages>en;es</SatelliteResourceLanguages>
+  </PropertyGroup>
+
   <ItemGroup>
     <PackageReference Include="Dinah.Core.WindowsDesktop" Version="1.1.0.2" />
   </ItemGroup>