mirror/LocalAI
1
0
Fork 0
mirror of https://github.com/mudler/LocalAI.git synced 2026-07-31 02:18:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

test: check env restore errors in capability and variant specs

Browse Source 
errcheck flagged ten unchecked os.Setenv and os.Unsetenv returns in the
specs added while the pre-commit hook was being skipped. Restoring an env
var is exactly the place a silent failure leaks state into the next spec,
so assert on it rather than suppressing the linter.

Assisted-by: Claude:claude-opus-4-8
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
This commit is contained in:
Ettore Di Giacinto
2026-07-19 23:13:23 +00:00
parent 460ee79f3c
commit 3292f10da7
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/gallery/resolve_variant_test.go
View File

@@ -779,14 +779,14 @@ var _ = Describe("HostResolveEnv engine preference wiring", func() {
AfterEach(func() {
if origEnv != "" {
os.Setenv(capabilityEnv, origEnv)
Expect(os.Setenv(capabilityEnv, origEnv)).To(Succeed())
} else {
os.Unsetenv(capabilityEnv)
Expect(os.Unsetenv(capabilityEnv)).To(Succeed())
}
if origRunFileEnv != "" {
os.Setenv(capabilityRunFileEnv, origRunFileEnv)
Expect(os.Setenv(capabilityRunFileEnv, origRunFileEnv)).To(Succeed())
} else {
os.Unsetenv(capabilityRunFileEnv)
Expect(os.Unsetenv(capabilityRunFileEnv)).To(Succeed())
}
})

16
pkg/system/capabilities_test.go
View File

@@ -137,9 +137,9 @@ var _ = Describe("BackendPreferenceTokens", func() {
AfterEach(func() {
if origEnv != "" {
os.Setenv(capabilityEnv, origEnv)
Expect(os.Setenv(capabilityEnv, origEnv)).To(Succeed())
} else {
os.Unsetenv(capabilityEnv)
Expect(os.Unsetenv(capabilityEnv)).To(Succeed())
}
})
@@ -201,9 +201,9 @@ var _ = Describe("EnginePreferenceTokens", func() {
AfterEach(func() {
if origEnv != "" {
os.Setenv(capabilityEnv, origEnv)
Expect(os.Setenv(capabilityEnv, origEnv)).To(Succeed())
} else {
os.Unsetenv(capabilityEnv)
Expect(os.Unsetenv(capabilityEnv)).To(Succeed())
}
})
@@ -290,9 +290,9 @@ var _ = Describe("CapabilityFilterDisabled", func() {
AfterEach(func() {
if origEnv != "" {
os.Setenv(capabilityEnv, origEnv)
Expect(os.Setenv(capabilityEnv, origEnv)).To(Succeed())
} else {
os.Unsetenv(capabilityEnv)
Expect(os.Unsetenv(capabilityEnv)).To(Succeed())
}
})
@@ -367,9 +367,9 @@ var _ = Describe("ServingFeaturePreferenceTokens", func() {
previous := os.Getenv(capabilityEnv)
defer func() {
if previous != "" {
os.Setenv(capabilityEnv, previous)
Expect(os.Setenv(capabilityEnv, previous)).To(Succeed())
} else {
os.Unsetenv(capabilityEnv)
Expect(os.Unsetenv(capabilityEnv)).To(Succeed())
}
}()