mirror/LocalAI
1
0
Fork 0
mirror of https://github.com/mudler/LocalAI.git synced 2026-02-23 02:06:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: make sure to close on errors (#7521)

Browse Source 
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
This commit is contained in:
Ettore Di Giacinto
2025-12-11 14:03:20 +01:00
committed by GitHub
parent 72621a1d1c
commit 5dde7e9ac6
2 changed files with 20 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/model/filters.go
View File

@@ -15,3 +15,9 @@ func allExcept(s string) GRPCProcessFilter {
return id != s
}
}
func only(s string) GRPCProcessFilter {
return func(id string, p *process.Process) bool {
return id == s
}
}

19
pkg/model/initializers.go
View File

@@ -173,6 +173,10 @@ func (ml *ModelLoader) backendLoader(opts ...Option) (client grpc.Backend, err e
model, err := ml.LoadModel(o.modelID, o.model, ml.grpcModel(backend, o))
if err != nil {
err := ml.StopGRPC(only(o.modelID))
if err != nil {
log.Error().Err(err).Str("model", o.modelID).Msg("error stopping model")
}
log.Error().Str("modelID", o.modelID).Err(err).Msgf("Failed to load model %s with backend %s", o.modelID, o.backendString)
return nil, err
}
@@ -180,8 +184,8 @@ func (ml *ModelLoader) backendLoader(opts ...Option) (client grpc.Backend, err e
return model.GRPC(o.parallelRequests, ml.wd), nil
}
func (ml *ModelLoader) stopActiveBackends(modelID string, singleActiveBackend bool) {
if !singleActiveBackend {
func (ml *ModelLoader) stopActiveBackends(modelID string) {
if !ml.singletonMode {
return
}
@@ -218,15 +222,19 @@ func (ml *ModelLoader) Load(opts ...Option) (grpc.Backend, error) {
// (avoid looping through all the backends)
if m := ml.CheckIsLoaded(o.modelID); m != nil {
log.Debug().Msgf("Model '%s' already loaded", o.modelID)
return m.GRPC(o.parallelRequests, ml.wd), nil
}
ml.stopActiveBackends(o.modelID, ml.singletonMode)
ml.stopActiveBackends(o.modelID)
// if a backend is defined, return the loader directly
if o.backendString != "" {
return ml.backendLoader(opts...)
client, err := ml.backendLoader(opts...)
if err != nil {
ml.Close()
return nil, err
}
return client, nil
}
// Otherwise scan for backends in the asset directory
@@ -242,6 +250,7 @@ func (ml *ModelLoader) Load(opts ...Option) (grpc.Backend, error) {
if len(autoLoadBackends) == 0 {
log.Error().Msg("No backends found")
ml.Close()
return nil, fmt.Errorf("no backends found")
}