mirror of
https://github.com/mudler/LocalAI.git
synced 2026-07-09 07:48:22 -04:00
The `--generated-content-path` and `--upload-path` defaults were the fixed
shared locations `/tmp/generated/content` and `/tmp/localai/upload`. On any
multi-user host these collide across accounts: macOS routes `/tmp` to the
shared `/private/tmp` for every user, so whichever account starts LocalAI
first creates the parent with 0750 perms and every other account then fails
startup with:
unable to create ImageDir: "mkdir /tmp/generated/content: permission denied"
unable to create UploadDir: "mkdir /tmp/localai/upload: permission denied"
The same happens on Linux once a stale root-owned `/tmp/generated` (e.g. from
a prior `sudo` run) is left behind. This bites the desktop launcher and any
app embedding the raw binary (Wingman, nib-desktop), which start `local-ai
run` with no path flags.
Default both paths under the OS temp dir (`os.TempDir()`, honoring `$TMPDIR`;
already per-user on macOS) namespaced by the current UID
(`TMPDIR/localai-<uid>/...`), so accounts never collide while the paths stay
ephemeral. Wired via new kong vars in main.go so every consumer of the raw
binary inherits the fix. All content subdirs (audio, images) derive from
`GeneratedContentDir`, so they are fixed transitively.
As defense in depth, the launcher also anchors these two paths under its own
per-user data directory (mirroring the #10610 fix for data/config), extracted
into a testable `BuildRunArgs`.
Assisted-by: Claude:claude-opus-4-8 [Claude Code]
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Co-authored-by: Ettore Di Giacinto <mudler@localai.io>
249 lines
7.6 KiB
Go
249 lines
7.6 KiB
Go
package launcher_test
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
|
|
"fyne.io/fyne/v2/app"
|
|
|
|
launcher "github.com/mudler/LocalAI/cmd/launcher/internal"
|
|
)
|
|
|
|
var _ = Describe("Launcher", func() {
|
|
var (
|
|
launcherInstance *launcher.Launcher
|
|
tempDir string
|
|
)
|
|
|
|
BeforeEach(func() {
|
|
var err error
|
|
tempDir, err = os.MkdirTemp("", "launcher-test-*")
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
ui := launcher.NewLauncherUI()
|
|
app := app.NewWithID("com.localai.launcher")
|
|
|
|
launcherInstance = launcher.NewLauncher(ui, nil, app)
|
|
})
|
|
|
|
AfterEach(func() {
|
|
os.RemoveAll(tempDir)
|
|
})
|
|
|
|
Describe("NewLauncher", func() {
|
|
It("should create a launcher with default configuration", func() {
|
|
Expect(launcherInstance.GetConfig()).ToNot(BeNil())
|
|
})
|
|
})
|
|
|
|
Describe("Initialize", func() {
|
|
It("should set default paths when not configured", func() {
|
|
err := launcherInstance.Initialize()
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
config := launcherInstance.GetConfig()
|
|
Expect(config.ModelsPath).ToNot(BeEmpty())
|
|
Expect(config.BackendsPath).ToNot(BeEmpty())
|
|
})
|
|
|
|
It("should set default ShowWelcome to true", func() {
|
|
err := launcherInstance.Initialize()
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
config := launcherInstance.GetConfig()
|
|
Expect(config.ShowWelcome).To(BeTrue())
|
|
Expect(config.Address).To(Equal("127.0.0.1:8080"))
|
|
Expect(config.LogLevel).To(Equal("info"))
|
|
})
|
|
|
|
It("should create models and backends directories", func() {
|
|
// Set custom paths for testing
|
|
config := launcherInstance.GetConfig()
|
|
config.ModelsPath = filepath.Join(tempDir, "models")
|
|
config.BackendsPath = filepath.Join(tempDir, "backends")
|
|
launcherInstance.SetConfig(config)
|
|
|
|
err := launcherInstance.Initialize()
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
// Check if directories were created
|
|
_, err = os.Stat(config.ModelsPath)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
_, err = os.Stat(config.BackendsPath)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
})
|
|
})
|
|
|
|
Describe("Configuration", func() {
|
|
It("should get and set configuration", func() {
|
|
config := launcherInstance.GetConfig()
|
|
config.ModelsPath = "/test/models"
|
|
config.BackendsPath = "/test/backends"
|
|
config.Address = ":9090"
|
|
config.LogLevel = "debug"
|
|
|
|
err := launcherInstance.SetConfig(config)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
retrievedConfig := launcherInstance.GetConfig()
|
|
Expect(retrievedConfig.ModelsPath).To(Equal("/test/models"))
|
|
Expect(retrievedConfig.BackendsPath).To(Equal("/test/backends"))
|
|
Expect(retrievedConfig.Address).To(Equal(":9090"))
|
|
Expect(retrievedConfig.LogLevel).To(Equal("debug"))
|
|
})
|
|
})
|
|
|
|
Describe("WebUI URL", func() {
|
|
It("should return correct WebUI URL for localhost", func() {
|
|
config := launcherInstance.GetConfig()
|
|
config.Address = ":8080"
|
|
launcherInstance.SetConfig(config)
|
|
|
|
url := launcherInstance.GetWebUIURL()
|
|
Expect(url).To(Equal("http://localhost:8080"))
|
|
})
|
|
|
|
It("should return correct WebUI URL for full address", func() {
|
|
config := launcherInstance.GetConfig()
|
|
config.Address = "127.0.0.1:8080"
|
|
launcherInstance.SetConfig(config)
|
|
|
|
url := launcherInstance.GetWebUIURL()
|
|
Expect(url).To(Equal("http://127.0.0.1:8080"))
|
|
})
|
|
|
|
It("should handle http prefix correctly", func() {
|
|
config := launcherInstance.GetConfig()
|
|
config.Address = "http://localhost:8080"
|
|
launcherInstance.SetConfig(config)
|
|
|
|
url := launcherInstance.GetWebUIURL()
|
|
Expect(url).To(Equal("http://localhost:8080"))
|
|
})
|
|
})
|
|
|
|
Describe("Process Management", func() {
|
|
It("should not be running initially", func() {
|
|
Expect(launcherInstance.IsRunning()).To(BeFalse())
|
|
})
|
|
|
|
It("should handle start when binary doesn't exist", func() {
|
|
err := launcherInstance.StartLocalAI()
|
|
Expect(err).To(HaveOccurred())
|
|
// Could be either "not found" or "permission denied" depending on test environment
|
|
errMsg := err.Error()
|
|
hasExpectedError := strings.Contains(errMsg, "LocalAI binary") ||
|
|
strings.Contains(errMsg, "permission denied")
|
|
Expect(hasExpectedError).To(BeTrue(), "Expected error about binary not found or permission denied, got: %s", errMsg)
|
|
})
|
|
|
|
It("should handle stop when not running", func() {
|
|
err := launcherInstance.StopLocalAI()
|
|
Expect(err).To(HaveOccurred())
|
|
Expect(err.Error()).To(ContainSubstring("LocalAI is not running"))
|
|
})
|
|
})
|
|
|
|
Describe("BuildRunArgs", func() {
|
|
// Regression for the macOS "mkdir /tmp/generated/content: permission denied"
|
|
// startup failure: the launcher must redirect generated-content and upload
|
|
// paths under its own data directory instead of letting the server fall back
|
|
// to the shared /tmp defaults, which collide across users on a shared /tmp.
|
|
It("should keep generated-content and upload paths under the data directory", func() {
|
|
config := launcherInstance.GetConfig()
|
|
config.ModelsPath = filepath.Join(tempDir, "models")
|
|
launcherInstance.SetConfig(config)
|
|
|
|
dataPath := launcherInstance.GetDataPath()
|
|
args := launcherInstance.BuildRunArgs()
|
|
|
|
assertFlagValue := func(flag, expected string) {
|
|
idx := -1
|
|
for i, a := range args {
|
|
if a == flag {
|
|
idx = i
|
|
break
|
|
}
|
|
}
|
|
Expect(idx).To(BeNumerically(">=", 0), "expected %s to be present in run args", flag)
|
|
Expect(idx+1).To(BeNumerically("<", len(args)), "expected a value after %s", flag)
|
|
Expect(args[idx+1]).To(Equal(expected))
|
|
}
|
|
|
|
assertFlagValue("--generated-content-path", filepath.Join(dataPath, "generated"))
|
|
assertFlagValue("--upload-path", filepath.Join(dataPath, "uploads"))
|
|
// The bug was the server resolving these to shared /tmp paths.
|
|
for _, a := range args {
|
|
Expect(a).ToNot(HavePrefix("/tmp/"), "run args must not reference shared /tmp paths, got %s", a)
|
|
}
|
|
})
|
|
})
|
|
|
|
Describe("Logs", func() {
|
|
It("should return empty logs initially", func() {
|
|
logs := launcherInstance.GetLogs()
|
|
Expect(logs).To(BeEmpty())
|
|
})
|
|
})
|
|
|
|
Describe("Version Management", func() {
|
|
It("should return empty version when no binary installed", func() {
|
|
version := launcherInstance.GetCurrentVersion()
|
|
Expect(version).To(BeEmpty()) // No binary installed in test environment
|
|
})
|
|
|
|
It("should handle update checks", func() {
|
|
// This test would require mocking HTTP responses
|
|
// For now, we'll just test that the method doesn't panic
|
|
_, _, err := launcherInstance.CheckForUpdates()
|
|
// We expect either success or a network error, not a panic
|
|
if err != nil {
|
|
// Network error is acceptable in tests
|
|
Expect(err.Error()).To(ContainSubstring("failed to fetch"))
|
|
}
|
|
})
|
|
})
|
|
})
|
|
|
|
var _ = Describe("Config", func() {
|
|
It("should have proper JSON tags", func() {
|
|
config := &launcher.Config{
|
|
ModelsPath: "/test/models",
|
|
BackendsPath: "/test/backends",
|
|
Address: ":8080",
|
|
AutoStart: true,
|
|
LogLevel: "info",
|
|
EnvironmentVars: map[string]string{"TEST": "value"},
|
|
}
|
|
|
|
Expect(config.ModelsPath).To(Equal("/test/models"))
|
|
Expect(config.BackendsPath).To(Equal("/test/backends"))
|
|
Expect(config.Address).To(Equal(":8080"))
|
|
Expect(config.AutoStart).To(BeTrue())
|
|
Expect(config.LogLevel).To(Equal("info"))
|
|
Expect(config.EnvironmentVars).To(HaveKeyWithValue("TEST", "value"))
|
|
})
|
|
|
|
It("should initialize environment variables map", func() {
|
|
config := &launcher.Config{}
|
|
Expect(config.EnvironmentVars).To(BeNil())
|
|
|
|
ui := launcher.NewLauncherUI()
|
|
app := app.NewWithID("com.localai.launcher")
|
|
|
|
launcher := launcher.NewLauncher(ui, nil, app)
|
|
|
|
err := launcher.Initialize()
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
retrievedConfig := launcher.GetConfig()
|
|
Expect(retrievedConfig.EnvironmentVars).ToNot(BeNil())
|
|
Expect(retrievedConfig.EnvironmentVars).To(BeEmpty())
|
|
})
|
|
})
|