mirror of
https://github.com/mudler/LocalAI.git
synced 2026-07-31 10:28:43 -04:00
2f6e0481f7
AudioTranscriptionLive holds the model's inference lane for the whole stream,
which is correct (the streaming session is stateful and a concurrent run would
interleave two callers' audio) and newly dangerous. Every other RPC holds the
lane across compute, or across a write to a slow reader, and both of those
terminate on their own. A live stream instead blocks in a client-driven read,
and a peer that goes silent WITHOUT closing the stream never terminates
anything: the lane stays taken and every other request against that model queues
behind a client that stopped speaking.
live_watchdog is a one-shot idle timer that ends the stream when no frame has
arrived inside a window. It is standard library only, so it is unit tested
without an engine. gRPC's synchronous Read has no timeout and cannot be given
one, so the only way to unblock it is ServerContext::TryCancel, which decides
the wire status itself: the client sees CANCELLED rather than the
DEADLINE_EXCEEDED the handler returns, the reason is logged, and the lane coming
back is the point. When it fires the read loop throws rather than reporting
end-of-input, so the driver does not go on to finalize a decode nobody is
waiting for.
It is armed only after the lane is taken and disarmed as soon as the read side
closes, and both ends matter. Arming earlier would cover acquire(), which
legitimately blocks while another live stream runs, so a queued caller would be
cancelled for waiting its turn. Disarming later would cover our own decode,
where a window overrun is not a peer going quiet and cancelling would throw away
the transcript the client is waiting for.
The window is the new live_idle_timeout_ms option, 30 s by default, 0 meaning no
limit. core/http/endpoints/openai/realtime.go drives a 300 ms ticker and feeds
every tick that produced new audio while a turn is open, so 30 s of silence is a
hundred ticks that delivered nothing. It is also longer than any pause a speaker
takes mid-utterance, which is the case that must never be cut off, and
backend.proto lets one stream span many utterances, so a client that pauses
longer between them raises the option rather than discovering it.
Two smaller corrections in the same handler:
- check_can_serve now runs BEFORE the sample rate check.
pkg/grpc/grpcerrors/errors.go degrades to the file path on UNIMPLEMENTED and
on nothing else, so a live-incapable model asked at a wrong rate was
answering INVALID_ARGUMENT and costing the caller its fallback.
- a negative sample rate is refused instead of silently becoming 16000. Zero
still means 16000, which is what the proto documents; -1 is malformed rather
than absent and gets the same refusal every other bad rate gets.
And one thing recorded rather than changed, at the handler: "live" here means
incremental INPUT, not low latency, and with the pinned families it does not yet
mean incremental OUTPUT either. nemotron_asr's process_audio_chunk only appends
to its buffer, so its whole decode and every delta happen inside finalize(),
after the client closes its send side. The policy-window buffering is inert for
that family and matters only for vibevoice_asr and higgs_audio_stt.
Verified on the wire with live_idle_timeout_ms:3000. A silent client acked at
371 ms and was cancelled at 3.371 s; a second live stream opened one second
later received its ack 2.37 s in, i.e. at the instant the first was cancelled,
and then transcribed successfully on the same cached session. Without the
watchdog it would still be waiting. Re-ran the live transcription (ready first,
59 incremental deltas, concat equal to the final text, word timestamps in
nanoseconds, eou and eob false), the citrinet refusal at both a right and a
wrong rate (UNIMPLEMENTED either way now), and Task 12's AudioTranscriptionStream
on nemotron_asr, which is unchanged.
Mutation testing the watchdog found a weakness in its own test: the destructor
test slept past the window inside the watched scope, so a destructor that
DETACHED the thread instead of joining it passed unnoticed. The test now uses a
window longer than the scope, which kills that mutant, and says why.
Assisted-by: Claude:claude-opus-5 [Claude Code]
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
72 lines
2.2 KiB
C++
72 lines
2.2 KiB
C++
#include "live_watchdog.h"
|
|
|
|
#include <utility>
|
|
|
|
namespace audiocpp_backend {
|
|
|
|
IdleWatchdog::IdleWatchdog(std::chrono::milliseconds window,
|
|
std::function<void()> on_idle)
|
|
: window_(window), on_idle_(std::move(on_idle)),
|
|
last_(std::chrono::steady_clock::now()) {
|
|
if (window_.count() <= 0) {
|
|
// Disabled: no thread at all, rather than a thread with an infinite
|
|
// deadline. A thread that exists is a thread that has to be joined on
|
|
// every exit path, and there is nothing for this one to do.
|
|
return;
|
|
}
|
|
thread_ = std::thread([this] { run(); });
|
|
}
|
|
|
|
IdleWatchdog::~IdleWatchdog() { disarm(); }
|
|
|
|
void IdleWatchdog::touch() {
|
|
std::lock_guard<std::mutex> lock(mu_);
|
|
last_ = std::chrono::steady_clock::now();
|
|
// Deliberately does NOT notify. The waiter recomputes its deadline from
|
|
// last_ every time it wakes, so a touch that lands mid-window is picked up
|
|
// when the old deadline expires, and a touch is the hot path: it runs once
|
|
// per frame on the wire.
|
|
}
|
|
|
|
void IdleWatchdog::disarm() {
|
|
{
|
|
std::lock_guard<std::mutex> lock(mu_);
|
|
stop_ = true;
|
|
}
|
|
cv_.notify_all();
|
|
if (thread_.joinable()) {
|
|
thread_.join();
|
|
}
|
|
}
|
|
|
|
bool IdleWatchdog::fired() const {
|
|
std::lock_guard<std::mutex> lock(mu_);
|
|
return fired_;
|
|
}
|
|
|
|
void IdleWatchdog::run() {
|
|
std::unique_lock<std::mutex> lock(mu_);
|
|
while (!stop_) {
|
|
const auto deadline = last_ + window_;
|
|
if (cv_.wait_until(lock, deadline, [this] { return stop_; })) {
|
|
return; // disarmed
|
|
}
|
|
// The deadline passed, but last_ may have moved while this thread was
|
|
// waiting, and a condition variable may also wake spuriously. Re-read
|
|
// it: without this check a touch that landed mid-window would still be
|
|
// followed by a cancellation, i.e. a live client cut off mid-sentence.
|
|
if (std::chrono::steady_clock::now() < last_ + window_) {
|
|
continue;
|
|
}
|
|
fired_ = true;
|
|
auto callback = on_idle_;
|
|
lock.unlock();
|
|
if (callback) {
|
|
callback();
|
|
}
|
|
return; // one shot
|
|
}
|
|
}
|
|
|
|
} // namespace audiocpp_backend
|