mirror/Meshtastic-Android
1
0 Fork 0
mirror of https://github.com/meshtastic/Meshtastic-Android.git synced 2026-10-03 00:54:34 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore(detekt): drop baseline entries that match nothing (#7455)

Browse Source
This commit is contained in:
James Rich authored and GitHub committed 2026-09-29 20:55:22 +00:00
1 parent 486654a547
commit 2bc627283b
10 files changed
-79
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

androidApp/detekt-baseline.xml
-8
View File
@@ -4,13 +4,8 @@
<CurrentIssues>
<ID>ComplexCondition:MapViewModel.kt:MapViewModel$name.isBlank() || (urlTemplate.isBlank() &amp;&amp; localUri == null) || (localUri == null &amp;&amp; !isValidTileUrlTemplate(urlTemplate))</ID>
<ID>ComplexCondition:MapViewModel.kt:MapViewModel$normalized.name.isBlank() || (normalized.urlTemplate.isBlank() &amp;&amp; normalized.localUri == null) || (normalized.localUri == null &amp;&amp; !isValidTileUrlTemplate(normalized.urlTemplate))</ID>
<ID>ComposableParamOrder:MapView.kt:@OptIn(ExperimentalMaterial3Api::class) @Composable private fun MapsDialog</ID>
<ID>CyclomaticComplexMethod:DiscoveryGoogleMap.kt:@OptIn(MapsComposeExperimentalApi::class) @Composable fun DiscoveryGoogleMap</ID>
<ID>CyclomaticComplexMethod:GeminiNanoDocAssistant.kt:GeminiNanoDocAssistant$override fun answerStream: kotlinx.coroutines.flow.Flow&lt;AIDocAssistantResult></ID>
<ID>CyclomaticComplexMethod:GeminiNanoDocAssistant.kt:GeminiNanoDocAssistant$private fun buildContext: ContextResult</ID>
<ID>LongMethod:DiscoveryGoogleMap.kt:@OptIn(MapsComposeExperimentalApi::class) @Composable fun DiscoveryGoogleMap</ID>
<ID>LongMethod:GeminiNanoDocAssistant.kt:GeminiNanoDocAssistant$override fun answerStream: kotlinx.coroutines.flow.Flow&lt;AIDocAssistantResult></ID>
<ID>LongMethod:GeminiNanoDocAssistant.kt:GeminiNanoDocAssistant$override suspend fun isSupported: Boolean</ID>
<ID>LongMethod:GeminiNanoDocAssistant.kt:GeminiNanoDocAssistant$private fun buildPrompt: String</ID>
<ID>LoopWithTooManyJumpStatements:GeminiNanoDocAssistant.kt:GeminiNanoDocAssistant$for</ID>
<ID>MatchingDeclarationName:MapView.kt:GoogleMapMode</ID>
@@ -21,7 +16,6 @@
<ID>ReturnCount:MlKitDocTranslator.kt:MlKitDocTranslator$override suspend fun translatePage: TranslationResult</ID>
<ID>ReturnCount:MlKitMessageTranslator.kt:MlKitMessageTranslator$override suspend fun downloadLanguageModels: DownloadResult</ID>
<ID>ReturnCount:MlKitMessageTranslator.kt:MlKitMessageTranslator$override suspend fun translate: TranslationResult</ID>
<ID>SwallowedException:MapViewModel.kt:MapViewModel$e: Exception</ID>
<ID>ThrowsCount:MeshtasticAppFunctions.kt:MeshtasticAppFunctions$suspend fun getChannelInfo: GetChannelInfoResponse</ID>
<ID>ThrowsCount:MeshtasticAppFunctions.kt:MeshtasticAppFunctions$suspend fun getDeviceStatus: GetDeviceStatusResponse</ID>
<ID>ThrowsCount:MeshtasticAppFunctions.kt:MeshtasticAppFunctions$suspend fun getMeshMetrics: GetMeshMetricsResponse</ID>
@@ -31,13 +25,11 @@
<ID>ThrowsCount:MeshtasticAppFunctions.kt:MeshtasticAppFunctions$suspend fun sendMessage: SendMessageResponse</ID>
<ID>TooGenericExceptionCaught:GeminiNanoDocAssistant.kt:GeminiNanoDocAssistant$e: Exception</ID>
<ID>TooGenericExceptionCaught:MapView.kt:e: Exception</ID>
<ID>TooGenericExceptionCaught:MapView.kt:ex: Exception</ID>
<ID>TooGenericExceptionCaught:MapViewModel.kt:MapViewModel$e: Exception</ID>
<ID>TooGenericExceptionCaught:MlKitDocTranslator.kt:MlKitDocTranslator$e: Exception</ID>
<ID>TooGenericExceptionCaught:MlKitMessageTranslator.kt:MlKitMessageTranslator$e: Exception</ID>
<ID>TooManyFunctions:GeminiNanoDocAssistant.kt:GeminiNanoDocAssistant : AIDocAssistant</ID>
<ID>TooManyFunctions:MapView.kt:org.meshtastic.app.map.MapView.kt</ID>
<ID>TooManyFunctions:MapViewModel.kt:MapViewModel : BaseMapViewModel</ID>
<ID>UnnecessaryLaunchedEffect:Main.kt:LaunchedEffect</ID>
<ID>UnnecessaryLaunchedEffect:MapView.kt:LaunchedEffect</ID>
<ID>UnnecessaryLaunchedEffect:TracerouteMap.kt:LaunchedEffect</ID>
build-logic/convention/detekt-baseline.xml
-37
View File
@@ -1,37 +0,0 @@
<?xml version="1.0" ?>
<SmellBaseline>
<ManuallySuppressedIssues/>
<CurrentIssues>
<ID>AbsentOrWrongFileLicense:DetektConventionPlugin.kt$.DetektConventionPlugin.kt</ID>
<ID>AbsentOrWrongFileLicense:SpotlessConventionPlugin.kt$.SpotlessConventionPlugin.kt</ID>
<ID>ChainWrapping:AndroidInstrumentedTests.kt$&amp;&amp;</ID>
<ID>EnumNaming:MeshtasticFlavor.kt$FlavorDimension$marketplace</ID>
<ID>EnumNaming:MeshtasticFlavor.kt$MeshtasticFlavor$fdroid : MeshtasticFlavor</ID>
<ID>EnumNaming:MeshtasticFlavor.kt$MeshtasticFlavor$google : MeshtasticFlavor</ID>
<ID>FinalNewline:ProjectExtensions.kt$com.geeksville.mesh.buildlogic.ProjectExtensions.kt</ID>
<ID>MagicNumber:AndroidApplicationConventionPlugin.kt$AndroidApplicationConventionPlugin$36</ID>
<ID>MagicNumber:AndroidLibraryConventionPlugin.kt$AndroidLibraryConventionPlugin$36</ID>
<ID>MagicNumber:KotlinAndroid.kt$21</ID>
<ID>MagicNumber:KotlinAndroid.kt$26</ID>
<ID>MagicNumber:KotlinAndroid.kt$36</ID>
<ID>MagicNumber:Spotless.kt$120</ID>
<ID>MaxLineLength:GitVersionValueSource.kt$GitVersionValueSource$throw RuntimeException("Failed to determine git commit count for versionCode. Ensure you have a full git history (not a shallow clone) and .git is present.\nOriginal error: ${e.message}", e)</ID>
<ID>NewLineAtEndOfFile:ProjectExtensions.kt$com.geeksville.mesh.buildlogic.ProjectExtensions.kt</ID>
<ID>NoBlankLineBeforeRbrace:AndroidApplicationComposeConventionPlugin.kt$AndroidApplicationComposeConventionPlugin$ </ID>
<ID>NoBlankLineBeforeRbrace:AndroidLibraryComposeConventionPlugin.kt$AndroidLibraryComposeConventionPlugin$ </ID>
<ID>NoConsecutiveBlankLines:MeshtasticFlavor.kt$ </ID>
<ID>NoUnusedImports:AndroidApplicationFlavorsConventionPlugin.kt$.AndroidApplicationFlavorsConventionPlugin.kt</ID>
<ID>NoUnusedImports:AndroidLibraryConventionPlugin.kt$.AndroidLibraryConventionPlugin.kt</ID>
<ID>SpacingAroundParens:MeshtasticFlavor.kt$MeshtasticFlavor.fdroid$)</ID>
<ID>TooGenericExceptionCaught:GitVersionValueSource.kt$GitVersionValueSource$e: Exception</ID>
<ID>TooGenericExceptionThrown:GitVersionValueSource.kt$GitVersionValueSource$throw RuntimeException("Failed to determine git commit count for versionCode. Ensure you have a full git history (not a shallow clone) and .git is present.\nOriginal error: ${e.message}", e)</ID>
<ID>UnusedImports:AndroidApplicationFlavorsConventionPlugin.kt$import com.geeksville.mesh.buildlogic.MeshtasticFlavor</ID>
<ID>UnusedImports:AndroidApplicationFlavorsConventionPlugin.kt$import com.geeksville.mesh.buildlogic.libs</ID>
<ID>UnusedImports:AndroidApplicationFlavorsConventionPlugin.kt$import org.gradle.kotlin.dsl.apply</ID>
<ID>UnusedImports:AndroidApplicationFlavorsConventionPlugin.kt$import org.gradle.kotlin.dsl.dependencies</ID>
<ID>UnusedImports:AndroidApplicationFlavorsConventionPlugin.kt$import org.gradle.kotlin.dsl.exclude</ID>
<ID>UnusedImports:AndroidLibraryConventionPlugin.kt$import com.geeksville.mesh.buildlogic.libs</ID>
<ID>UnusedImports:AndroidLibraryConventionPlugin.kt$import org.gradle.kotlin.dsl.dependencies</ID>
<ID>UnusedParameter:AndroidLintConventionPlugin.kt$project: Project</ID>
</CurrentIssues>
</SmellBaseline>
core/datastore/detekt-baseline.xml
-1
View File
@@ -2,6 +2,5 @@
<SmellBaseline>
<ManuallySuppressedIssues/>
<CurrentIssues>
<ID>CyclomaticComplexMethod:ModuleConfigDataSource.kt:ModuleConfigDataSource$suspend fun setLocalModuleConfig</ID>
</CurrentIssues>
</SmellBaseline>
core/takserver/detekt-baseline.xml
-4
View File
@@ -3,13 +3,9 @@
<ManuallySuppressedIssues/>
<CurrentIssues>
<ID>AbstractClassCanBeInterface:TAKModels.kt:TAKConnectionEvent$TAKConnectionEvent</ID>
<ID>LongMethod:ZipArchiver.kt:ZipArchiver$actual fun createZip: ByteArray</ID>
<ID>NoNameShadowing:TAKPacketV2Conversion.kt:TAKPacketV2Conversion$wb</ID>
<ID>NoNameShadowing:TakV2Compressor.kt:TakV2Compressor$wb</ID>
<ID>ReturnCount:TAKServerJvm.kt:TAKServerJvm$override suspend fun start: Result&lt;Unit></ID>
<ID>UnusedPrivateProperty:AtakFileWriter.kt:AtakFileWriter$private const val ZIP_MIME_TYPE = "application/zip"</ID>
<ID>UnusedPrivateProperty:AtakFileWriter.kt:AtakFileWriter$private val DOWNLOADS_RELATIVE_PATH = "${Environment.DIRECTORY_DOWNLOADS}/"</ID>
<ID>UnusedPrivateProperty:AtakFileWriter.kt:AtakFileWriter$private val UNSAFE_FILE_NAME_CHARS = Regex("[^a-zA-Z0-9._-]")</ID>
<ID>UnusedPrivateProperty:TAKClientConnection.kt:TAKClientConnection$private val scope: CoroutineScope</ID>
<ID>UseOrEmpty:CoTXml.kt:chat.senderCallsign?.xmlEscaped() ?: ""</ID>
<ID>UseOrEmpty:CoTXmlParser.kt:CoTXmlParser$detail.remarks?.value ?: ""</ID>
core/ui/detekt-baseline.xml
-3
View File
@@ -33,9 +33,6 @@
<ID>MagicNumber:EditIPv4Preference.kt:16</ID>
<ID>MagicNumber:EditIPv4Preference.kt:24</ID>
<ID>MagicNumber:EditIPv4Preference.kt:8</ID>
<ID>MagicNumber:EditListPreference.kt:12345</ID>
<ID>MagicNumber:EditListPreference.kt:67890</ID>
<ID>MagicNumber:LazyColumnDragAndDropDemo.kt:50</ID>
<ID>MatchingDeclarationName:LocalTracerouteMapOverlayInsetsProvider.kt:TracerouteMapOverlayInsets</ID>
<ID>MissingNonRestartableComposable:AlertDialogs.kt:@Composable fun MeshtasticResourceDialog</ID>
<ID>MissingNonRestartableComposable:AlertDialogs.kt:@Composable fun MeshtasticTextDialog</ID>
desktopApp/detekt-baseline.xml
-6
View File
@@ -2,14 +2,8 @@
<SmellBaseline>
<ManuallySuppressedIssues/>
<CurrentIssues>
<ID>ModifierMissing:DesktopMainScreen.kt:@Composable fun DesktopMainScreen</ID>
<ID>UnnecessaryLaunchedEffect:DesktopTracerouteMap.kt:LaunchedEffect</ID>
<ID>UnnecessaryLaunchedEffect:Main.kt:LaunchedEffect</ID>
<ID>UnusedPrivateProperty:MacOSNotificationSender.kt:MacOSNotificationSender$unused: Unit = Unit</ID>
<ID>ViewModelForwarding:DesktopMainScreen.kt:MeshtasticAppShell( multiBackstack = multiBackstack, uiViewModel = uiViewModel, hostModifier = Modifier.padding(bottom = 24.dp), ) { MeshtasticNavigationSuite( multiBackstack = multiBackstack, uiViewModel = uiViewModel, modifier = Modifier.fillMaxSize(), ) { val provider = entryProvider&lt;NavKey> { desktopNavGraph(backStack, uiViewModel, multiBackstack) } MeshtasticNavDisplay( multiBackstack = multiBackstack, entryProvider = provider, modifier = Modifier.fillMaxSize(), ) } }</ID>
<ID>ViewModelForwarding:DesktopMainScreen.kt:MeshtasticNavigationSuite( multiBackstack = multiBackstack, uiViewModel = uiViewModel, modifier = Modifier.fillMaxSize(), ) { val provider = entryProvider&lt;NavKey> { desktopNavGraph(backStack, uiViewModel, multiBackstack) } MeshtasticNavDisplay( multiBackstack = multiBackstack, entryProvider = provider, modifier = Modifier.fillMaxSize(), ) }</ID>
<ID>ViewModelForwarding:Main.kt:DesktopMainScreen(uiViewModel, multiBackstack)</ID>
<ID>ViewModelForwarding:Main.kt:MeshtasticDesktopApp(uiViewModel, isDarkTheme, contrastLevel)</ID>
<ID>ViewModelForwarding:Main.kt:MeshtasticWindow(uiViewModel, isDarkTheme, contrastLevel, appIcon, windowState) { isAppVisible = false }</ID>
</CurrentIssues>
</SmellBaseline>
feature/firmware/detekt-baseline.xml
-6
View File
@@ -9,12 +9,6 @@
<ID>AbstractClassCanBeInterface:UnifiedOtaProtocol.kt:OtaCommand$OtaCommand</ID>
<ID>AbstractClassCanBeInterface:UnifiedOtaProtocol.kt:OtaHandshakeStatus$OtaHandshakeStatus</ID>
<ID>AbstractClassCanBeInterface:UnifiedOtaProtocol.kt:OtaResponse$OtaResponse</ID>
<ID>Kdoc:LegacyDfuTransport.kt:LegacyDfuTransport$/** * Stream [firmware] to the Packet characteristic, awaiting a [LegacyDfuResponse.PacketReceipt] every * [PRN_INTERVAL_PACKETS] packets and verifying the bytes-received count. * * Watches the connection state in parallel with the write loop; if the link drops mid-stream we cancel the write * coroutine and surface a [DfuException.ConnectionFailed] immediately rather than waiting indefinitely for a write * that will never complete. */</ID>
<ID>ModifierMissing:FirmwareUpdateScreen.kt:@Composable internal fun CheckingState</ID>
<ID>ModifierMissing:FirmwareUpdateScreen.kt:@Composable internal fun DisclaimerDialog</ID>
<ID>ModifierMissing:FirmwareUpdateScreen.kt:@Composable internal fun ErrorState</ID>
<ID>ModifierMissing:FirmwareUpdateScreen.kt:@Composable internal fun SuccessState</ID>
<ID>ModifierMissing:FirmwareUpdateScreen.kt:@Composable internal fun VerifyingState</ID>
<ID>MultipleEmitters:FirmwareUpdateScreen.kt:@Composable @Suppress("LongMethod") private fun ReadyState</ID>
<ID>MultipleEmitters:FirmwareUpdateScreen.kt:@Composable internal fun CheckingState</ID>
<ID>MultipleEmitters:FirmwareUpdateScreen.kt:@Composable internal fun ErrorState</ID>
feature/intro/detekt-baseline.xml
-2
View File
@@ -2,8 +2,6 @@
<SmellBaseline>
<ManuallySuppressedIssues/>
<CurrentIssues>
<ID>ComposableParamOrder:PermissionScreenLayout.kt:@Composable internal fun PermissionScreenLayout</ID>
<ID>ParameterNaming:WelcomeScreen.kt:onGetStarted: () -> Unit</ID>
<ID>PreviewPublic:WelcomeScreen.kt:@Preview @Composable fun WelcomeScreenPreview</ID>
</CurrentIssues>
</SmellBaseline>
feature/node/detekt-baseline.xml
-8
View File
@@ -28,7 +28,6 @@
<ID>LambdaParameterEventTrailing:TracerouteChart.kt:onPointSelected: (Double) -> Unit</ID>
<ID>LongParameterList:CommonGetNodeDetailsUseCase.kt:CommonGetNodeDetailsUseCase</ID>
<ID>MagicNumber:CompassViewModel.kt:CompassViewModel$180.0</ID>
<ID>ModifierMissing:BaseMetricChart.kt:@Composable @Suppress("LongMethod") fun &lt;T> BaseMetricScreen</ID>
<ID>ModifierMissing:CommonCharts.kt:@Composable fun LegendIndicator</ID>
<ID>ModifierMissing:DeviceMetrics.kt:@Suppress("LongMethod") @Composable fun DeviceMetricsScreen</ID>
<ID>ModifierMissing:EnvironmentMetrics.kt:@Composable fun EnvironmentMetricsScreen</ID>
@@ -40,7 +39,6 @@
<ID>ModifierMissing:PositionLogComponents.kt:@Composable @Suppress("LongMethod") fun PositionCard</ID>
<ID>ModifierMissing:PositionLogScreens.kt:@Composable fun PositionLogScreen</ID>
<ID>ModifierMissing:PowerMetrics.kt:@Suppress("LongMethod") @Composable fun PowerMetricsScreen</ID>
<ID>ModifierMissing:SignalMetrics.kt:@Suppress("LongMethod") @Composable fun SignalMetricsScreen</ID>
<ID>ModifierNotUsedAtRoot:NeighborInfoLog.kt:modifier = modifier.fillMaxSize().padding(innerPadding)</ID>
<ID>ModifierNotUsedAtRoot:TracerouteMapScreen.kt:modifier = modifier.fillMaxSize().padding(paddingValues)</ID>
<ID>ModifierWithoutDefault:NodeDetailScreens.kt:modifier: Modifier</ID>
@@ -81,13 +79,7 @@
<ID>PreviewPublic:NodeDetailPreviews.kt:@PreviewLightDark @Composable fun NodeDetailContentLoadingPreview</ID>
<ID>PreviewPublic:NodeDetailPreviews.kt:@PreviewLightDark @Composable fun NodeDetailContentLocalPreview</ID>
<ID>PreviewPublic:NodeDetailPreviews.kt:@PreviewLightDark @Composable fun NodeDetailContentRemotePreview</ID>
<ID>PreviewPublic:NodeListItemPreviews.kt:@PreviewLightDark @Composable fun NodeItemCompactActivePreview</ID>
<ID>PreviewPublic:NodeListItemPreviews.kt:@PreviewLightDark @Composable fun NodeItemCompactAllFieldsPreview</ID>
<ID>PreviewPublic:NodeListItemPreviews.kt:@PreviewLightDark @Composable fun NodeItemCompactMinimalPreview</ID>
<ID>PreviewPublic:NodeListItemPreviews.kt:@PreviewLightDark @Composable fun NodeItemCompleteActivePreview</ID>
<ID>PreviewPublic:NodeListItemPreviews.kt:@PreviewLightDark @Composable fun NodeItemCompletePreview</ID>
<ID>TooGenericExceptionCaught:MetricsViewModel.kt:MetricsViewModel$e: Exception</ID>
<ID>TooGenericExceptionCaught:NodeManagementActions.kt:NodeManagementActions$ex: Exception</ID>
<ID>UnnecessaryLaunchedEffect:CompassBottomSheet.kt:LaunchedEffect</ID>
<ID>UnnecessaryLaunchedEffect:NodeDetailScreens.kt:LaunchedEffect</ID>
<ID>UnnecessaryLaunchedEffect:NodeListScreen.kt:LaunchedEffect</ID>
feature/settings/detekt-baseline.xml
-4
View File
@@ -17,14 +17,12 @@
<ID>LongMethod:LoRaConfigItemList.kt:@Composable fun LoRaConfigScreen</ID>
<ID>LongMethod:PowerConfigItemList.kt:@Composable fun PowerConfigScreen</ID>
<ID>LongMethod:RadioConfigViewModel.kt:RadioConfigViewModel$private fun processPacketResponse</ID>
<ID>LongMethod:SecurityConfigScreen.android.kt:@Composable actual fun SecurityKeyBackupActions</ID>
<ID>LongMethod:SerialConfigItemList.kt:@Composable fun SerialConfigScreen</ID>
<ID>LongMethod:StoreForwardConfigItemList.kt:@Composable fun StoreForwardConfigScreen</ID>
<ID>LongMethod:TelemetryConfigItemList.kt:@Composable fun TelemetryConfigScreen</ID>
<ID>LongMethod:UserConfigItemList.kt:@Composable fun UserConfigScreen</ID>
<ID>MagicNumber:Debug.kt:3</ID>
<ID>MagicNumber:DebugViewModel.kt:DebugViewModel$16</ID>
<ID>MagicNumber:DebugViewModel.kt:DebugViewModel$8</ID>
<ID>MagicNumber:EditChannelDialog.kt:16</ID>
<ID>MagicNumber:EditChannelDialog.kt:32</ID>
<ID>MagicNumber:EditDeviceProfileDialog.kt:ProfileField.CHANNEL_URL$3</ID>
@@ -56,7 +54,6 @@
<ID>ModifierMissing:NeighborInfoConfigItemList.kt:@Composable fun NeighborInfoConfigScreen</ID>
<ID>ModifierMissing:NetworkConfigItemList.kt:@Suppress("LongMethod", "CyclomaticComplexMethod") @Composable fun NetworkConfigScreen</ID>
<ID>ModifierMissing:PacketResponseStateDialog.kt:@Composable fun &lt;T> PacketResponseStateDialog</ID>
<ID>ModifierMissing:PaxcounterConfigItemList.kt:@Composable fun PaxcounterConfigScreen</ID>
<ID>ModifierMissing:PositionConfigScreen.android.kt:@Composable actual fun DeviceLocationButton</ID>
<ID>ModifierMissing:PositionConfigScreen.kt:@Composable @Suppress("LongMethod", "CyclomaticComplexMethod") fun PositionConfigScreenCommon</ID>
<ID>ModifierMissing:PowerConfigItemList.kt:@Composable fun PowerConfigScreen</ID>
@@ -75,7 +72,6 @@
<ID>MultipleEmitters:PacketResponseStateDialog.kt:@Composable private fun ErrorContent</ID>
<ID>MultipleEmitters:PacketResponseStateDialog.kt:@Composable private fun SuccessContent</ID>
<ID>MultipleEmitters:SecurityConfigScreen.android.kt:@Composable actual fun SecurityKeyBackupActions</ID>
<ID>MutableStateAutoboxing:DesktopSettingsScreen.kt:mutableStateOf(0)</ID>
<ID>NoNameShadowing:Debug.kt:{ filterMode = it }</ID>
<ID>NoNameShadowing:DebugViewModel.kt:LogSearchManager${ SearchMatch(logIndex, it.range.first, it.range.last, "decodedPayload") }</ID>
<ID>NoNameShadowing:MeshBeaconConfigPolicy.kt:wb</ID>