mirror/Meshtastic-Android
1
0
Fork 0
mirror of https://github.com/meshtastic/Meshtastic-Android.git synced 2026-04-04 22:23:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: node popup menu param from position to NodeInfo

Browse Source
This commit is contained in:
andrekir
2024-04-01 18:33:40 -03:00
parent c746ca0fa0
commit 2c916f88ca
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/src/main/java/com/geeksville/mesh/ui/UsersFragment.kt
View File

@@ -121,15 +121,15 @@ class UsersFragment : ScreenFragment("Users"), Logging {
var nodes = arrayOf<NodeInfo>()
private set
private fun popup(view: View, position: Int) {
private fun popup(view: View, node: NodeInfo) {
if (!model.isConnected()) return
val node = nodes[position]
val user = node.user ?: return
val showAdmin = position == 0 || model.hasAdminChannel
val isOurNode = node.num == model.myNodeNum
val showAdmin = isOurNode || model.hasAdminChannel
val isIgnored = ignoreIncomingList.contains(node.num)
val popup = PopupMenu(requireContext(), view)
popup.inflate(R.menu.menu_nodes)
popup.menu.setGroupVisible(R.id.group_remote, position > 0)
popup.menu.setGroupVisible(R.id.group_remote, !isOurNode)
popup.menu.setGroupVisible(R.id.group_admin, showAdmin)
popup.menu.setGroupEnabled(R.id.group_admin, !model.isManaged)
popup.menu.findItem(R.id.ignore).apply {
@@ -171,7 +171,7 @@ class UsersFragment : ScreenFragment("Users"), Logging {
}
}
item.isChecked = !item.isChecked
notifyItemChanged(position)
notifyItemChanged(nodes.indexOfFirst { it.num == node.num })
}
.show()
}
@@ -206,7 +206,7 @@ class UsersFragment : ScreenFragment("Users"), Logging {
distanceUnits = displayUnits,
tempInFahrenheit = displayFahrenheit
) {
popup(holder.composeView, position)
popup(holder.composeView, thatNode)
}
}