mirror/Meshtastic-Android
1
0
Fork 0
mirror of https://github.com/meshtastic/Meshtastic-Android.git synced 2026-04-02 05:04:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: add synchronized() to service numOnlineNodes

Browse Source 
to avoid `ConcurrentModificationException` from nodeDBbyNodeNum changes
This commit is contained in:
andrekir
2023-04-07 11:28:17 -03:00
parent 440fc97fa0
commit a560555a01
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/java/com/geeksville/mesh/service/MeshService.kt
View File

@@ -427,7 +427,8 @@ class MeshService : Service(), Logging {
/**
* How many nodes are currently online (including our local node)
*/
private val numOnlineNodes get() = nodeDBbyNodeNum.values.count { it.isOnline }
private val numOnlineNodes
get() = synchronized(nodeDBbyNodeNum) { nodeDBbyNodeNum.values.count { it.isOnline } }
private fun toNodeNum(id: String): Int = when (id) {
DataPacket.ID_BROADCAST -> DataPacket.NODENUM_BROADCAST