mirror/Meshtastic-Android
1
0
Fork 0
mirror of https://github.com/meshtastic/Meshtastic-Android.git synced 2026-05-14 01:36:09 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix #1654: Move the app rating dependency to googleImplementation (#1656)

Browse Source 
* Move the app rating dependency to googleImplementation

The `awesome.app.rating` dependency is now under `googleImplementation` instead of `implementation` in `app/build.gradle`.

* Refactor alert DND dialog padding

Use `dpToPx` for padding in the alert DND dialog for better consistency.
This commit is contained in:
James Rich
2025-03-07 14:25:46 -06:00
committed by GitHub
parent 3d86dc349e
commit d40672df40
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/build.gradle
View File

@@ -165,7 +165,7 @@ dependencies {
//Individual dependencies
implementation(libs.appintro)
implementation(libs.awesome.app.rating)
googleImplementation(libs.awesome.app.rating)
implementation(libs.core.splashscreen)
implementation(libs.emoji2.emojipicker)
implementation(libs.kotlinx.collections.immutable)

4
app/src/main/java/com/geeksville/mesh/MainActivity.kt
View File

@@ -59,6 +59,7 @@ import com.geeksville.mesh.android.BindFailedException
import com.geeksville.mesh.android.GeeksvilleApplication
import com.geeksville.mesh.android.Logging
import com.geeksville.mesh.android.ServiceClient
import com.geeksville.mesh.android.dpToPx
import com.geeksville.mesh.android.getBluetoothPermissions
import com.geeksville.mesh.android.getNotificationPermissions
import com.geeksville.mesh.android.hasBluetoothPermission
@@ -450,6 +451,7 @@ class MainActivity : AppCompatActivity(), Logging {
}
}
@Suppress("MagicNumber")
private fun checkAlertDnD() {
if (
Build.VERSION.SDK_INT >= Build.VERSION_CODES.O
@@ -470,7 +472,7 @@ class MainActivity : AppCompatActivity(), Logging {
val messageTextView = TextView(this).also {
it.text = message
it.movementMethod = LinkMovementMethod.getInstance()
it.setPadding(resources.getDimension(R.dimen.margin_normal).toInt())
it.setPadding(dpToPx(16f))
}
MaterialAlertDialogBuilder(this)
.setTitle(R.string.alerts_dnd_request_title)