mirror/Meshtastic-Android
1
0
Fork 0
mirror of https://github.com/meshtastic/Meshtastic-Android.git synced 2026-05-13 17:25:04 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: clarify position precision as ± radius (#5428)

Browse Source
This commit is contained in:
James Rich
2026-05-12 10:24:29 -05:00
committed by GitHub
parent ab4589c06a
commit dcb147163c
4 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/PositionPrecisionPreference.kt
View File

@@ -93,7 +93,7 @@ fun PositionPrecisionPreference(
val precisionMeters = precisionBitsToMeters(value).toInt()
Text(
text = precisionMeters.toDistanceString(unit),
text = "± ${precisionMeters.toDistanceString(unit)}",
modifier = Modifier.padding(bottom = 16.dp),
fontSize = MaterialTheme.typography.bodyLarge.fontSize,
overflow = TextOverflow.Ellipsis,

3
feature/node/src/commonMain/kotlin/org/meshtastic/feature/node/compass/CompassViewModel.kt
View File

@@ -123,7 +123,8 @@ class CompassViewModel(
val isAligned = isAligned(trueHeading, bearingDegrees)
val lastUpdateText = targetPositionTimeSec?.let { formatElapsed(it) }
val angularErrorDeg = calculateAngularError(positionalAccuracyMeters, distanceMeters)
val errorRadiusText = positionalAccuracyMeters?.toInt()?.toDistanceString(current.displayUnits)
val errorRadiusText =
positionalAccuracyMeters?.toInt()?.let { "± ${it.toDistanceString(current.displayUnits)}" }
return current.copy(
heading = trueHeading,

12
feature/node/src/commonTest/kotlin/org/meshtastic/feature/node/compass/CompassViewModelTest.kt
View File

@@ -154,7 +154,7 @@ class CompassViewModelTest {
),
)
assertEquals("12 m", state.errorRadiusText)
assertEquals("± 12 m", state.errorRadiusText)
}
@Test
@@ -172,7 +172,7 @@ class CompassViewModelTest {
),
)
assertEquals("25 m", state.errorRadiusText)
assertEquals("± 25 m", state.errorRadiusText)
}
@Test
@@ -189,7 +189,7 @@ class CompassViewModelTest {
),
)
assertEquals("8 m", state.errorRadiusText)
assertEquals("± 8 m", state.errorRadiusText)
}
@Test
@@ -205,7 +205,7 @@ class CompassViewModelTest {
),
)
assertEquals("729 m", state.errorRadiusText)
assertEquals("± 729 m", state.errorRadiusText)
}
@Test
@@ -240,7 +240,7 @@ class CompassViewModelTest {
location = PhoneLocation(1.0, 1.0, 0.0, 1000L),
)
assertEquals("12 m", state.errorRadiusText)
assertEquals("± 12 m", state.errorRadiusText)
assertNotNull(state.angularErrorDeg)
assertEquals(180f, state.angularErrorDeg)
}
@@ -260,7 +260,7 @@ class CompassViewModelTest {
location = PhoneLocation(1.0, 1.0, 0.0, 1000L),
)
assertEquals("12 m", state.errorRadiusText)
assertEquals("± 12 m", state.errorRadiusText)
assertNotNull(state.angularErrorDeg)
assertEquals(85.4f, state.angularErrorDeg, 0.5f)
}

2
feature/settings/src/commonMain/kotlin/org/meshtastic/feature/settings/radio/component/MapReportingPreference.kt
View File

@@ -120,7 +120,7 @@ fun MapReportingPreference(
val precisionMeters = precisionBitsToMeters(positionPrecision).toInt()
val unit = DistanceUnit.Companion.getFromLocale()
Text(
text = precisionMeters.toDistanceString(unit),
text = "± ${precisionMeters.toDistanceString(unit)}",
modifier = Modifier.padding(start = 16.dp, end = 16.dp, bottom = 16.dp),
fontSize = MaterialTheme.typography.bodyLarge.fontSize,
overflow = TextOverflow.Companion.Ellipsis,