Commit Graph

6 Commits

Author SHA1 Message Date
James Rich
94bcec85b3 refactor: Naming cleanup for clarity and Kotlin conventions
Audit-driven renames:
- DirectRadioControllerImpl -> RadioControllerImpl: the "Direct" prefix
  was vestigial (it once contrasted with the AIDL-routed
  AndroidRadioControllerImpl, now deleted); it is the sole impl and now
  matches its parts (AdminControllerImpl, etc.).
- RadioController.getPacketId() -> generatePacketId(): a `get`-prefixed
  function that generates a fresh id each call violates the
  getter-is-idempotent convention; also aligns with
  CommandSender.generatePacketId().
- RequestController -> QueryController (+ Impl, + the `requestController`
  params/mocks): clearer intent for the pull/query surface; "request" was
  generic.
- RequestTimer param `label` -> `logLabel`.
- AdminControllerImpl DEFAULT_REBOOT_DELAY -> DEFAULT_DELAY_SECONDS
  (shared by reboot + shutdown; conveys the unit).

Interface-consumer-safe; docs/READMEs/architecture guide updated to match.
Koin graph verifies on Android + desktop; affected test suites green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-05-29 14:37:54 -05:00
James Rich
1182ea0e14 docs: Document ServiceRepository ISP decomposition in architecture guide
Update core/repository README and architecture docs to reflect the new
focused provider interfaces (ConnectionStateProvider, TracerouteResponseProvider,
NeighborInfoResponseProvider, ServiceStateWriter) and ViewModel narrowing.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-05-29 13:35:36 -05:00
James Rich
975b6f4c8c docs: Document RadioController composition in architecture guide
Add a "Radio Control" section to the developer architecture guide
covering how features issue radio commands: the RadioController
composite, its four sub-interfaces (Admin/Messaging/Node/Request), and
DirectRadioControllerImpl as the in-process composition root that
assembles them via interface delegation. Notes the fire-and-forget admin
model and the deliberate alignment with the meshtastic-sdk API shape.

Additive only (no stale-reference fix); bumps last_updated.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-05-29 11:41:49 -05:00
James Rich
3c70523e69 docs: audit and fix stale references from recent changes (#5555)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-05-20 19:05:01 -05:00
James Rich
89fe2b58d7 docs(nav): fix sidebar nesting, dynamic language switcher, and delete translations page (#5535) 2026-05-20 10:42:34 -05:00
James Rich
11bc37c968 docs: move English sources into docs/en/ locale folder (#5501)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-05-19 14:06:44 -05:00