fix(ci): make sure to use distinct name pattern for v4 upload

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

.github/workflows/binary-releases.yml

@@ -107,11 +107,6 @@ jobs:
           - target: powerpc64le-unknown-linux-gnu
             os: ubuntu-22.04
             cross: true
-          # Windows
-          # - target: x86_64-pc-windows-msvc
-          #   os: windows-2022
-          # - target: i686-pc-windows-msvc
-          #   os: windows-2022
           # macOS
           - target: aarch64-apple-darwin
             os: macos-12
@@ -210,14 +205,14 @@ jobs:
         if: runner.os != 'Linux'
         uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # ratchet:actions/upload-artifact@v4
         with:
-          name: staged-${{ runner.os }}
+          name: staged-${{ runner.os }}-${{ matrix.job.target }}
           path: openllm-python/packaging/*
           if-no-files-found: error
       - name: Upload archive
         if: runner.os == 'Linux'
         uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # ratchet:actions/upload-artifact@v4
         with:
-          name: standalone
+          name: standalone-${{ runner.os }}-${{ matrix.job.target }}
           path: openllm-python/packaging/*
           if-no-files-found: error
   windows-packaging:

.github/workflows/create-releases.yml

@@ -102,6 +102,7 @@ jobs:
     needs:
       - release
       - publish-python
+      - binary-distribution
     runs-on: ubuntu-latest
     permissions:
       contents: write
@@ -154,11 +155,17 @@ jobs:
           popd &>/dev/null
           git add package.json openllm-node/package.json && git commit -S -sm "infra: bump to dev version of ${DEV_VERSION} [generated] [skip ci]"
           git push origin HEAD:main
+  binary-distribution:
+    if: github.repository_owner == 'bentoml'
+    needs: build-pypi
+    name: Create binary/wheels distribution
+    uses: bentoml/OpenLLM/.github/workflows/binary-releases.yml@main # ratchet:exclude
   release-notes:
     if: github.repository_owner == 'bentoml'
     needs:
       - release
       - publish-python
+      - binary-distribution
     name: Create release notes and setup for next cycle
     uses: bentoml/OpenLLM/.github/workflows/release-notes.yml@main # ratchet:exclude
     with:

.github/workflows/release-notes.yml

@@ -40,6 +40,18 @@ jobs:
           pattern: python-artefacts-*
           merge-multiple: true
           path: dist
+      - name: Download binaries
+        uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # ratchet:actions/download-artifact@v3
+        with:
+          pattern: standalone-*
+          merge-multiple: true
+          path: archives
+      - name: Download standalone MacOS
+        uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # ratchet:actions/download-artifact@v3
+        with:
+          pattern: staged-*
+          merge-multiple: true
+          path: archives
       - name: Create release
         uses: softprops/action-gh-release@69320dbe05506a9a39fc8ae11030b214ec2d1f87 # ratchet:softprops/action-gh-release@v2.0.5
         with:
@@ -48,7 +60,7 @@ jobs:
           body_path: release_notes.txt
           fail_on_unmatched_files: true
           tag_name: '${{ inputs.tags }}'
-          # TODO: add installers/* archives/* once windows support is back
+          # TODO: add installers/* once windows support is back
           files: |-
             dist/*
             archives/*