mirror/OpenRGB
1
0
Fork 0
mirror of https://github.com/CalcProgrammer1/OpenRGB.git synced 2025-12-23 23:37:48 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add comment indicating location is mandatory, list possible locations, rename SettingsTabBar to SettingsTab for consistency

Browse Source
This commit is contained in:
Adam Honse
2021-08-29 14:32:19 -05:00
parent 524fd057fe
commit 702be2401b
2 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
OpenRGBPluginInterface.h
View File

@@ -33,7 +33,9 @@ struct OpenRGBPluginInfo
/*-------------------------------------------------------------------------------------------------*\
| Plugin Tab Configuration |
\*-------------------------------------------------------------------------------------------------*/
std::string Location; /* Plugin tab location, such as "TopTabBar" */
std::string Location; /* Plugin tab location. This field is mandatory */
/* Options are "TopTabBar", "DevicesTab", */
/* "InformationTab", or "SettingsTab" */
std::string Label; /* Plugin tab label string */
std::string TabIconString; /* Plugin tab icon string, leave empty to use custom */
QImage TabIcon; /* Custom tab icon image (displayed 16x16) */

14
qt/OpenRGBDialog2.cpp
View File

@@ -769,9 +769,9 @@ void OpenRGBDialog2::AddPluginTab(OpenRGBPluginEntry* plugin)
ui->MainTabBar->addTab(NewPluginContainer,QString().fromStdString(plugin->info.Label));
}
/*-----------------------------------------------------*\
| SettingsTabBar - Place plugin in the Settings tab |
| SettingsTab - Place plugin in the Settings tab |
\*-----------------------------------------------------*/
else if(plugin->info.Location == "SettingsTabBar")
else if(plugin->info.Location == "SettingsTab")
{
QWidget* NewPluginTab = plugin->plugin->CreateGUI(this);
@@ -819,11 +819,11 @@ void OpenRGBDialog2::RemovePluginTab(OpenRGBPluginEntry* plugin)
{
for(int tab_idx = 0; tab_idx < ui->DevicesTabBar->count(); tab_idx++)
{
if(dynamic_cast<OpenRGBPluginContainer*>(ui->DevicesTabBar->widget(tab_idx)) != nullptr)
if(dynamic_cast<OpenRGBPluginContainer*>(ui->DeviceTabBar->widget(tab_idx)) != nullptr)
{
if(dynamic_cast<OpenRGBPluginContainer*>(ui->DevicesTabBar->widget(tab_idx))->plugin_widget == plugin->widget)
if(dynamic_cast<OpenRGBPluginContainer*>(ui->DeviceTabBar->widget(tab_idx))->plugin_widget == plugin->widget)
{
ui->DevicesTabBar->removeTab(tab_idx);
ui->DeviceTabBar->removeTab(tab_idx);
delete plugin->widget;
}
}
@@ -847,9 +847,9 @@ void OpenRGBDialog2::RemovePluginTab(OpenRGBPluginEntry* plugin)
}
}
/*-----------------------------------------------------*\
| SettingsTabBar - Place plugin in the Settings tab |
| SettingsTab - Place plugin in the Settings tab |
\*-----------------------------------------------------*/
else if(plugin->info.Location == "SettingsTabBar")
else if(plugin->info.Location == "SettingsTab")
{
for(int tab_idx = 0; tab_idx < ui->SettingsTabBar->count(); tab_idx++)
{