mirror/OpenRGB
1
0
Fork 0
mirror of https://github.com/CalcProgrammer1/OpenRGB.git synced 2026-07-29 14:36:06 -04:00
Code Issues Packages Projects Releases Wiki Activity

Maintain a list of created virtual controllers in the OpenRGBPluginAPI object and only allow registering virtual controllers that exist in this list

Browse Source
This commit is contained in:
Adam Honse
2026-07-11 02:57:34 -05:00
parent ba33ff0c35
commit a0cee2ce2b
2 changed files with 34 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
OpenRGBPluginAPI.cpp
View File

@@ -41,6 +41,12 @@ RGBControllerInterface* OpenRGBPluginAPI::CreateVirtualRGBController(RGBControll
{
RGBController_Virtual* rgb_controller = new RGBController_Virtual(setup);
/*-----------------------------------------------------*\
| Add the new controller to the list of created |
| controllers |
\*-----------------------------------------------------*/
created_controllers.push_back((RGBController*)rgb_controller);
return(rgb_controller);
}
@@ -63,6 +69,27 @@ void OpenRGBPluginAPI::RegisterVirtualRGBController(RGBControllerInterface* rgb_
{
LOG_INFO("[PluginManager] Registering RGB controller %s", rgb_controller->GetName().c_str());
/*-----------------------------------------------------*\
| Ensure the pointer given is a pointer to a valid |
| virtual controller |
\*-----------------------------------------------------*/
bool found = false;
for(std::size_t controller_idx = 0; controller_idx < created_controllers.size(); controller_idx++)
{
if(created_controllers[controller_idx] == rgb_controller)
{
found = true;
break;
}
}
if(!found)
{
LOG_ERROR("[PluginManager] Attempted to register an RGBController that was not created by this plugin API instance.");
return;
}
/*-----------------------------------------------------*\
| Mark this controller as locally owned |
\*-----------------------------------------------------*/
@@ -131,6 +158,12 @@ void OpenRGBPluginAPI::UpdateVirtualRGBController(RGBControllerInterface* rgb_co
void OpenRGBPluginAPI::DeleteVirtualRGBController(RGBControllerInterface* rgb_controller)
{
/*-----------------------------------------------------*\
| Remove the controller from the list of created |
| controllers |
\*-----------------------------------------------------*/
created_controllers.erase(std::remove(created_controllers.begin(), created_controllers.end(), (RGBController*)rgb_controller), created_controllers.end());
delete (RGBController*)rgb_controller;
}

1
OpenRGBPluginAPI.h
View File

@@ -67,6 +67,7 @@ public:
/*-----------------------------------------------------*\
| RGBControllers registered by plugin |
\*-----------------------------------------------------*/
std::vector<RGBController*> created_controllers;
std::vector<RGBController*> rgb_controllers;
private: