mirror/OpenRGB
1
0
Fork 0
mirror of https://github.com/CalcProgrammer1/OpenRGB.git synced 2026-04-09 16:37:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add check to ensure we have a valid SMBus index before detecting/dumping, prevents segfaults when clicking detect on an invalid bus

Browse Source
This commit is contained in:
Adam Honse
2020-03-29 16:50:21 -05:00
parent 556fb634bb
commit eba9fc0213
1 changed files with 24 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
qt/OpenRGBSystemInfoPage.cpp
View File

@@ -37,15 +37,34 @@ OpenRGBSystemInfoPage::~OpenRGBSystemInfoPage()
void Ui::OpenRGBSystemInfoPage::on_DetectButton_clicked()
{
i2c_smbus_interface* bus = busses[ui->SMBusAdaptersBox->currentIndex()];
int current_index = ui->SMBusAdaptersBox->currentIndex();
ui->SMBusDataText->setPlainText(i2c_detect(bus, MODE_QUICK).c_str());
if(current_index < 0)
{
current_index = 0;
}
if(busses.size() > current_index)
{
i2c_smbus_interface* bus = busses[current_index];
ui->SMBusDataText->setPlainText(i2c_detect(bus, MODE_QUICK).c_str());
}
}
void Ui::OpenRGBSystemInfoPage::on_DumpButton_clicked()
{
i2c_smbus_interface* bus = busses[ui->SMBusAdaptersBox->currentIndex()];
unsigned char address = ui->DumpAddressBox->value();
int current_index = ui->SMBusAdaptersBox->currentIndex();
ui->SMBusDataText->setPlainText(i2c_dump(bus, address).c_str());
if(current_index < 0)
{
current_index = 0;
}
if(busses.size() > current_index)
{
i2c_smbus_interface* bus = busses[current_index];
unsigned char address = ui->DumpAddressBox->value();
ui->SMBusDataText->setPlainText(i2c_dump(bus, address).c_str());
}
}