mirror of
https://github.com/CalcProgrammer1/OpenRGB.git
synced 2026-07-30 06:56:08 -04:00
ReadVersion() issued a register-less block read, so the device returned a status byte (0x01) instead of the version string. Read register 0xF0 (a 32-byte ASCII board string), as the vendor tool does, and validate it. - fixes the empty/garbage firmware version in the log and GUI - closes an out-of-bounds read (unbounded std::string over a 32-byte buffer) - tested on RTX 5080 AMP Extreme INFINITY: now reads "N762A-2008e"
158 lines
6.1 KiB
C++
158 lines
6.1 KiB
C++
/*---------------------------------------------------------*\
|
|
| ZotacBlackwellGPUController.cpp |
|
|
| |
|
|
| Driver for ZOTAC Blackwell (RTX 50 series) GPU |
|
|
| |
|
|
| Eder Sánchez 27 Mar 2026 |
|
|
| |
|
|
| This file is part of the OpenRGB project |
|
|
| SPDX-License-Identifier: GPL-2.0-or-later |
|
|
\*---------------------------------------------------------*/
|
|
|
|
#include <chrono>
|
|
#include <thread>
|
|
#include "ZotacBlackwellGPUController.h"
|
|
#include "LogManager.h"
|
|
|
|
ZotacBlackwellGPUController::ZotacBlackwellGPUController(i2c_smbus_interface* bus, u8 dev, std::string dev_name)
|
|
{
|
|
this->bus = bus;
|
|
this->dev = dev;
|
|
this->name = dev_name;
|
|
|
|
ReadVersion();
|
|
}
|
|
|
|
ZotacBlackwellGPUController::~ZotacBlackwellGPUController()
|
|
{
|
|
}
|
|
|
|
std::string ZotacBlackwellGPUController::GetDeviceLocation()
|
|
{
|
|
std::string return_string(bus->info.device_name);
|
|
char addr[5];
|
|
snprintf(addr, 5, "0x%02X", dev);
|
|
return_string.append(", address ");
|
|
return_string.append(addr);
|
|
return("I2C: " + return_string);
|
|
}
|
|
|
|
std::string ZotacBlackwellGPUController::GetName()
|
|
{
|
|
return(name);
|
|
}
|
|
|
|
std::string ZotacBlackwellGPUController::GetVersion()
|
|
{
|
|
return(version);
|
|
}
|
|
|
|
void ZotacBlackwellGPUController::ReadVersion()
|
|
{
|
|
/*---------------------------------------------------------*\
|
|
| The firmware/board version is a 32-byte ASCII string |
|
|
| (e.g. "N762E...") read from register 0xF0 - the same |
|
|
| register-addressed read the vendor FireStorm utility |
|
|
| performs. A bare register-less read returns a status |
|
|
| byte instead of the string, so the register must be |
|
|
| selected first. |
|
|
| |
|
|
| Bound the string to the returned length, terminate at |
|
|
| the first NUL, trim trailing padding (0xFF) and spaces, |
|
|
| and accept only printable ASCII. Fall back to |
|
|
| "Unknown" otherwise. |
|
|
\*---------------------------------------------------------*/
|
|
u8 rdata_pkt[I2C_SMBUS_BLOCK_MAX] = { 0x00 };
|
|
s32 rdata_len;
|
|
|
|
version = "Unknown";
|
|
rdata_len = bus->i2c_smbus_read_i2c_block_data(dev, ZOTAC_BLACKWELL_GPU_REG_VERSION, I2C_SMBUS_BLOCK_MAX, rdata_pkt);
|
|
|
|
if(rdata_len > 0)
|
|
{
|
|
int length = 0;
|
|
|
|
while(length < rdata_len && rdata_pkt[length] != 0x00)
|
|
{
|
|
length++;
|
|
}
|
|
|
|
while(length > 0 && (rdata_pkt[length - 1] == 0xFF || rdata_pkt[length - 1] == ' '))
|
|
{
|
|
length--;
|
|
}
|
|
|
|
bool printable = (length > 0);
|
|
|
|
for(int i = 0; i < length; i++)
|
|
{
|
|
if(rdata_pkt[i] < 0x20 || rdata_pkt[i] > 0x7E)
|
|
{
|
|
printable = false;
|
|
break;
|
|
}
|
|
}
|
|
|
|
if(printable)
|
|
{
|
|
version = std::string((char*)rdata_pkt, length);
|
|
}
|
|
}
|
|
|
|
LOG_INFO("[%s] Firmware version: %s", name.c_str(), version.c_str());
|
|
}
|
|
|
|
void ZotacBlackwellGPUController::SetMode
|
|
(
|
|
unsigned int zone,
|
|
unsigned int mode_val,
|
|
RGBColor color1,
|
|
RGBColor color2,
|
|
unsigned int brightness,
|
|
unsigned int speed,
|
|
unsigned int direction
|
|
)
|
|
{
|
|
/*---------------------------------------------------------*\
|
|
| Write all 16 registers 0x20 - 0x2F via individual |
|
|
| i2c_smbus_write_byte_data calls with 3ms delay between |
|
|
| each transaction. Partial writes are not supported. |
|
|
\*---------------------------------------------------------*/
|
|
|
|
u8 regs[16];
|
|
regs[0x00] = 0x00; /* 0x20 - Fixed = 0x00 */
|
|
regs[0x01] = (u8)zone; /* 0x21 - Zone index */
|
|
regs[0x02] = (u8)mode_val; /* 0x22 - Mode */
|
|
regs[0x03] = (u8)RGBGetRValue(color1); /* 0x23 - Red 1 */
|
|
regs[0x04] = (u8)RGBGetGValue(color1); /* 0x24 - Green 1 */
|
|
regs[0x05] = (u8)RGBGetBValue(color1); /* 0x25 - Blue 1 */
|
|
regs[0x06] = (u8)RGBGetRValue(color2); /* 0x26 - Red 2 */
|
|
regs[0x07] = (u8)RGBGetGValue(color2); /* 0x27 - Green 2 */
|
|
regs[0x08] = (u8)RGBGetBValue(color2); /* 0x28 - Blue 2 */
|
|
regs[0x09] = (u8)brightness; /* 0x29 - Brightness (0-100) */
|
|
regs[0x0A] = (u8)speed; /* 0x2A - Speed (0-100) */
|
|
regs[0x0B] = (u8)direction; /* 0x2B - Direction */
|
|
regs[0x0C] = 0x00; /* 0x2C - Reserved */
|
|
regs[0x0D] = 0x00; /* 0x2D - Reserved */
|
|
regs[0x0E] = 0x00; /* 0x2E - Reserved */
|
|
regs[0x0F] = 0x00; /* 0x2F - Reserved */
|
|
|
|
for(int i = 0; i < 16; i++)
|
|
{
|
|
bus->i2c_smbus_write_byte_data(dev, (u8)(ZOTAC_BLACKWELL_GPU_REG_FIXED + i), regs[i]);
|
|
std::this_thread::sleep_for(std::chrono::microseconds(ZOTAC_BLACKWELL_GPU_DELAY_US));
|
|
}
|
|
}
|
|
|
|
void ZotacBlackwellGPUController::Commit()
|
|
{
|
|
/*---------------------------------------------------------*\
|
|
| Write commit register to apply staged changes. |
|
|
| A longer delay is needed after commit to allow the |
|
|
| firmware to process the change — without this, some |
|
|
| effects don't visually update until a parameter changes. |
|
|
\*---------------------------------------------------------*/
|
|
bus->i2c_smbus_write_byte_data(dev, ZOTAC_BLACKWELL_GPU_REG_COMMIT, 0x01);
|
|
std::this_thread::sleep_for(std::chrono::microseconds(ZOTAC_BLACKWELL_GPU_COMMIT_DELAY_US));
|
|
}
|