mirror/Wallos
1
0
Fork 0
mirror of https://github.com/ellite/Wallos.git synced 2025-12-23 23:18:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

use stable UID for iCal events to prevent duplicates (#966)

Browse Source 
Changed UID generation from uniqid() to a stable format based on
subscription ID (wallos-subscription-{id}@wallos). This ensures that
calendar applications update existing events instead of creating
duplicates when the feed is refreshed.

According to RFC 5545 section 3.8.4.7, the UID property must be
globally unique and persistent for the lifetime of the event.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
Pedro Pombeiro
2025-12-20 16:04:41 +01:00
committed by GitHub
parent b6b0abed0d
commit 671763e78b
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
api/subscriptions/get_ical_feed.php
View File

@@ -172,7 +172,7 @@ if ($_SERVER["REQUEST_METHOD"] === "POST" || $_SERVER["REQUEST_METHOD"] === "GET
$subscription['trigger'] = ($subscription['notify_days_before'] == -1) ? $globalNotificationDays : ($subscription['notify_days_before'] ?: 1);
$subscription['price'] = number_format($subscription['price'], 2);
$uid = uniqid();
$uid = 'wallos-subscription-' . $subscription['id'] . '@wallos';
$summary = html_entity_decode($subscription['name'], ENT_QUOTES, 'UTF-8');
$description = "Price: {$subscription['currency']}{$subscription['price']}\\nCategory: {$subscription['category']}\\nPayment Method: {$subscription['payment_method']}\\nPayer: {$subscription['payer_user']}\\nNotes: {$subscription['notes']}";
$dtstamp = gmdate('Ymd\THis\Z');

2
endpoints/subscription/exportcalendar.php
View File

@@ -31,7 +31,7 @@ if ($subscription) {
$subscription['price'] = number_format($subscription['price'], 2);
// Create ICS from subscription information
$uid = uniqid();
$uid = 'wallos-subscription-' . $subscription['id'] . '@wallos';
$summary = html_entity_decode($subscription['name'], ENT_QUOTES, 'UTF-8');
$description = "Price: {$subscription['currency']}{$subscription['price']}\nCategory: {$subscription['category']}\nPayment Method: {$subscription['payment_method']}\nPayer: {$subscription['payer_user']}\n\nNotes: {$subscription['notes']}";