mirror/WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-08-02 19:10:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

perf: resolve the portrait's widget once rather than every frame

Browse Source 
findByName compares the name of every widget in the tree, and the tree holds
some eight and a half thousand after FrameXML loads. Ids are stable, so the
lookup is kept and reused; the name is still checked each frame because
reloading the interface rebuilds the tree and an id could then belong to
something else.
This commit is contained in:
Kelsi
2026-08-01 20:07:16 -07:00
parent 37de38eff4
commit c08fcffe4d
2 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
include/core/application.hpp
View File

@@ -154,6 +154,11 @@ private:
ui::WidgetRenderer widgetRenderer_;
/// The live head-and-shoulders view the interface's portrait draws.
ui::UnitPortrait unitPortrait_;
/// Where the portrait's widget was found last time. Ids are stable, so
/// this saves a scan of every widget by name on every frame; the name is
/// still checked, because reloading the interface rebuilds the tree and
/// the id could then belong to something else.
uint32_t portraitWidgetId_ = 0;
bool addonsLoaded_ = false;
std::unique_ptr<game::ExpansionRegistry> expansionRegistry_;
// Empty means assets follow the active protocol profile. "legacy" selects

9
src/core/application.cpp
View File

@@ -2873,9 +2873,14 @@ void Application::render() {
// descriptor set that has been destroyed — the render target is
// torn down whenever the model is rebuilt — and drawing from
// that is a use-after-free rather than a stale picture.
if (auto* w = engine->widgets().findByName("PlayerPortrait")) {
w->externalTexture = unitPortrait_.textureId();
auto& widgets = engine->widgets();
ui::Widget* portrait = portraitWidgetId_
? widgets.get(portraitWidgetId_) : nullptr;
if (!portrait || portrait->name != "PlayerPortrait") {
portrait = widgets.findByName("PlayerPortrait");
portraitWidgetId_ = portrait ? portrait->id : 0;
}
if (portrait) portrait->externalTexture = unitPortrait_.textureId();
}
// Lay out first: hit testing reads the rects this produces, so