Kelsi 9fb614db34 test(spell): cover range classification and superseded rank resolution ...

Every spell fix this week was verified by hand against the DBCs, which found the
bugs but did nothing to stop them coming back. The decision logic is now a set of
pure functions in spell_classification.hpp, driven by DBC data rather than spell
ids, and SpellHandler delegates to them so the tested code is the code that runs.

31 assertions across 8 cases, each pinned to a real regression: a physical-school
self-buff must not read as melee (Battle Shout), a physical-school 35-yard shot
must not read as melee (Steady Shot, Taunt, Deadly Throw), and a superseded rank
must resolve to the highest rank actually known while leaving item spells and
other classes' spells alone.

2026-07-14 14:40:23 -07:00

6.0 KiB

Raw Blame History

View Raw