mirror/WowUp
1
0
Fork 0
mirror of https://github.com/WowUp/WowUp.git synced 2026-04-23 07:17:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix #717

Browse Source 
Ensure TukUI addon ids are strings
This commit is contained in:
jliddev
2021-02-06 21:54:03 -06:00
parent 343577488e
commit 65df33b8d2
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
wowup-electron/src/app/addon-providers/tukui-addon-provider.ts
View File

@@ -129,7 +129,7 @@ export class TukUiAddonProvider extends AddonProvider {
addonFolders: AddonFolder[]
): Promise<void> {
const allAddons = await this.getAllAddons(clientType);
for (let addonFolder of addonFolders) {
for (const addonFolder of addonFolders) {
let tukUiAddon: TukUiAddon;
if (addonFolder.toc?.tukUiProjectId) {
tukUiAddon = _.find(allAddons, (addon) => addon.id.toString() === addonFolder.toc.tukUiProjectId);
@@ -271,7 +271,6 @@ export class TukUiAddonProvider extends AddonProvider {
addons.push(await this.getTukUiRetailAddon());
addons.push(await this.getElvUiRetailAddon());
}
return addons;
};
@@ -283,11 +282,14 @@ export class TukUiAddonProvider extends AddonProvider {
return this.getClientApiAddon("elvui");
}
private getClientApiAddon(addonName: string): Promise<TukUiAddon> {
private async getClientApiAddon(addonName: string): Promise<TukUiAddon> {
const url = new URL(CLIENT_API_URL);
url.searchParams.append("ui", addonName);
return this._circuitBreaker.getJson<TukUiAddon>(url);
const result = await this._circuitBreaker.getJson<TukUiAddon>(url);
result.id = result.id.toString(); // For some reason addons from this route have numeric ids not strings
return result;
}
private isRetail(clientType: WowClientType) {