mirror/ai-marketplace-monitor
1
0
Fork 0
mirror of https://github.com/BoPeng/ai-marketplace-monitor.git synced 2025-12-23 22:28:18 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix premature keyword filtering in Facebook marketplace scraping (#248)

Browse Source 
* Fix premature keyword filtering in Facebook marketplace scraping

Addresses a critical bug where listings were incorrectly rejected during
keyword filtering before their descriptions had been extracted from
Facebook's detail pages.

## Problem

The dual-check workflow was failing:
1. First check_listing() call: On search results with empty descriptions
2. Second check_listing() call: After get_listing_details() populates descriptions

Listings with keywords only in descriptions were being rejected prematurely,
causing false negatives for valid matches.

## Solution

- Add description_available parameter to check_listing() to control filtering
- Skip keyword filtering when descriptions haven't been fetched yet
- Maintain antikeyword filtering on available text (title-only or title+description)
- Add warning logs when description extraction fails

## Changes

- facebook.py: Add description_available parameter and conditional filtering logic
- monitor.py: Add defensive tuple unpacking for get_listing_details() return value
- Add comprehensive test suite for keyword filtering edge cases
- Fix minor formatting inconsistencies throughout codebase

## Testing

- New test suite demonstrates the bug and validates the fix
- Tests cover keyword filtering with/without descriptions
- Antikeyword filtering verified to work correctly in all cases
- All existing tests continue to pass

Fixes: #247

* Apply minor code improvements from PR feedback

- Remove redundant description_available=True parameter (uses default)
- Move self.logger check to outer if condition to avoid nested checks

These changes improve code clarity and efficiency.
This commit is contained in:
adawalli
2025-08-09 21:28:14 -04:00
committed by GitHub
parent ce75502160
commit eb8763226f
11 changed files with 279 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

96
src/ai_marketplace_monitor/facebook.py
View File

@@ -298,12 +298,12 @@ class FacebookMarketplace(Marketplace):
)
elif self.logger:
self.logger.debug(
f'{hilight("[Login]", "succ")} Cookie consent pop-up not found or not visible within timeout.'
f"{hilight('[Login]', 'succ')} Cookie consent pop-up not found or not visible within timeout."
)
except Exception as e:
if self.logger:
self.logger.warning(
f'{hilight("[Login]", "fail")} Could not handle cookie pop-up (or it was not present): {e!s}'
f"{hilight('[Login]', 'fail')} Could not handle cookie pop-up (or it was not present): {e!s}"
)
self.config: FacebookMarketplaceConfig
@@ -498,8 +498,8 @@ class FacebookMarketplace(Marketplace):
return
counter.increment(CounterItem.LISTING_EXAMINED, item_config.name)
found[listing.post_url.split("?")[0]] = True
# filter by title and location since we do not have description and seller yet.
if not self.check_listing(listing, item_config):
# filter by title and location; skip keyword filtering since we do not have description yet.
if not self.check_listing(listing, item_config, description_available=False):
counter.increment(CounterItem.EXCLUDED_LISTING, item_config.name)
continue
try:
@@ -527,8 +527,20 @@ class FacebookMarketplace(Marketplace):
listing.name = item_config.name
if self.logger:
self.logger.debug(
f"""{hilight("[Retrieve]", "succ")} New item "{listing.title}" from https://www.facebook.com{listing.post_url} is sold by "{listing.seller}" and with description "{listing.description[:100]}..." """
f"""{hilight("[Retrieve]", "succ")} New item "{listing.title}" from {listing.post_url} is sold by "{listing.seller}" and with description "{listing.description[:100]}..." """
)
# Warn if we never managed to extract a description for keyword-based filtering
if (
(not listing.description or len(listing.description.strip()) == 0)
and item_config.keywords
and len(item_config.keywords) > 0
and self.logger
):
self.logger.debug(
f"""{hilight("[Error]", "fail")} Failed to extract description for {hilight(listing.title)} at {listing.post_url}. Keyword filtering will only apply to title."""
)
if self.check_listing(listing, item_config):
yield listing
else:
@@ -568,7 +580,10 @@ class FacebookMarketplace(Marketplace):
return details, False
def check_listing(
self: "FacebookMarketplace", item: Listing, item_config: FacebookItemConfig
self: "FacebookMarketplace",
item: Listing,
item_config: FacebookItemConfig,
description_available: bool = True,
) -> bool:
# get antikeywords from both item_config or config
antikeywords = item_config.antikeywords
@@ -577,14 +592,18 @@ class FacebookMarketplace(Marketplace):
):
if self.logger:
self.logger.info(
f"""{hilight("[Skip]", "fail")} Exclude {hilight(item.title)} due to {hilight("excluded keywords", "fail")}: {', '.join(antikeywords)}"""
f"""{hilight("[Skip]", "fail")} Exclude {hilight(item.title)} due to {hilight("excluded keywords", "fail")}: {", ".join(antikeywords)}"""
)
return False
# if the return description does not contain any of the search keywords
keywords = item_config.keywords
if keywords and not (
is_substring(keywords, item.title + " " + item.description, logger=self.logger)
if (
description_available
and keywords
and not (
is_substring(keywords, item.title + " " + item.description, logger=self.logger)
)
):
if self.logger:
self.logger.info(
@@ -626,7 +645,6 @@ class FacebookMarketplace(Marketplace):
class FacebookSearchResultPage(WebPage):
def _get_listings_elements_by_children_counts(self: "FacebookSearchResultPage"):
parent: ElementHandle | None = self.page.locator("img").first.element_handle()
# look for parent of parent until it has more than 10 children
@@ -647,7 +665,7 @@ class FacebookSearchResultPage(WebPage):
# this error should be tolerated
if self.logger:
self.logger.debug(
f'{hilight("[Retrieve]", "fail")} Some grid item cannot be read: {e}'
f"{hilight('[Retrieve]', 'fail')} Some grid item cannot be read: {e}"
)
return valid_listings
@@ -672,7 +690,7 @@ class FacebookSearchResultPage(WebPage):
# this error should be tolerated
if self.logger:
self.logger.debug(
f'{hilight("[Retrieve]", "fail")} Some grid item cannot be read: {e}'
f"{hilight('[Retrieve]', 'fail')} Some grid item cannot be read: {e}"
)
return valid_listings
@@ -687,7 +705,7 @@ class FacebookSearchResultPage(WebPage):
and self.translator("Browse Marketplace") in (x[-1].text_content() or ""),
1,
)
self.logger.info(f'{hilight("[Retrieve]", "dim")} {msg}')
self.logger.info(f"{hilight('[Retrieve]', 'dim')} {msg}")
return []
# find the grid box
@@ -702,7 +720,7 @@ class FacebookSearchResultPage(WebPage):
filename = datetime.datetime.now().strftime("debug_%Y%m%d_%H%M%S.html")
if self.logger:
self.logger.error(
f'{hilight("[Retrieve]", "fail")} failed to parse searching result. Page saved to {filename}: {e}'
f"{hilight('[Retrieve]', 'fail')} failed to parse searching result. Page saved to {filename}: {e}"
)
with open(filename, "w", encoding="utf-8") as f:
f.write(self.page.content())
@@ -761,14 +779,13 @@ class FacebookSearchResultPage(WebPage):
except Exception as e:
if self.logger:
self.logger.error(
f'{hilight("[Retrieve]", "fail")} Failed to parse search results {idx + 1} listing: {e}'
f"{hilight('[Retrieve]', 'fail')} Failed to parse search results {idx + 1} listing: {e}"
)
continue
return listings
class FacebookItemPage(WebPage):
def verify_layout(self: "FacebookItemPage") -> bool:
return True
@@ -806,7 +823,7 @@ class FacebookItemPage(WebPage):
raise ValueError(f"Failed to parse {post_url}")
if self.logger:
self.logger.info(f'{hilight("[Retrieve]", "succ")} Parsing {hilight(title)}')
self.logger.info(f"{hilight('[Retrieve]', 'succ')} Parsing {hilight(title)}")
res = Listing(
marketplace="facebook",
name="",
@@ -821,7 +838,7 @@ class FacebookItemPage(WebPage):
seller=self.get_seller(),
)
if self.logger:
self.logger.debug(f'{hilight("[Retrieve]", "succ")} {pretty_repr(res)}')
self.logger.debug(f"{hilight('[Retrieve]', 'succ')} {pretty_repr(res)}")
return cast(Listing, res)
@@ -840,7 +857,7 @@ class FacebookRegularItemPage(FacebookItemPage):
raise
except Exception as e:
if self.logger:
self.logger.debug(f'{hilight("[Retrieve]", "fail")} {e}')
self.logger.debug(f"{hilight('[Retrieve]', 'fail')} {e}")
return ""
def get_price(self: "FacebookRegularItemPage") -> str:
@@ -851,7 +868,7 @@ class FacebookRegularItemPage(FacebookItemPage):
raise
except Exception as e:
if self.logger:
self.logger.debug(f'{hilight("[Retrieve]", "fail")} {e}')
self.logger.debug(f"{hilight('[Retrieve]', 'fail')} {e}")
return ""
def get_image_url(self: "FacebookRegularItemPage") -> str:
@@ -862,7 +879,7 @@ class FacebookRegularItemPage(FacebookItemPage):
raise
except Exception as e:
if self.logger:
self.logger.debug(f'{hilight("[Retrieve]", "fail")} {e}')
self.logger.debug(f"{hilight('[Retrieve]', 'fail')} {e}")
return ""
def get_seller(self: "FacebookRegularItemPage") -> str:
@@ -873,7 +890,9 @@ class FacebookRegularItemPage(FacebookItemPage):
raise
except Exception as e:
if self.logger:
self.logger.debug(f'{hilight("[Retrieve]", "fail")} {e}')
self.logger.error(
f"{hilight('[Error]', 'fail')} get_seller failed: {type(e).__name__}: {e}"
)
return ""
def get_description(self: "FacebookRegularItemPage") -> str:
@@ -887,24 +906,35 @@ class FacebookRegularItemPage(FacebookItemPage):
raise
except Exception as e:
if self.logger:
self.logger.debug(f'{hilight("[Retrieve]", "fail")} {e}')
self.logger.debug(f"{hilight('[Retrieve]', 'fail')} {e}")
return ""
def get_condition(self: "FacebookRegularItemPage") -> str:
try:
if self.logger:
self.logger.debug(f"{hilight('[Debug]', 'info')} Getting condition info...")
# Find the span with text "condition", then parent, then next...
condition_element = self.page.locator(f'span:text("{self.translator("Condition")}")')
return self._parent_with_cond(
condition_text = self.translator("Condition")
# Use .first property to avoid strict mode violation when multiple elements match
# This handles cases where "Condition" appears in both the label and description text
condition_locator = self.page.locator(f'span:text("{condition_text}")')
condition_element = condition_locator.first
result = self._parent_with_cond(
condition_element,
lambda x: len(x) >= 2
and self.translator("Condition") in (x[0].text_content() or ""),
1,
)
return result
except KeyboardInterrupt:
raise
except Exception as e:
if self.logger:
self.logger.debug(f'{hilight("[Retrieve]", "fail")} {e}')
self.logger.error(
f"{hilight('[Error]', 'fail')} get_condition failed: {type(e).__name__}: {e}"
)
return ""
def get_location(self: "FacebookRegularItemPage") -> str:
@@ -923,7 +953,7 @@ class FacebookRegularItemPage(FacebookItemPage):
raise
except Exception as e:
if self.logger:
self.logger.debug(f'{hilight("[Retrieve]", "fail")} {e}')
self.logger.debug(f"{hilight('[Retrieve]', 'fail')} {e}")
return ""
@@ -951,7 +981,7 @@ class FacebookRentalItemPage(FacebookRegularItemPage):
raise
except Exception as e:
if self.logger:
self.logger.debug(f'{hilight("[Retrieve]", "fail")} {e}')
self.logger.debug(f"{hilight('[Retrieve]', 'fail')} {e}")
return ""
def get_condition(self: "FacebookRentalItemPage") -> str:
@@ -990,7 +1020,7 @@ class FacebookAutoItemWithAboutAndDescriptionPage(FacebookRegularItemPage):
raise
except Exception as e:
if self.logger:
self.logger.debug(f'{hilight("[Retrieve]", "fail")} {e}')
self.logger.debug(f"{hilight('[Retrieve]', 'fail')} {e}")
return ""
def _get_seller_description(self: "FacebookAutoItemWithAboutAndDescriptionPage") -> str:
@@ -1018,7 +1048,7 @@ class FacebookAutoItemWithAboutAndDescriptionPage(FacebookRegularItemPage):
raise
except Exception as e:
if self.logger:
self.logger.debug(f'{hilight("[Retrieve]", "fail")} {e}')
self.logger.debug(f"{hilight('[Retrieve]', 'fail')} {e}")
return ""
def verify_layout(self: "FacebookAutoItemWithAboutAndDescriptionPage") -> bool:
@@ -1069,7 +1099,7 @@ class FacebookAutoItemWithDescriptionPage(FacebookAutoItemWithAboutAndDescriptio
raise
except Exception as e:
if self.logger:
self.logger.debug(f'{hilight("[Retrieve]", "fail")} {e}')
self.logger.debug(f"{hilight('[Retrieve]', 'fail')} {e}")
return ""
def get_condition(self: "FacebookAutoItemWithDescriptionPage") -> str:
@@ -1100,7 +1130,7 @@ class FacebookAutoItemWithDescriptionPage(FacebookAutoItemWithAboutAndDescriptio
raise
except Exception as e:
if self.logger:
self.logger.debug(f'{hilight("[Retrieve]", "fail")} {e}')
self.logger.debug(f"{hilight('[Retrieve]', 'fail')} {e}")
return ""
def get_price(self: "FacebookAutoItemWithDescriptionPage") -> str:
@@ -1120,7 +1150,7 @@ class FacebookAutoItemWithDescriptionPage(FacebookAutoItemWithAboutAndDescriptio
raise
except Exception as e:
if self.logger:
self.logger.debug(f'{hilight("[Retrieve]", "fail")} {e}')
self.logger.debug(f"{hilight('[Retrieve]', 'fail')} {e}")
return ""

4
src/ai_marketplace_monitor/marketplace.py
View File

@@ -433,7 +433,6 @@ TItemConfig = TypeVar("TItemConfig", bound=ItemConfig)
class Marketplace(Generic[TMarketplaceConfig, TItemConfig]):
def __init__(
self: "Marketplace",
name: str,
@@ -509,7 +508,7 @@ class Marketplace(Generic[TMarketplaceConfig, TItemConfig]):
try:
assert self.page is not None
if self.logger:
self.logger.debug(f'{hilight("[Retrieve]", "info")} Navigating to {url}')
self.logger.debug(f"{hilight('[Retrieve]', 'info')} Navigating to {url}")
self.page.goto(url, timeout=0)
self.page.wait_for_load_state("domcontentloaded")
except KeyboardInterrupt:
@@ -525,7 +524,6 @@ class Marketplace(Generic[TMarketplaceConfig, TItemConfig]):
class WebPage:
def __init__(
self: "WebPage",
page: Page,

11
src/ai_marketplace_monitor/monitor.py
View File

@@ -330,7 +330,7 @@ class MarketplaceMonitor:
)
if self.logger:
self.logger.info(
f"""{hilight("[Schedule]", "info")} Scheduling to search for {item_config.name} every {humanize.naturaldelta(search_interval)} {'' if search_interval == max_search_interval else f'to {humanize.naturaldelta(max_search_interval)}'}"""
f"""{hilight("[Schedule]", "info")} Scheduling to search for {item_config.name} every {humanize.naturaldelta(search_interval)} {"" if search_interval == max_search_interval else f"to {humanize.naturaldelta(max_search_interval)}"}"""
)
scheduled = schedule.every(search_interval).to(max_search_interval).seconds
if scheduled is None:
@@ -567,7 +567,14 @@ class MarketplaceMonitor:
item_config = self.config.item[for_item]
# do not search, get the item details directly
listing: Listing = marketplace.get_listing_details(post_url, item_config)
listing_result = marketplace.get_listing_details(post_url, item_config)
# get_listing_details returns a tuple (Listing, bool) - unpack it properly
if isinstance(listing_result, tuple) and len(listing_result) == 2:
listing, from_cache = listing_result
else:
# Fallback - treat as direct listing (shouldn't happen but defensive)
listing = listing_result
if self.logger:
self.logger.info(

2
src/ai_marketplace_monitor/ntfy.py
View File

@@ -47,7 +47,7 @@ class NtfyNotificationConfig(PushNotificationConfig):
assert self.ntfy_server is not None
assert self.ntfy_topic is not None
requests.post(
f'{self.ntfy_server.rstrip("/")}/{self.ntfy_topic}',
f"{self.ntfy_server.rstrip('/')}/{self.ntfy_topic}",
msg,
headers={
"Title": title,

2
src/ai_marketplace_monitor/pushover.py
View File

@@ -68,7 +68,7 @@ class PushoverNotificationConfig(PushNotificationConfig):
"token": self.pushover_api_token,
"user": self.pushover_user_key,
"message": msg,
"title": title + (f" ({idx+1}/{len(msgs)})" if len(msgs) > 1 else ""),
"title": title + (f" ({idx + 1}/{len(msgs)})" if len(msgs) > 1 else ""),
"html": 1,
}
),

1
src/ai_marketplace_monitor/user.py
View File

@@ -85,7 +85,6 @@ class UserConfig(
class User:
def __init__(self: "User", config: UserConfig, logger: Logger | None = None) -> None:
self.name = config.name
self.config = config

5
src/ai_marketplace_monitor/utils.py
View File

@@ -209,7 +209,6 @@ class KeyboardMonitor:
class Counter:
def increment(self: "Counter", counter_key: CounterItem, item_name: str, by: int = 1) -> None:
key = (CacheType.COUNTERS.value, counter_key.value, item_name)
try:
@@ -588,7 +587,9 @@ def fetch_with_retry(
for attempt in range(max_retries):
try:
response = requests.get(
url, timeout=timeout, stream=True # Good practice for downloading files
url,
timeout=timeout,
stream=True, # Good practice for downloading files
)
response.raise_for_status() # Raises exception for 4XX/5XX status codes

1
tests/test_ai.py
View File

@@ -42,7 +42,6 @@ def test_extra_prompt(
item_config: FacebookItemConfig,
marketplace_config: FacebookMarketplaceConfig,
) -> None:
marketplace_config.extra_prompt = "This is an extra prompt"
prompt = ollama.get_prompt(listing, item_config, marketplace_config)
assert "extra prompt" in prompt

2
tests/test_cli.py
View File

@@ -21,7 +21,7 @@ runner = CliRunner()
(["--help"], "Usage: "),
(
["--version"],
f"AI Marketplace Monitor, version { ai_marketplace_monitor.__version__ }\n",
f"AI Marketplace Monitor, version {ai_marketplace_monitor.__version__}\n",
),
],
)

14
tests/test_facebook.py
View File

@@ -24,19 +24,19 @@ def test_search_page(
for idx, listing in enumerate(listings):
assert listing.marketplace == "facebook"
assert listing.id.isnumeric(), f"wrong id for listing {idx+1} with title {listing.title}"
assert listing.title, f"No title is found {idx+1} with title "
assert listing.image, f"wrong image for listing {idx+1} with title {listing.title}"
assert listing.post_url, f"wrong post_url for listing {idx+1} with title {listing.title}"
assert listing.price, f"wrong price for listing {idx+1} with title {listing.title}"
assert listing.id.isnumeric(), f"wrong id for listing {idx + 1} with title {listing.title}"
assert listing.title, f"No title is found {idx + 1} with title "
assert listing.image, f"wrong image for listing {idx + 1} with title {listing.title}"
assert listing.post_url, f"wrong post_url for listing {idx + 1} with title {listing.title}"
assert listing.price, f"wrong price for listing {idx + 1} with title {listing.title}"
if idx == 10:
assert (
listing.location == ""
), f"listing {idx+1} with title {listing.title} has empty location"
), f"listing {idx + 1} with title {listing.title} has empty location"
else:
assert (
listing.location
), f"wrong location for listing {idx+1} with title {listing.title}"
), f"wrong location for listing {idx + 1} with title {listing.title}"
assert listing.seller == "", "Seller should be empty"
assert len(listings) == 21

193
tests/test_facebook_keyword_filtering.py Normal file
View File

@@ -0,0 +1,193 @@
from unittest.mock import MagicMock
import pytest
from ai_marketplace_monitor.facebook import FacebookItemConfig, FacebookMarketplace
from ai_marketplace_monitor.listing import Listing
@pytest.fixture
def facebook_marketplace() -> FacebookMarketplace:
"""Create a Facebook marketplace instance with properly mocked dependencies."""
marketplace = FacebookMarketplace(name="facebook", browser=MagicMock(), logger=MagicMock())
# Mock the config attribute following codebase patterns
mock_config = MagicMock()
mock_config.seller_locations = None
mock_config.exclude_sellers = None
marketplace.config = mock_config
return marketplace
@pytest.fixture
def keyword_item_config() -> FacebookItemConfig:
"""Create item config for testing keyword filtering."""
return FacebookItemConfig(
name="test_item",
search_phrases=["EMTB", "electric bike"],
keywords=["Gen 4", "Bosch", "Bosch CX"],
antikeywords=None,
min_price="1000",
max_price="5000",
)
def test_keyword_filtering_should_skip_when_description_empty(
facebook_marketplace: FacebookMarketplace, keyword_item_config: FacebookItemConfig
) -> None:
"""Test that demonstrates the premature keyword filtering bug.
This test shows that listings are incorrectly rejected during the first
check_listing() call when keywords exist in the description but the
description hasn't been fetched yet (description="").
The bug occurs in the workflow where check_listing() is called twice:
1. First call (around line 502): On search results with empty description
2. Second call (around line 544): After get_listing_details() populates description
The first call incorrectly rejects listings that would pass the second call.
"""
# Create a listing that would match keywords in description but not title
listing_with_empty_description = Listing(
marketplace="facebook",
name="test_item",
id="123456",
title="EMTB for sale 2024 model Full suspension", # No keywords in title
image="https://example.com/image.jpg",
price="$2,800",
post_url="/marketplace/item/123456/",
location="Roanoke, VA",
seller="",
condition="used",
description="", # Empty description (as it would be from search results)
)
# Same listing after description is populated
listing_with_populated_description = Listing(
marketplace="facebook",
name="test_item",
id="123456",
title="EMTB for sale 2024 model Full suspension",
image="https://example.com/image.jpg",
price="$2,800",
post_url="/marketplace/item/123456/",
location="Roanoke, VA",
seller="Test Seller",
condition="used",
description="EMTB carbon fiber, 29 inch wheels, full suspension, Bosch gen 4 motor, 800 watt/hour battery", # Contains "Gen 4" and "Bosch" keywords
)
# Test the fix: First call should PASS (skipping keyword filtering when description unavailable)
# This simulates the first check_listing() call around line 502
first_check_result = facebook_marketplace.check_listing(
listing_with_empty_description, keyword_item_config, description_available=False
)
# Test the correct behavior: Second call should PASS and currently DOES
# This simulates the second check_listing() call at line 532
second_check_result = facebook_marketplace.check_listing(
listing_with_populated_description, keyword_item_config, description_available=True
)
# FAILING TEST: This demonstrates the bug
# The first check should pass (skip keyword filtering when description is empty)
# but currently fails because it tries to filter on empty description
assert first_check_result, (
"BUG: First check_listing() call incorrectly rejects listing with empty description. "
"Keyword filtering should be skipped when description is empty."
)
# This should pass (and currently does)
assert (
second_check_result
), "Second check_listing() call should pass when description contains keywords"
@pytest.mark.parametrize(
"listing_data,expected_result,test_description",
[
(
{
"id": "123456",
"title": "Mountain bike for sale",
"price": "$2,000",
"description": "This bike has a Bosch gen 4 motor and excellent suspension",
},
True,
"should pass when keywords are found in description",
),
(
{
"id": "789012",
"title": "Regular bicycle for sale",
"price": "$500",
"description": "Just a regular pedal bike, nothing special",
},
False,
"should reject when keywords are not found in title or description",
),
],
)
def test_keyword_filtering_with_populated_description(
facebook_marketplace: FacebookMarketplace,
keyword_item_config: FacebookItemConfig,
listing_data: dict,
expected_result: bool,
test_description: str,
) -> None:
"""Test that keyword filtering works correctly when description is populated."""
listing = Listing(
marketplace="facebook",
name="test_item",
id=listing_data["id"],
title=listing_data["title"],
image="https://example.com/image.jpg",
price=listing_data["price"],
post_url=f"/marketplace/item/{listing_data['id']}/",
location="Test Location",
seller="Test Seller",
condition="used",
description=listing_data["description"],
)
result = facebook_marketplace.check_listing(
listing, keyword_item_config, description_available=True
)
assert result == expected_result, f"Keyword filtering {test_description}"
def test_antikeyword_filtering_with_empty_description(
facebook_marketplace: FacebookMarketplace,
) -> None:
"""Test that antikeyword filtering works correctly when description is empty."""
listing_with_empty_description = Listing(
marketplace="facebook",
name="test_item",
id="456789",
title="Broken EMTB for parts", # Contains antikeyword in title
image="https://example.com/image.jpg",
price="$500",
post_url="/marketplace/item/456789/",
location="Test Location",
seller="",
condition="used",
description="", # Empty description
)
item_config_with_antikeywords = FacebookItemConfig(
name="test_item",
search_phrases=["EMTB"],
keywords=None,
antikeywords=["broken", "parts"], # These should cause rejection
min_price="100",
max_price="5000",
)
# Should be rejected due to antikeywords in title, even with empty description
result = facebook_marketplace.check_listing(
listing_with_empty_description, item_config_with_antikeywords, description_available=False
)
assert (
not result
), "Should reject listing when antikeywords found in title, even with empty description"