mirror/aliasvault
1
0
Fork 0
mirror of https://github.com/aliasvault/aliasvault.git synced 2026-08-03 02:38:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

Update vault mutate private email filter (#771)

Browse Source
This commit is contained in:
Leendert de Borst
2025-05-05 08:22:12 +02:00
parent 9435c7e657
commit 533b4cf7a2
3 changed files with 32 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
apps/mobile-app/hooks/useVaultMutate.ts
View File

@@ -55,12 +55,17 @@ export function useVaultMutate() : {
setSyncStatus('Uploading vault to server');
// Get email addresses from credentials
// Get all private email domains from credentials in order to claim them on server
const privateEmailDomains = await dbContext.sqliteClient!.getPrivateEmailDomains();
const credentials = await dbContext.sqliteClient!.getAllCredentials();
const emailAddresses = credentials
const privateEmailAddresses = credentials
.filter(cred => cred.Alias?.Email != null)
.map(cred => cred.Alias!.Email!)
.filter((email, index, self) => self.indexOf(email) === index);
.filter((email, index, self) => self.indexOf(email) === index)
.filter(email => {
return privateEmailDomains.some(domain => email.toLowerCase().endsWith(`@${domain.toLowerCase()}`));
});
// Get username from the auth context
const username = authContext.username;
@@ -74,7 +79,7 @@ export function useVaultMutate() : {
createdAt: new Date().toISOString(),
credentialsCount: credentials.length,
currentRevisionNumber: currentRevision,
emailAddressList: emailAddresses,
emailAddressList: privateEmailAddresses,
privateEmailDomainList: [], // Empty on purpose, API will not use this for vault updates
publicEmailDomainList: [], // Empty on purpose, API will not use this for vault updates
encryptionPublicKey: '', // Empty on purpose, only required if new public/private key pair is generated

9
apps/mobile-app/utils/SqliteClient.tsx
View File

@@ -112,6 +112,15 @@ class SqliteClient {
}
}
/**
* Get the private email domains supported by the AliasVault server from the vault metadata.
* @returns The private email domains.
*/
public async getPrivateEmailDomains(): Promise<string[]> {
const metadata = await this.getVaultMetadata();
return metadata?.privateEmailDomains ?? [];
}
/**
* Store the encryption key in the native keychain
*/

14
apps/server/AliasVault.Api/Controllers/VaultController.cs
View File

@@ -411,6 +411,9 @@ public class VaultController(ILogger<VaultController> logger, IAliasServerDbCont
// Keep track of processed and sanitized email addresses to know which ones still exist.
var processedEmailAddresses = new List<string>();
// Get list of supported private domains from config
var supportedPrivateDomains = config.PrivateEmailDomains;
// Register new email addresses.
foreach (var email in newEmailAddresses)
{
@@ -421,6 +424,17 @@ public class VaultController(ILogger<VaultController> logger, IAliasServerDbCont
// If email address is invalid according to the EmailAddressAttribute, skip it.
if (!new EmailAddressAttribute().IsValid(sanitizedEmail))
{
logger.LogWarning("{User} tried to claim invalid email address: {Email}", user.UserName, sanitizedEmail);
continue;
}
// Extract domain from email
var domain = sanitizedEmail.Split('@')[1];
// Skip if domain is not in supported private domains list
if (!supportedPrivateDomains.Contains(domain))
{
logger.LogWarning("{User} tried to claim email with unsupported private domain: {Email}", user.UserName, sanitizedEmail);
continue;
}