mirror/aliasvault
1
0
Fork 0
mirror of https://github.com/aliasvault/aliasvault.git synced 2026-05-18 21:40:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix date handling timezone bug with PostgreSQL (#541)

Browse Source
This commit is contained in:
Leendert de Borst
2025-02-13 13:02:42 +01:00
parent e5552e80e6
commit ccdb62762e
3 changed files with 88 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Databases/AliasServerDb/AliasServerDbContextPostgresql.cs
View File

@@ -74,8 +74,8 @@ public class AliasServerDbContextPostgresql : AliasServerDbContext
// Add value converter for DateTime properties
var converter = new ValueConverter<DateTime, DateTime>(
v => v.Kind == DateTimeKind.Utc ? v : v.ToUniversalTime(),
v => DateTime.SpecifyKind(v, DateTimeKind.Utc));
v => v.ToUniversalTime(),
v => v.ToUniversalTime());
property.SetValueConverter(converter);
}

44
src/Tests/AliasVault.E2ETests/Tests/Client/Shard1/ApiLoggingTests.cs
View File

@@ -1,44 +0,0 @@
//-----------------------------------------------------------------------
// <copyright file="ApiLoggingTests.cs" company="lanedirt">
// Copyright (c) lanedirt. All rights reserved.
// Licensed under the MIT license. See LICENSE.md file in the project root for full license information.
// </copyright>
//-----------------------------------------------------------------------
namespace AliasVault.E2ETests.Tests.Client.Shard1;
using Microsoft.EntityFrameworkCore;
/// <summary>
/// End-to-end tests for making sure errors and warnings in API are logged to database.
/// </summary>
[TestFixture]
[Category("ClientTests")]
[NonParallelizable]
public class ApiLoggingTests : ClientPlaywrightTest
{
/// <summary>
/// Test if an error in the API is logged to the database.
/// </summary>
/// <returns>Async task.</returns>
[Test]
public async Task ApiDbLogTest()
{
// Call webapi endpoint that throws an exception.
try
{
await Page.GotoAsync(ApiBaseUrl + "v1/Test/Error");
await Page.WaitForLoadStateAsync(LoadState.NetworkIdle);
}
catch
{
// Ignore exception as this is expected.
}
// Read from database to check if the log entry was created.
var logEntry = await ApiDbContext.Logs.Where(x => x.Application == "AliasVault.Api").OrderByDescending(x => x.Id).FirstOrDefaultAsync();
Assert.That(logEntry, Is.Not.Null, "Log entry for triggered exception not found in database. Check Serilog configuration and /v1/Test/Error endpoint.");
Assert.That(logEntry.Exception, Does.Contain("Test error"), "Log entry in database does not contain expected message. Check exception and Serilog configuration.");
}
}

86
src/Tests/AliasVault.E2ETests/Tests/Client/Shard1/ApiTests.cs Normal file
View File

@@ -0,0 +1,86 @@
//-----------------------------------------------------------------------
// <copyright file="ApiTests.cs" company="lanedirt">
// Copyright (c) lanedirt. All rights reserved.
// Licensed under the MIT license. See LICENSE.md file in the project root for full license information.
// </copyright>
//-----------------------------------------------------------------------
namespace AliasVault.E2ETests.Tests.Client.Shard1;
using AliasServerDb;
using Microsoft.EntityFrameworkCore;
/// <summary>
/// End-to-end tests for making sure errors and warnings in API are logged to database.
/// </summary>
[TestFixture]
[Category("ClientTests")]
[NonParallelizable]
public class ApiTests : ClientPlaywrightTest
{
/// <summary>
/// Test if an error in the API is logged to the database.
/// </summary>
/// <returns>Async task.</returns>
[Test]
public async Task ApiDbLogTest()
{
// Call webapi endpoint that throws an exception.
try
{
await Page.GotoAsync(ApiBaseUrl + "v1/Test/Error");
await Page.WaitForLoadStateAsync(LoadState.NetworkIdle);
}
catch
{
// Ignore exception as this is expected.
}
// Read from database to check if the log entry was created.
var logEntry = await ApiDbContext.Logs.Where(x => x.Application == "AliasVault.Api").OrderByDescending(x => x.Id).FirstOrDefaultAsync();
Assert.That(logEntry, Is.Not.Null, "Log entry for triggered exception not found in database. Check Serilog configuration and /v1/Test/Error endpoint.");
Assert.That(logEntry.Exception, Does.Contain("Test error"), "Log entry in database does not contain expected message. Check exception and Serilog configuration.");
}
/// <summary>
/// Test if dates are stored and retrieved correctly without unwanted timezone conversions.
/// </summary>
/// <returns>Async task.</returns>
[Test]
public async Task DateTimeStorageTest()
{
// Create a UTC date for testing.
var newTokenLifetime = TimeSpan.FromMinutes(5);
var testDate = DateTime.UtcNow.Add(newTokenLifetime);
// Create a test refresh token with the fixed date.
var user = await ApiDbContext.AliasVaultUsers.FirstAsync();
var refreshToken = new AliasVaultUserRefreshToken
{
Id = Guid.NewGuid(),
UserId = user.Id,
DeviceIdentifier = "test-device",
Value = "test-value",
ExpireDate = testDate,
CreatedAt = testDate,
};
// Add to database and save.
await ApiDbContext.AliasVaultUserRefreshTokens.AddAsync(refreshToken);
await ApiDbContext.SaveChangesAsync();
// Clear the DbContext's change tracker
ApiDbContext.ChangeTracker.Clear();
// Retrieve the token from database without tracking to ensure we get a fresh copy from the database.
var retrievedToken = await ApiDbContext.AliasVaultUserRefreshTokens
.AsNoTracking()
.FirstOrDefaultAsync(x => x.Id == refreshToken.Id);
// Assert dates match exactly.
Assert.That(retrievedToken, Is.Not.Null, "Refresh token not found in database");
Assert.That(retrievedToken.ExpireDate, Is.EqualTo(testDate), "ExpireDate was modified during storage/retrieval");
Assert.That(retrievedToken.CreatedAt, Is.EqualTo(testDate), "CreatedAt was modified during storage/retrieval");
}
}