Remove collection add/create modal toasts

client/components/app/ConfigSideNav.vue

@@ -112,14 +112,6 @@ export default {
         }
       ]
 
-      if (this.$store.state.pluginsEnabled) {
-        configRoutes.push({
-          id: 'config-plugins',
-          title: 'Plugins',
-          path: '/config/plugins'
-        })
-      }
-
       if (this.currentLibraryId) {
         configRoutes.push({
           id: 'library-stats',

client/components/modals/collections/AddCreateModal.vue

@@ -138,7 +138,6 @@ export default {
           .$post(`/api/collections/${collection.id}/batch/remove`, { books: this.selectedBookIds })
           .then((updatedCollection) => {
             console.log(`Books removed from collection`, updatedCollection)
-            this.$toast.success(this.$strings.ToastCollectionItemsRemoveSuccess)
             this.processing = false
           })
           .catch((error) => {
@@ -152,7 +151,6 @@ export default {
           .$delete(`/api/collections/${collection.id}/book/${this.selectedLibraryItemId}`)
           .then((updatedCollection) => {
             console.log(`Book removed from collection`, updatedCollection)
-            this.$toast.success(this.$strings.ToastCollectionItemsRemoveSuccess)
             this.processing = false
           })
           .catch((error) => {
@@ -167,12 +165,11 @@ export default {
       this.processing = true
 
       if (this.showBatchCollectionModal) {
-        // BATCH Remove books
+        // BATCH Add books
         this.$axios
           .$post(`/api/collections/${collection.id}/batch/add`, { books: this.selectedBookIds })
           .then((updatedCollection) => {
             console.log(`Books added to collection`, updatedCollection)
-            this.$toast.success(this.$strings.ToastCollectionItemsAddSuccess)
             this.processing = false
           })
           .catch((error) => {
@@ -187,7 +184,6 @@ export default {
           .$post(`/api/collections/${collection.id}/book`, { id: this.selectedLibraryItemId })
           .then((updatedCollection) => {
             console.log(`Book added to collection`, updatedCollection)
-            this.$toast.success(this.$strings.ToastCollectionItemsAddSuccess)
             this.processing = false
           })
           .catch((error) => {
@@ -214,7 +210,6 @@ export default {
         .$post('/api/collections', newCollection)
         .then((data) => {
           console.log('New Collection Created', data)
-          this.$toast.success(`Collection "${data.name}" created`)
           this.processing = false
           this.newCollectionName = ''
         })

client/components/prompt/Confirm.vue

@@ -7,14 +7,6 @@
 
         <ui-checkbox v-if="checkboxLabel" v-model="checkboxValue" checkbox-bg="bg" :label="checkboxLabel" label-class="pl-2 text-base" class="mb-6 px-1" />
 
-        <div v-if="formFields.length" class="mb-6 space-y-2">
-          <template v-for="field in formFields">
-            <ui-select-input v-if="field.type === 'select'" :key="field.name" v-model="formData[field.name]" :label="field.label" :items="field.options" class="px-1" />
-            <ui-textarea-with-label v-else-if="field.type === 'textarea'" :key="field.name" v-model="formData[field.name]" :label="field.label" class="px-1" />
-            <ui-text-input-with-label v-else-if="field.type === 'text'" :key="field.name" v-model="formData[field.name]" :label="field.label" class="px-1" />
-          </template>
-        </div>
-
         <div class="flex px-1 items-center">
           <ui-btn v-if="isYesNo" color="primary" @click="nevermind">{{ $strings.ButtonCancel }}</ui-btn>
           <div class="flex-grow" />
@@ -33,8 +25,7 @@ export default {
     return {
       el: null,
       content: null,
-      checkboxValue: false,
-      formData: {}
+      checkboxValue: false
     }
   },
   watch: {
@@ -70,9 +61,6 @@ export default {
     persistent() {
       return !!this.confirmPromptOptions.persistent
     },
-    formFields() {
-      return this.confirmPromptOptions.formFields || []
-    },
     checkboxLabel() {
       return this.confirmPromptOptions.checkboxLabel
     },
@@ -112,31 +100,11 @@ export default {
       this.show = false
     },
     confirm() {
-      if (this.callback) {
-        if (this.formFields.length) {
-          const formFieldData = {
-            ...this.formData
-          }
-
-          this.callback(true, formFieldData)
-        } else {
-          this.callback(true, this.checkboxValue)
-        }
-      }
+      if (this.callback) this.callback(true, this.checkboxValue)
       this.show = false
     },
     setShow() {
       this.checkboxValue = this.checkboxDefaultValue
-
-      if (this.formFields.length) {
-        this.formFields.forEach((field) => {
-          let defaultValue = ''
-          if (field.type === 'boolean') defaultValue = false
-          if (field.type === 'select') defaultValue = field.options[0].value
-          this.$set(this.formData, field.name, defaultValue)
-        })
-      }
-
       this.$eventBus.$emit('showing-prompt', true)
       document.body.appendChild(this.el)
       setTimeout(() => {

client/components/ui/ContextMenuDropdown.vue

@@ -31,7 +31,6 @@
             </div>
           </template>
           <button v-else :key="index" role="menuitem" class="flex items-center px-2 py-1.5 hover:bg-white/5 text-white text-xs cursor-pointer w-full" @click.stop="clickAction(item.action)">
-            <span v-if="item.icon" class="material-symbols text-base mr-1">{{ item.icon }}</span>
             <p class="text-left">{{ item.text }}</p>
           </button>
         </template>

client/pages/config/plugins/_id.vue

@@ -1,154 +0,0 @@
-<template>
-  <div>
-    <app-settings-content :header-text="`Plugin: ${pluginManifest.name}`">
-      <template #header-prefix>
-        <nuxt-link to="/config/plugins" class="w-8 h-8 flex items-center justify-center rounded-full cursor-pointer hover:bg-white hover:bg-opacity-10 text-center mr-2">
-          <span class="material-symbols text-2xl">arrow_back</span>
-        </nuxt-link>
-      </template>
-      <template #header-items>
-        <ui-tooltip v-if="pluginManifest.documentationUrl" :text="$strings.LabelClickForMoreInfo" class="inline-flex ml-2">
-          <a :href="pluginManifest.documentationUrl" target="_blank" class="inline-flex">
-            <span class="material-symbols text-xl w-5 text-gray-200">help_outline</span>
-          </a>
-        </ui-tooltip>
-
-        <div class="flex-grow" />
-
-        <a v-if="repositoryUrl" :href="repositoryUrl" target="_blank" class="abs-btn outline-none rounded-md shadow-md relative border border-gray-600 text-center bg-primary text-white px-4 py-1 text-sm inline-flex items-center space-x-2"><span>Source</span><span class="material-symbols text-base">open_in_new</span> </a>
-      </template>
-
-      <div class="py-4">
-        <p v-if="configDescription" class="mb-4">{{ configDescription }}</p>
-
-        <form v-if="configFormFields.length" @submit.prevent="handleFormSubmit">
-          <template v-for="field in configFormFields">
-            <div :key="field.name" class="flex items-center mb-4">
-              <label :for="field.name" class="w-1/3 text-gray-200">{{ field.label }}</label>
-              <div class="w-2/3">
-                <input :id="field.name" :type="field.type" :placeholder="field.placeholder" class="w-full bg-bg border border-white border-opacity-20 rounded-md p-2 text-gray-200" />
-              </div>
-            </div>
-          </template>
-
-          <div class="flex justify-end">
-            <ui-btn class="bg-primary bg-opacity-70 text-white rounded-md p-2" :loading="processing" type="submit">{{ $strings.ButtonSave }}</ui-btn>
-          </div>
-        </form>
-      </div>
-    </app-settings-content>
-  </div>
-</template>
-
-<script>
-export default {
-  async asyncData({ store, redirect, params, app }) {
-    if (!store.getters['user/getIsAdminOrUp']) {
-      redirect('/')
-    }
-    const pluginConfigData = await app.$axios.$get(`/api/plugins/${params.id}/config`).catch((error) => {
-      console.error('Failed to get plugin config', error)
-      return null
-    })
-    if (!pluginConfigData) {
-      redirect('/config/plugins')
-    }
-    const pluginManifest = store.state.plugins.find((plugin) => plugin.id === params.id)
-    if (!pluginManifest) {
-      redirect('/config/plugins')
-    }
-    return {
-      pluginManifest,
-      pluginConfig: pluginConfigData.config
-    }
-  },
-  data() {
-    return {
-      processing: false
-    }
-  },
-  computed: {
-    pluginManifestConfig() {
-      return this.pluginManifest.config
-    },
-    pluginLocalization() {
-      return this.pluginManifest.localization || {}
-    },
-    localizedStrings() {
-      const localeKey = this.$languageCodes.current
-      if (!localeKey) return {}
-      return this.pluginLocalization[localeKey] || {}
-    },
-    configDescription() {
-      if (this.pluginManifestConfig.descriptionKey && this.localizedStrings[this.pluginManifestConfig.descriptionKey]) {
-        return this.localizedStrings[this.pluginManifestConfig.descriptionKey]
-      }
-
-      return this.pluginManifestConfig.description
-    },
-    configFormFields() {
-      return this.pluginManifestConfig.formFields || []
-    },
-    repositoryUrl() {
-      return this.pluginManifest.repositoryUrl
-    }
-  },
-  methods: {
-    getFormData() {
-      const formData = {}
-      this.configFormFields.forEach((field) => {
-        if (field.type === 'checkbox') {
-          formData[field.name] = document.getElementById(field.name).checked
-        } else {
-          formData[field.name] = document.getElementById(field.name).value
-        }
-      })
-      return formData
-    },
-    handleFormSubmit() {
-      const formData = this.getFormData()
-      console.log('Form data', formData)
-
-      const payload = {
-        config: formData
-      }
-
-      this.processing = true
-
-      this.$axios
-        .$post(`/api/plugins/${this.pluginManifest.id}/config`, payload)
-        .then(() => {
-          console.log('Plugin configuration saved')
-        })
-        .catch((error) => {
-          const errorMsg = error.response?.data || 'Error saving plugin configuration'
-          console.error('Failed to save config:', error)
-          this.$toast.error(errorMsg)
-        })
-        .finally(() => {
-          this.processing = false
-        })
-    },
-    initializeForm() {
-      if (!this.pluginConfig) return
-      this.configFormFields.forEach((field) => {
-        if (this.pluginConfig[field.name] === undefined) {
-          return
-        }
-
-        const value = this.pluginConfig[field.name]
-        if (field.type === 'checkbox') {
-          document.getElementById(field.name).checked = value
-        } else {
-          document.getElementById(field.name).value = value
-        }
-      })
-    }
-  },
-  mounted() {
-    console.log('Plugin manifest', this.pluginManifest, 'config', this.pluginConfig)
-    this.initializeForm()
-  },
-  beforeDestroy() {}
-}
-</script>

client/pages/config/plugins/index.vue

@@ -1,48 +0,0 @@
-<template>
-  <div>
-    <app-settings-content :header-text="'Plugins'">
-      <template #header-items>
-        <ui-tooltip :text="$strings.LabelClickForMoreInfo" class="inline-flex ml-2">
-          <a href="https://www.audiobookshelf.org/guides" target="_blank" class="inline-flex">
-            <span class="material-symbols text-xl w-5 text-gray-200">help_outline</span>
-          </a>
-        </ui-tooltip>
-      </template>
-      <div class="py-4">
-        <p v-if="!plugins.length" class="text-gray-300">No plugins installed</p>
-
-        <template v-for="plugin in plugins">
-          <nuxt-link :key="plugin.id" :to="`/config/plugins/${plugin.id}`" class="block w-full rounded bg-primary/40 hover:bg-primary/60 text-gray-300 hover:text-white p-4 my-2">
-            <div class="flex items-center space-x-4">
-              <p class="text-lg">{{ plugin.name }}</p>
-              <p class="text-sm text-gray-300">{{ plugin.description }}</p>
-              <div class="flex-grow" />
-              <span class="material-symbols">arrow_forward</span>
-            </div>
-          </nuxt-link>
-        </template>
-      </div>
-    </app-settings-content>
-  </div>
-</template>
-
-<script>
-export default {
-  asyncData({ store, redirect }) {
-    if (!store.getters['user/getIsAdminOrUp']) {
-      redirect('/')
-    }
-  },
-  data() {
-    return {}
-  },
-  computed: {
-    plugins() {
-      return this.$store.state.plugins
-    }
-  },
-  methods: {},
-  mounted() {},
-  beforeDestroy() {}
-}
-</script>

client/pages/item/_id/index.vue

@@ -364,9 +364,6 @@ export default {
     showCollectionsButton() {
       return this.isBook && this.userCanUpdate
     },
-    pluginExtensions() {
-      return this.$store.getters['getPluginExtensions']('item.detail.actions')
-    },
     contextMenuItems() {
       const items = []
 
@@ -432,18 +429,6 @@ export default {
         })
       }
 
-      if (this.pluginExtensions.length) {
-        this.pluginExtensions.forEach((plugin) => {
-          plugin.extensions.forEach((pext) => {
-            items.push({
-              text: pext.label,
-              action: `plugin-${plugin.id}-action-${pext.name}`,
-              icon: 'extension'
-            })
-          })
-        })
-      }
-
       return items
     }
   },
@@ -778,54 +763,7 @@ export default {
       } else if (action === 'share') {
         this.$store.commit('setSelectedLibraryItem', this.libraryItem)
         this.$store.commit('globals/setShareModal', this.mediaItemShare)
-      } else if (action.startsWith('plugin-')) {
-        const actionStrSplit = action.replace('plugin-', '').split('-action-')
-        const pluginId = actionStrSplit[0]
-        const pluginAction = actionStrSplit[1]
-        this.onPluginAction(pluginId, pluginAction)
       }
-    },
-    onPluginAction(pluginId, pluginAction) {
-      const plugin = this.pluginExtensions.find((p) => p.id === pluginId)
-      const extension = plugin.extensions.find((ext) => ext.name === pluginAction)
-
-      if (extension.prompt) {
-        const payload = {
-          message: extension.prompt.message,
-          formFields: extension.prompt.formFields || [],
-          yesButtonText: this.$strings.ButtonSubmit,
-          callback: (confirmed, promptData) => {
-            if (confirmed) {
-              this.sendPluginAction(pluginId, pluginAction, promptData)
-            }
-          },
-          type: 'yesNo'
-        }
-        this.$store.commit('globals/setConfirmPrompt', payload)
-      } else {
-        this.sendPluginAction(pluginId, pluginAction)
-      }
-    },
-    sendPluginAction(pluginId, pluginAction, promptData = null) {
-      this.$axios
-        .$post(`/api/plugins/${pluginId}/action`, {
-          pluginAction,
-          target: 'item.detail.actions',
-          data: {
-            entityId: this.libraryItemId,
-            entityType: 'libraryItem',
-            userId: this.$store.state.user.user.id,
-            promptData
-          }
-        })
-        .then((data) => {
-          console.log('Plugin action response', data)
-        })
-        .catch((error) => {
-          const errorMsg = error.response?.data || 'Plugin action failed'
-          console.error('Plugin action failed:', error)
-          this.$toast.error(errorMsg)
-        })
     }
   },
   mounted() {

client/pages/login.vue

@@ -166,14 +166,10 @@ export default {
 
       location.reload()
     },
-    setUser({ user, userDefaultLibraryId, serverSettings, Source, ereaderDevices, plugins }) {
+    setUser({ user, userDefaultLibraryId, serverSettings, Source, ereaderDevices }) {
       this.$store.commit('setServerSettings', serverSettings)
       this.$store.commit('setSource', Source)
       this.$store.commit('libraries/setEReaderDevices', ereaderDevices)
-      if (plugins !== undefined) {
-        this.$store.commit('setPlugins', plugins)
-      }
-
       this.$setServerLanguageCode(serverSettings.language)
 
       if (serverSettings.chromecastEnabled) {

client/store/index.js

@@ -28,9 +28,7 @@ export const state = () => ({
   openModal: null,
   innerModalOpen: false,
   lastBookshelfScrollData: {},
-  routerBasePath: '/',
-  plugins: [],
-  pluginsEnabled: false
+  routerBasePath: '/'
 })
 
 export const getters = {
@@ -63,20 +61,6 @@ export const getters = {
   getHomeBookshelfView: (state) => {
     if (!state.serverSettings || isNaN(state.serverSettings.homeBookshelfView)) return Constants.BookshelfView.STANDARD
     return state.serverSettings.homeBookshelfView
-  },
-  getPluginExtensions: (state) => (target) => {
-    if (!state.pluginsEnabled) return []
-    return state.plugins
-      .map((pext) => {
-        const extensionsMatchingTarget = pext.extensions?.filter((ext) => ext.target === target) || []
-        if (!extensionsMatchingTarget.length) return null
-        return {
-          id: pext.id,
-          name: pext.name,
-          extensions: extensionsMatchingTarget
-        }
-      })
-      .filter(Boolean)
   }
 }
 
@@ -255,9 +239,5 @@ export const mutations = {
   },
   setInnerModalOpen(state, val) {
     state.innerModalOpen = val
-  },
-  setPlugins(state, val) {
-    state.plugins = val
-    state.pluginsEnabled = true
   }
 }

client/strings/bg.json

@@ -729,7 +729,6 @@
   "ToastBookmarkUpdateSuccess": "Отметката е обновена",
   "ToastChaptersHaveErrors": "Главите имат грешки",
   "ToastChaptersMustHaveTitles": "Главите трябва да имат заглавия",
-  "ToastCollectionItemsRemoveSuccess": "Елемент(и) премахнати от колекция",
   "ToastCollectionRemoveSuccess": "Колекцията е премахната",
   "ToastCollectionUpdateSuccess": "Колекцията е обновена",
   "ToastItemCoverUpdateSuccess": "Корицата на елемента е обновена",

client/strings/bn.json

@@ -951,8 +951,6 @@
   "ToastChaptersRemoved": "অধ্যায়গুলো মুছে ফেলা হয়েছে",
   "ToastChaptersUpdated": "অধ্যায় আপডেট করা হয়েছে",
   "ToastCollectionItemsAddFailed": "আইটেম(গুলি) সংগ্রহে যোগ করা ব্যর্থ হয়েছে",
-  "ToastCollectionItemsAddSuccess": "আইটেম(গুলি) সংগ্রহে যোগ করা সফল হয়েছে",
-  "ToastCollectionItemsRemoveSuccess": "আইটেম(গুলি) সংগ্রহ থেকে সরানো হয়েছে",
   "ToastCollectionRemoveSuccess": "সংগ্রহ সরানো হয়েছে",
   "ToastCollectionUpdateSuccess": "সংগ্রহ আপডেট করা হয়েছে",
   "ToastCoverUpdateFailed": "কভার আপডেট ব্যর্থ হয়েছে",

client/strings/ca.json

@@ -904,8 +904,6 @@
   "ToastChaptersRemoved": "Capítols eliminats",
   "ToastChaptersUpdated": "Capítols actualitzats",
   "ToastCollectionItemsAddFailed": "Error en afegir elements a la col·lecció",
-  "ToastCollectionItemsAddSuccess": "Elements afegits a la col·lecció",
-  "ToastCollectionItemsRemoveSuccess": "Elements eliminats de la col·lecció",
   "ToastCollectionRemoveSuccess": "Col·lecció eliminada",
   "ToastCollectionUpdateSuccess": "Col·lecció actualitzada",
   "ToastCoverUpdateFailed": "Error en actualitzar la portada",

client/strings/cs.json

@@ -943,7 +943,6 @@
   "ToastChaptersHaveErrors": "Kapitoly obsahují chyby",
   "ToastChaptersMustHaveTitles": "Kapitoly musí mít názvy",
   "ToastChaptersRemoved": "Kapitoly odstraněny",
-  "ToastCollectionItemsRemoveSuccess": "Položky odstraněny z kolekce",
   "ToastCollectionRemoveSuccess": "Kolekce odstraněna",
   "ToastCollectionUpdateSuccess": "Kolekce aktualizována",
   "ToastCoverUpdateFailed": "Aktualizace obálky selhala",

client/strings/da.json

@@ -640,7 +640,6 @@
   "ToastBookmarkUpdateSuccess": "Bogmærke opdateret",
   "ToastChaptersHaveErrors": "Kapitler har fejl",
   "ToastChaptersMustHaveTitles": "Kapitler skal have titler",
-  "ToastCollectionItemsRemoveSuccess": "Element(er) fjernet fra samlingen",
   "ToastCollectionRemoveSuccess": "Samling fjernet",
   "ToastCollectionUpdateSuccess": "Samling opdateret",
   "ToastItemCoverUpdateSuccess": "Varens omslag opdateret",

client/strings/de.json

@@ -959,8 +959,6 @@
   "ToastChaptersRemoved": "Kapitel entfernt",
   "ToastChaptersUpdated": "Kapitel aktualisiert",
   "ToastCollectionItemsAddFailed": "Das Hinzufügen von Element(en) zur Sammlung ist fehlgeschlagen",
-  "ToastCollectionItemsAddSuccess": "Element(e) erfolgreich zur Sammlung hinzugefügt",
-  "ToastCollectionItemsRemoveSuccess": "Medien aus der Sammlung entfernt",
   "ToastCollectionRemoveSuccess": "Sammlung entfernt",
   "ToastCollectionUpdateSuccess": "Sammlung aktualisiert",
   "ToastCoverUpdateFailed": "Cover-Update fehlgeschlagen",

client/strings/en-us.json

@@ -961,8 +961,6 @@
   "ToastChaptersRemoved": "Chapters removed",
   "ToastChaptersUpdated": "Chapters updated",
   "ToastCollectionItemsAddFailed": "Item(s) added to collection failed",
-  "ToastCollectionItemsAddSuccess": "Item(s) added to collection success",
-  "ToastCollectionItemsRemoveSuccess": "Item(s) removed from collection",
   "ToastCollectionRemoveSuccess": "Collection removed",
   "ToastCollectionUpdateSuccess": "Collection updated",
   "ToastCoverUpdateFailed": "Cover update failed",

client/strings/es.json

@@ -959,8 +959,6 @@
   "ToastChaptersRemoved": "Capítulos eliminados",
   "ToastChaptersUpdated": "Capítulos actualizados",
   "ToastCollectionItemsAddFailed": "Artículo(s) añadido(s) a la colección fallido(s)",
-  "ToastCollectionItemsAddSuccess": "Artículo(s) añadido(s) a la colección correctamente",
-  "ToastCollectionItemsRemoveSuccess": "Elementos(s) removidos de la colección",
   "ToastCollectionRemoveSuccess": "Colección removida",
   "ToastCollectionUpdateSuccess": "Colección actualizada",
   "ToastCoverUpdateFailed": "Error al actualizar la cubierta",

client/strings/et.json

@@ -713,7 +713,6 @@
   "ToastBookmarkUpdateSuccess": "Järjehoidja värskendatud",
   "ToastChaptersHaveErrors": "Peatükkidel on vigu",
   "ToastChaptersMustHaveTitles": "Peatükkidel peab olema pealkiri",
-  "ToastCollectionItemsRemoveSuccess": "Üksus(ed) eemaldatud kogumist",
   "ToastCollectionRemoveSuccess": "Kogum eemaldatud",
   "ToastCollectionUpdateSuccess": "Kogum värskendatud",
   "ToastItemCoverUpdateSuccess": "Üksuse kaas värskendatud",

client/strings/fr.json

@@ -953,8 +953,6 @@
   "ToastChaptersRemoved": "Chapitres supprimés",
   "ToastChaptersUpdated": "Chapitres mis à jour",
   "ToastCollectionItemsAddFailed": "Échec de l’ajout de(s) élément(s) à la collection",
-  "ToastCollectionItemsAddSuccess": "Ajout de(s) élément(s) à la collection réussi",
-  "ToastCollectionItemsRemoveSuccess": "Élément(s) supprimé(s) de la collection",
   "ToastCollectionRemoveSuccess": "Collection supprimée",
   "ToastCollectionUpdateSuccess": "Collection mise à jour",
   "ToastCoverUpdateFailed": "Échec de la mise à jour de la couverture",

client/strings/he.json

@@ -744,7 +744,6 @@
   "ToastBookmarkUpdateSuccess": "הסימניה עודכנה בהצלחה",
   "ToastChaptersHaveErrors": "פרקים מכילים שגיאות",
   "ToastChaptersMustHaveTitles": "פרקים חייבים לכלול כותרות",
-  "ToastCollectionItemsRemoveSuccess": "הפריט(ים) הוסרו מהאוסף בהצלחה",
   "ToastCollectionRemoveSuccess": "האוסף הוסר בהצלחה",
   "ToastCollectionUpdateSuccess": "האוסף עודכן בהצלחה",
   "ToastItemCoverUpdateSuccess": "כריכת הפריט עודכנה בהצלחה",

client/strings/hr.json

@@ -959,8 +959,6 @@
   "ToastChaptersRemoved": "Poglavlja uklonjena",
   "ToastChaptersUpdated": "Poglavlja su ažurirana",
   "ToastCollectionItemsAddFailed": "Neuspješno dodavanje stavki u zbirku",
-  "ToastCollectionItemsAddSuccess": "Uspješno dodavanje stavki u zbirku",
-  "ToastCollectionItemsRemoveSuccess": "Stavke izbrisane iz zbirke",
   "ToastCollectionRemoveSuccess": "Zbirka izbrisana",
   "ToastCollectionUpdateSuccess": "Zbirka ažurirana",
   "ToastCoverUpdateFailed": "Ažuriranje naslovnice nije uspjelo",

client/strings/hu.json

@@ -945,7 +945,6 @@
   "ToastChaptersMustHaveTitles": "A fejezeteknek címekkel kell rendelkezniük",
   "ToastChaptersRemoved": "Fejezetek eltávolítva",
   "ToastChaptersUpdated": "Fejezetek frissítve",
-  "ToastCollectionItemsRemoveSuccess": "Elem(ek) eltávolítva a gyűjteményből",
   "ToastCollectionRemoveSuccess": "Gyűjtemény eltávolítva",
   "ToastCollectionUpdateSuccess": "Gyűjtemény frissítve",
   "ToastCoverUpdateFailed": "A borító frissítése nem sikerült",

client/strings/it.json

@@ -950,8 +950,6 @@
   "ToastChaptersRemoved": "Capitoli rimossi",
   "ToastChaptersUpdated": "Capitoli aggiornati",
   "ToastCollectionItemsAddFailed": "l'aggiunta dell'elemento(i) alla raccolta non è riuscito",
-  "ToastCollectionItemsAddSuccess": "L'aggiunta dell'elemento(i) alla raccolta è riuscito",
-  "ToastCollectionItemsRemoveSuccess": "Oggetto(i) rimossi dalla Raccolta",
   "ToastCollectionRemoveSuccess": "Collezione rimossa",
   "ToastCollectionUpdateSuccess": "Raccolta aggiornata",
   "ToastCoverUpdateFailed": "Aggiornamento cover fallito",

client/strings/lt.json

@@ -666,8 +666,6 @@
   "ToastChaptersMustHaveTitles": "Skyriai turi turėti pavadinimus",
   "ToastChaptersRemoved": "Skyriai pašalinti",
   "ToastCollectionItemsAddFailed": "Nepavyko pridėti į kolekciją",
-  "ToastCollectionItemsAddSuccess": "Pridėta į kolekciją",
-  "ToastCollectionItemsRemoveSuccess": "Elementai pašalinti iš kolekcijos",
   "ToastCollectionRemoveSuccess": "Kolekcija pašalinta",
   "ToastCollectionUpdateSuccess": "Kolekcija atnaujinta",
   "ToastCoverUpdateFailed": "Viršelio atnaujinimas nepavyko",

client/strings/nl.json

@@ -946,8 +946,6 @@
   "ToastChaptersRemoved": "Hoofdstukken verwijderd",
   "ToastChaptersUpdated": "Hoofdstukken bijgewerkt",
   "ToastCollectionItemsAddFailed": "Item(s) toegevoegd aan collectie mislukt",
-  "ToastCollectionItemsAddSuccess": "Item(s) toegevoegd aan collectie gelukt",
-  "ToastCollectionItemsRemoveSuccess": "Onderdeel (of onderdelen) verwijderd uit collectie",
   "ToastCollectionRemoveSuccess": "Collectie verwijderd",
   "ToastCollectionUpdateSuccess": "Collectie bijgewerkt",
   "ToastCoverUpdateFailed": "Cover update mislukt",

client/strings/no.json

@@ -882,8 +882,6 @@
   "ToastChaptersRemoved": "Kapitler fjernet",
   "ToastChaptersUpdated": "Kapitler oppdatert",
   "ToastCollectionItemsAddFailed": "Feil med å legge til element(er)",
-  "ToastCollectionItemsAddSuccess": "Element(er) lagt til samlingen",
-  "ToastCollectionItemsRemoveSuccess": "Gjenstand(er) fjernet fra samling",
   "ToastCollectionRemoveSuccess": "Samling fjernet",
   "ToastCollectionUpdateSuccess": "samlingupdated",
   "ToastCoverUpdateFailed": "Oppdatering av bilde feilet",

client/strings/pl.json

@@ -772,7 +772,6 @@
   "ToastBookmarkCreateSuccess": "Dodano zakładkę",
   "ToastBookmarkRemoveSuccess": "Zakładka została usunięta",
   "ToastBookmarkUpdateSuccess": "Zaktualizowano zakładkę",
-  "ToastCollectionItemsRemoveSuccess": "Przedmiot(y) zostały usunięte z kolekcji",
   "ToastCollectionRemoveSuccess": "Kolekcja usunięta",
   "ToastCollectionUpdateSuccess": "Zaktualizowano kolekcję",
   "ToastItemCoverUpdateSuccess": "Zaktualizowano okładkę",

client/strings/pt-br.json

@@ -735,7 +735,6 @@
   "ToastCachePurgeSuccess": "Cache apagado com sucesso",
   "ToastChaptersHaveErrors": "Capítulos com erro",
   "ToastChaptersMustHaveTitles": "Capítulos precisam ter títulos",
-  "ToastCollectionItemsRemoveSuccess": "Item(ns) removidos da coleção",
   "ToastCollectionRemoveSuccess": "Coleção removida",
   "ToastCollectionUpdateSuccess": "Coleção atualizada",
   "ToastDeleteFileFailed": "Falha ao apagar arquivo",

client/strings/ru.json

@@ -959,8 +959,6 @@
   "ToastChaptersRemoved": "Удалены главы",
   "ToastChaptersUpdated": "Обновленные главы",
   "ToastCollectionItemsAddFailed": "Не удалось добавить элемент(ы) в коллекцию",
-  "ToastCollectionItemsAddSuccess": "Элемент(ы) добавлены в коллекцию",
-  "ToastCollectionItemsRemoveSuccess": "Элемент(ы), удалены из коллекции",
   "ToastCollectionRemoveSuccess": "Коллекция удалена",
   "ToastCollectionUpdateSuccess": "Коллекция обновлена",
   "ToastCoverUpdateFailed": "Не удалось обновить обложку",

client/strings/sl.json

@@ -959,8 +959,6 @@
   "ToastChaptersRemoved": "Poglavja so odstranjena",
   "ToastChaptersUpdated": "Poglavja so posodobljena",
   "ToastCollectionItemsAddFailed": "Dodajanje elementov v zbirko ni uspelo",
-  "ToastCollectionItemsAddSuccess": "Dodajanje elementov v zbirko je bilo uspešno",
-  "ToastCollectionItemsRemoveSuccess": "Elementi so bili odstranjeni iz zbirke",
   "ToastCollectionRemoveSuccess": "Zbirka je bila odstranjena",
   "ToastCollectionUpdateSuccess": "Zbirka je bila posodobljena",
   "ToastCoverUpdateFailed": "Posodobitev naslovnice ni uspela",

client/strings/sv.json

@@ -705,7 +705,6 @@
   "ToastBookmarkUpdateSuccess": "Bokmärket har uppdaterats",
   "ToastChaptersHaveErrors": "Kapitlen har fel",
   "ToastChaptersMustHaveTitles": "Kapitel måste ha titlar",
-  "ToastCollectionItemsRemoveSuccess": "Objekt borttagna från samlingen",
   "ToastCollectionRemoveSuccess": "Samlingen har raderats",
   "ToastCollectionUpdateSuccess": "Samlingen har uppdaterats",
   "ToastItemCoverUpdateSuccess": "Objektets omslag uppdaterat",

client/strings/uk.json

@@ -959,8 +959,6 @@
   "ToastChaptersRemoved": "Розділи видалені",
   "ToastChaptersUpdated": "Розділи оновлені",
   "ToastCollectionItemsAddFailed": "Не вдалося додати елемент(и) до колекції",
-  "ToastCollectionItemsAddSuccess": "Елемент(и) успішно додано до колекції",
-  "ToastCollectionItemsRemoveSuccess": "Елемент(и) видалено з добірки",
   "ToastCollectionRemoveSuccess": "Добірку видалено",
   "ToastCollectionUpdateSuccess": "Добірку оновлено",
   "ToastCoverUpdateFailed": "Не вдалося оновити обкладинку",

client/strings/vi-vn.json

@@ -683,7 +683,6 @@
   "ToastBookmarkUpdateSuccess": "Đánh dấu đã được cập nhật",
   "ToastChaptersHaveErrors": "Các chương có lỗi",
   "ToastChaptersMustHaveTitles": "Các chương phải có tiêu đề",
-  "ToastCollectionItemsRemoveSuccess": "Mục đã được xóa khỏi bộ sưu tập",
   "ToastCollectionRemoveSuccess": "Bộ sưu tập đã được xóa",
   "ToastCollectionUpdateSuccess": "Bộ sưu tập đã được cập nhật",
   "ToastItemCoverUpdateSuccess": "Ảnh bìa mục đã được cập nhật",

client/strings/zh-cn.json

@@ -959,8 +959,6 @@
   "ToastChaptersRemoved": "已删除章节",
   "ToastChaptersUpdated": "章节已更新",
   "ToastCollectionItemsAddFailed": "项目添加到收藏夹失败",
-  "ToastCollectionItemsAddSuccess": "项目添加到收藏夹成功",
-  "ToastCollectionItemsRemoveSuccess": "项目从收藏夹移除",
   "ToastCollectionRemoveSuccess": "收藏夹已删除",
   "ToastCollectionUpdateSuccess": "收藏夹已更新",
   "ToastCoverUpdateFailed": "封面更新失败",

client/strings/zh-tw.json

@@ -727,7 +727,6 @@
   "ToastBookmarkUpdateSuccess": "書籤已更新",
   "ToastChaptersHaveErrors": "章節有錯誤",
   "ToastChaptersMustHaveTitles": "章節必須有標題",
-  "ToastCollectionItemsRemoveSuccess": "項目從收藏夾移除",
   "ToastCollectionRemoveSuccess": "收藏夾已刪除",
   "ToastCollectionUpdateSuccess": "收藏夾已更新",
   "ToastItemCoverUpdateSuccess": "項目封面已更新",

index.js

@@ -13,8 +13,6 @@ if (isDev) {
   if (devEnv.SkipBinariesCheck) process.env.SKIP_BINARIES_CHECK = '1'
   if (devEnv.AllowIframe) process.env.ALLOW_IFRAME = '1'
   if (devEnv.BackupPath) process.env.BACKUP_PATH = devEnv.BackupPath
-  if (devEnv.AllowPlugins) process.env.ALLOW_PLUGINS = '1'
-  if (devEnv.DevPluginsPath) process.env.DEV_PLUGINS_PATH = devEnv.DevPluginsPath
   process.env.SOURCE = 'local'
   process.env.ROUTER_BASE_PATH = devEnv.RouterBasePath || ''
 }

prod.js

@@ -16,8 +16,8 @@ const server = require('./server/Server')
 
 global.appRoot = __dirname
 
-const inputConfig = options.config ? Path.resolve(options.config) : null
-const inputMetadata = options.metadata ? Path.resolve(options.metadata) : null
+var inputConfig = options.config ? Path.resolve(options.config) : null
+var inputMetadata = options.metadata ? Path.resolve(options.metadata) : null
 
 const PORT = options.port || process.env.PORT || 3333
 const HOST = options.host || process.env.HOST

server/Auth.js

@@ -16,8 +16,6 @@ const Logger = require('./Logger')
  */
 class Auth {
   constructor() {
-    this.pluginManifests = []
-
     // Map of openId sessions indexed by oauth2 state-variable
     this.openIdAuthSession = new Map()
     this.ignorePatterns = [/\/api\/items\/[^/]+\/cover/, /\/api\/authors\/[^/]+\/image/]
@@ -935,28 +933,11 @@ class Auth {
    */
   async getUserLoginResponsePayload(user) {
     const libraryIds = await Database.libraryModel.getAllLibraryIds()
-
-    let plugins = undefined
-    if (process.env.ALLOW_PLUGINS === '1') {
-      // TODO: Should be better handled by the PluginManager
-      // restrict plugin extensions that are not allowed for the user type
-      plugins = this.pluginManifests.map((manifest) => {
-        const manifestExtensions = (manifest.extensions || []).filter((ext) => {
-          if (ext.restrictToAccountTypes?.length) {
-            return ext.restrictToAccountTypes.includes(user.type)
-          }
-          return true
-        })
-        return { ...manifest, extensions: manifestExtensions }
-      })
-    }
-
     return {
       user: user.toOldJSONForBrowser(),
       userDefaultLibraryId: user.getDefaultLibraryId(libraryIds),
       serverSettings: Database.serverSettings.toJSONForBrowser(),
       ereaderDevices: Database.emailSettings.getEReaderDevices(user),
-      plugins,
       Source: global.Source
     }
   }

server/Database.js

@@ -152,11 +152,6 @@ class Database {
     return this.models.device
   }
 
-  /** @type {typeof import('./models/Plugin')} */
-  get pluginModel() {
-    return this.models.plugin
-  }
-
   /**
    * Check if db file exists
    * @returns {boolean}
@@ -310,7 +305,6 @@ class Database {
     require('./models/Setting').init(this.sequelize)
     require('./models/CustomMetadataProvider').init(this.sequelize)
     require('./models/MediaItemShare').init(this.sequelize)
-    require('./models/Plugin').init(this.sequelize)
 
     return this.sequelize.sync({ force, alter: false })
   }
@@ -412,11 +406,6 @@ class Database {
     return Promise.all(oldBooks.map((oldBook) => this.models.book.saveFromOld(oldBook)))
   }
 
-  createBulkCollectionBooks(collectionBooks) {
-    if (!this.sequelize) return false
-    return this.models.collectionBook.bulkCreate(collectionBooks)
-  }
-
   createPlaylistMediaItem(playlistMediaItem) {
     if (!this.sequelize) return false
     return this.models.playlistMediaItem.create(playlistMediaItem)

server/Server.js

@@ -28,6 +28,7 @@ const AbMergeManager = require('./managers/AbMergeManager')
 const CacheManager = require('./managers/CacheManager')
 const BackupManager = require('./managers/BackupManager')
 const PlaybackSessionManager = require('./managers/PlaybackSessionManager')
+const PodcastManager = require('./managers/PodcastManager')
 const AudioMetadataMangaer = require('./managers/AudioMetadataManager')
 const RssFeedManager = require('./managers/RssFeedManager')
 const CronManager = require('./managers/CronManager')
@@ -35,7 +36,6 @@ const ApiCacheManager = require('./managers/ApiCacheManager')
 const BinaryManager = require('./managers/BinaryManager')
 const ShareManager = require('./managers/ShareManager')
 const LibraryScanner = require('./scanner/LibraryScanner')
-const PluginManager = require('./managers/PluginManager')
 
 //Import the main Passport and Express-Session library
 const passport = require('passport')
@@ -79,8 +79,9 @@ class Server {
     this.backupManager = new BackupManager()
     this.abMergeManager = new AbMergeManager()
     this.playbackSessionManager = new PlaybackSessionManager()
+    this.podcastManager = new PodcastManager()
     this.audioMetadataManager = new AudioMetadataMangaer()
-    this.cronManager = new CronManager(this.playbackSessionManager)
+    this.cronManager = new CronManager(this.podcastManager, this.playbackSessionManager)
     this.apiCacheManager = new ApiCacheManager()
     this.binaryManager = new BinaryManager()
 
@@ -160,15 +161,6 @@ class Server {
         LibraryScanner.scanFilesChanged(pendingFileUpdates, pendingTask)
       })
     }
-
-    if (process.env.ALLOW_PLUGINS === '1') {
-      Logger.info(`[Server] Experimental plugin support enabled`)
-
-      // Initialize plugins
-      await PluginManager.init()
-      // TODO: Prevents circular dependency for SocketAuthority
-      this.auth.pluginManifests = PluginManager.pluginManifests
-    }
   }
 
   /**

server/controllers/CollectionController.js

@@ -5,13 +5,17 @@ const SocketAuthority = require('../SocketAuthority')
 const Database = require('../Database')
 
 const RssFeedManager = require('../managers/RssFeedManager')
-const Collection = require('../objects/Collection')
 
 /**
  * @typedef RequestUserObject
  * @property {import('../models/User')} user
  *
  * @typedef {Request & RequestUserObject} RequestWithUser
+ *
+ * @typedef RequestEntityObject
+ * @property {import('../models/Collection')} collection
+ *
+ * @typedef {RequestWithUser & RequestEntityObject} CollectionControllerRequest
  */
 
 class CollectionController {
@@ -25,36 +29,68 @@ class CollectionController {
    * @param {Response} res
    */
   async create(req, res) {
-    const newCollection = new Collection()
-    req.body.userId = req.user.id
-    if (!newCollection.setData(req.body)) {
+    const reqBody = req.body || {}
+
+    // Validation
+    if (!reqBody.name || !reqBody.libraryId) {
       return res.status(400).send('Invalid collection data')
     }
+    const libraryItemIds = (reqBody.books || []).filter((b) => !!b && typeof b == 'string')
+    if (!libraryItemIds.length) {
+      return res.status(400).send('Invalid collection data. No books')
+    }
 
-    // Create collection record
-    await Database.collectionModel.createFromOld(newCollection)
-
-    // Get library items in collection
-    const libraryItemsInCollection = await Database.libraryItemModel.getForCollection(newCollection)
-
-    // Create collectionBook records
-    let order = 1
-    const collectionBooksToAdd = []
-    for (const libraryItemId of newCollection.books) {
-      const libraryItem = libraryItemsInCollection.find((li) => li.id === libraryItemId)
-      if (libraryItem) {
-        collectionBooksToAdd.push({
-          collectionId: newCollection.id,
-          bookId: libraryItem.media.id,
-          order: order++
-        })
+    // Load library items
+    const libraryItems = await Database.libraryItemModel.findAll({
+      attributes: ['id', 'mediaId', 'mediaType', 'libraryId'],
+      where: {
+        id: libraryItemIds,
+        libraryId: reqBody.libraryId,
+        mediaType: 'book'
       }
-    }
-    if (collectionBooksToAdd.length) {
-      await Database.createBulkCollectionBooks(collectionBooksToAdd)
+    })
+    if (libraryItems.length !== libraryItemIds.length) {
+      return res.status(400).send('Invalid collection data. Invalid books')
     }
 
-    const jsonExpanded = newCollection.toJSONExpanded(libraryItemsInCollection)
+    /** @type {import('../models/Collection')} */
+    let newCollection = null
+
+    const transaction = await Database.sequelize.transaction()
+    try {
+      // Create collection
+      newCollection = await Database.collectionModel.create(
+        {
+          libraryId: reqBody.libraryId,
+          name: reqBody.name,
+          description: reqBody.description || null
+        },
+        { transaction }
+      )
+
+      // Create collectionBooks
+      const collectionBookPayloads = libraryItemIds.map((llid, index) => {
+        const libraryItem = libraryItems.find((li) => li.id === llid)
+        return {
+          collectionId: newCollection.id,
+          bookId: libraryItem.mediaId,
+          order: index + 1
+        }
+      })
+      await Database.collectionBookModel.bulkCreate(collectionBookPayloads, { transaction })
+
+      await transaction.commit()
+    } catch (error) {
+      await transaction.rollback()
+      Logger.error('[CollectionController] create:', error)
+      return res.status(500).send('Failed to create collection')
+    }
+
+    // Load books expanded
+    newCollection.books = await newCollection.getBooksExpandedWithLibraryItem()
+
+    // Note: The old collection model stores expanded libraryItems in the books property
+    const jsonExpanded = newCollection.toOldJSONExpanded()
     SocketAuthority.emitter('collection_added', jsonExpanded)
     res.json(jsonExpanded)
   }
@@ -75,7 +111,7 @@ class CollectionController {
   /**
    * GET: /api/collections/:id
    *
-   * @param {RequestWithUser} req
+   * @param {CollectionControllerRequest} req
    * @param {Response} res
    */
   async findOne(req, res) {
@@ -94,7 +130,7 @@ class CollectionController {
    * PATCH: /api/collections/:id
    * Update collection
    *
-   * @param {RequestWithUser} req
+   * @param {CollectionControllerRequest} req
    * @param {Response} res
    */
   async update(req, res) {
@@ -158,7 +194,7 @@ class CollectionController {
    *
    * @this {import('../routers/ApiRouter')}
    *
-   * @param {RequestWithUser} req
+   * @param {CollectionControllerRequest} req
    * @param {Response} res
    */
   async delete(req, res) {
@@ -178,7 +214,7 @@ class CollectionController {
    * Add a single book to a collection
    * Req.body { id: <library item id> }
    *
-   * @param {RequestWithUser} req
+   * @param {CollectionControllerRequest} req
    * @param {Response} res
    */
   async addBook(req, res) {
@@ -212,7 +248,7 @@ class CollectionController {
    * Remove a single book from a collection. Re-order books
    * TODO: bookId is actually libraryItemId. Clients need updating to use bookId
    *
-   * @param {RequestWithUser} req
+   * @param {CollectionControllerRequest} req
    * @param {Response} res
    */
   async removeBook(req, res) {
@@ -257,29 +293,31 @@ class CollectionController {
    * Add multiple books to collection
    * Req.body { books: <Array of library item ids> }
    *
-   * @param {RequestWithUser} req
+   * @param {CollectionControllerRequest} req
    * @param {Response} res
    */
   async addBatch(req, res) {
     // filter out invalid libraryItemIds
     const bookIdsToAdd = (req.body.books || []).filter((b) => !!b && typeof b == 'string')
     if (!bookIdsToAdd.length) {
-      return res.status(500).send('Invalid request body')
+      return res.status(400).send('Invalid request body')
     }
 
     // Get library items associated with ids
     const libraryItems = await Database.libraryItemModel.findAll({
+      attributes: ['id', 'mediaId', 'mediaType', 'libraryId'],
       where: {
-        id: {
-          [Sequelize.Op.in]: bookIdsToAdd
-        }
-      },
-      include: {
-        model: Database.bookModel
+        id: bookIdsToAdd,
+        libraryId: req.collection.libraryId,
+        mediaType: 'book'
       }
     })
+    if (!libraryItems.length) {
+      return res.status(400).send('Invalid request body. No valid books')
+    }
 
     // Get collection books already in collection
+    /** @type {import('../models/CollectionBook')[]} */
     const collectionBooks = await req.collection.getCollectionBooks()
 
     let order = collectionBooks.length + 1
@@ -288,10 +326,10 @@ class CollectionController {
 
     // Check and set new collection books to add
     for (const libraryItem of libraryItems) {
-      if (!collectionBooks.some((cb) => cb.bookId === libraryItem.media.id)) {
+      if (!collectionBooks.some((cb) => cb.bookId === libraryItem.mediaId)) {
         collectionBooksToAdd.push({
           collectionId: req.collection.id,
-          bookId: libraryItem.media.id,
+          bookId: libraryItem.mediaId,
           order: order++
         })
         hasUpdated = true
@@ -302,7 +340,8 @@ class CollectionController {
 
     let jsonExpanded = null
     if (hasUpdated) {
-      await Database.createBulkCollectionBooks(collectionBooksToAdd)
+      await Database.collectionBookModel.bulkCreate(collectionBooksToAdd)
+
       jsonExpanded = await req.collection.getOldJsonExpanded()
       SocketAuthority.emitter('collection_updated', jsonExpanded)
     } else {
@@ -316,7 +355,7 @@ class CollectionController {
    * Remove multiple books from collection
    * Req.body { books: <Array of library item ids> }
    *
-   * @param {RequestWithUser} req
+   * @param {CollectionControllerRequest} req
    * @param {Response} res
    */
   async removeBatch(req, res) {
@@ -329,9 +368,7 @@ class CollectionController {
     // Get library items associated with ids
     const libraryItems = await Database.libraryItemModel.findAll({
       where: {
-        id: {
-          [Sequelize.Op.in]: bookIdsToRemove
-        }
+        id: bookIdsToRemove
       },
       include: {
         model: Database.bookModel
@@ -339,6 +376,7 @@ class CollectionController {
     })
 
     // Get collection books already in collection
+    /** @type {import('../models/CollectionBook')[]} */
     const collectionBooks = await req.collection.getCollectionBooks({
       order: [['order', 'ASC']]
     })

server/controllers/LibraryController.js

@@ -19,7 +19,6 @@ const Scanner = require('../scanner/Scanner')
 const Database = require('../Database')
 const Watcher = require('../Watcher')
 const RssFeedManager = require('../managers/RssFeedManager')
-const PodcastManager = require('../managers/PodcastManager')
 
 const libraryFilters = require('../utils/queries/libraryFilters')
 const libraryItemsPodcastFilters = require('../utils/queries/libraryItemsPodcastFilters')
@@ -220,7 +219,7 @@ class LibraryController {
    * @param {Response} res
    */
   async getEpisodeDownloadQueue(req, res) {
-    const libraryDownloadQueueDetails = PodcastManager.getDownloadQueueDetails(req.library.id)
+    const libraryDownloadQueueDetails = this.podcastManager.getDownloadQueueDetails(req.library.id)
     res.json(libraryDownloadQueueDetails)
   }
 
@@ -1289,7 +1288,7 @@ class LibraryController {
       }
     })
 
-    const opmlText = PodcastManager.generateOPMLFileText(podcasts)
+    const opmlText = this.podcastManager.generateOPMLFileText(podcasts)
     res.type('application/xml')
     res.send(opmlText)
   }

server/controllers/LibraryItemController.js

@@ -18,7 +18,6 @@ const RssFeedManager = require('../managers/RssFeedManager')
 const CacheManager = require('../managers/CacheManager')
 const CoverManager = require('../managers/CoverManager')
 const ShareManager = require('../managers/ShareManager')
-const PodcastManager = require('../managers/PodcastManager')
 
 /**
  * @typedef RequestUserObject
@@ -60,10 +59,10 @@ class LibraryItemController {
       }
 
       if (item.mediaType === 'podcast' && includeEntities.includes('downloads')) {
-        const downloadsInQueue = PodcastManager.getEpisodeDownloadsInQueue(req.libraryItem.id)
+        const downloadsInQueue = this.podcastManager.getEpisodeDownloadsInQueue(req.libraryItem.id)
         item.episodeDownloadsQueued = downloadsInQueue.map((d) => d.toJSONForClient())
-        if (PodcastManager.currentDownload?.libraryItemId === req.libraryItem.id) {
-          item.episodesDownloading = [PodcastManager.currentDownload.toJSONForClient()]
+        if (this.podcastManager.currentDownload?.libraryItemId === req.libraryItem.id) {
+          item.episodesDownloading = [this.podcastManager.currentDownload.toJSONForClient()]
         }
       }
 

server/controllers/PluginController.js

@@ -1,82 +0,0 @@
-const { Request, Response, NextFunction } = require('express')
-const PluginManager = require('../managers/PluginManager')
-const Logger = require('../Logger')
-
-class PluginController {
-  constructor() {}
-
-  /**
-   *
-   * @param {Request} req
-   * @param {Response} res
-   */
-  getConfig(req, res) {
-    if (!req.user.isAdminOrUp) {
-      return res.sendStatus(403)
-    }
-
-    res.json({
-      config: req.pluginData.instance.config
-    })
-  }
-
-  /**
-   * POST: /api/plugins/:id/action
-   *
-   * @param {Request} req
-   * @param {Response} res
-   */
-  async handleAction(req, res) {
-    const actionName = req.body.pluginAction
-    const target = req.body.target
-    const data = req.body.data
-    Logger.info(`[PluginController] Handle plugin "${req.pluginData.manifest.name}" action ${actionName} ${target}`, data)
-    const actionData = await PluginManager.onAction(req.pluginData, actionName, target, data)
-    if (!actionData || actionData.error) {
-      return res.status(400).send(actionData?.error || 'Error performing action')
-    }
-    res.sendStatus(200)
-  }
-
-  /**
-   * POST: /api/plugins/:id/config
-   *
-   * @param {Request} req
-   * @param {Response} res
-   */
-  async handleConfigSave(req, res) {
-    if (!req.user.isAdminOrUp) {
-      return res.sendStatus(403)
-    }
-    if (!req.body.config || typeof req.body.config !== 'object') {
-      return res.status(400).send('Invalid config')
-    }
-
-    const config = req.body.config
-    Logger.info(`[PluginController] Handle save config for plugin ${req.pluginData.manifest.name}`, config)
-    const saveData = await PluginManager.onConfigSave(req.pluginData, config)
-    if (!saveData || saveData.error) {
-      return res.status(400).send(saveData?.error || 'Error saving config')
-    }
-    res.sendStatus(200)
-  }
-
-  /**
-   *
-   * @param {Request} req
-   * @param {Response} res
-   * @param {NextFunction} next
-   */
-  async middleware(req, res, next) {
-    if (req.params.id) {
-      const pluginData = PluginManager.getPluginDataById(req.params.id)
-      if (!pluginData) {
-        return res.sendStatus(404)
-      }
-      await pluginData.instance.reload()
-      req.pluginData = pluginData
-    }
-    next()
-  }
-}
-module.exports = new PluginController()

server/controllers/PodcastController.js

@@ -11,7 +11,6 @@ const { validateUrl } = require('../utils/index')
 
 const Scanner = require('../scanner/Scanner')
 const CoverManager = require('../managers/CoverManager')
-const PodcastManager = require('../managers/PodcastManager')
 
 const LibraryItem = require('../objects/LibraryItem')
 
@@ -115,7 +114,7 @@ class PodcastController {
 
     if (payload.episodesToDownload?.length) {
       Logger.info(`[PodcastController] Podcast created now starting ${payload.episodesToDownload.length} episode downloads`)
-      PodcastManager.downloadPodcastEpisodes(libraryItem, payload.episodesToDownload)
+      this.podcastManager.downloadPodcastEpisodes(libraryItem, payload.episodesToDownload)
     }
 
     // Turn on podcast auto download cron if not already on
@@ -170,7 +169,7 @@ class PodcastController {
     }
 
     res.json({
-      feeds: PodcastManager.getParsedOPMLFileFeeds(req.body.opmlText)
+      feeds: this.podcastManager.getParsedOPMLFileFeeds(req.body.opmlText)
     })
   }
 
@@ -204,7 +203,7 @@ class PodcastController {
       return res.status(404).send('Folder not found')
     }
     const autoDownloadEpisodes = !!req.body.autoDownloadEpisodes
-    PodcastManager.createPodcastsFromFeedUrls(rssFeeds, folder, autoDownloadEpisodes, this.cronManager)
+    this.podcastManager.createPodcastsFromFeedUrls(rssFeeds, folder, autoDownloadEpisodes, this.cronManager)
 
     res.sendStatus(200)
   }
@@ -231,7 +230,7 @@ class PodcastController {
 
     const maxEpisodesToDownload = !isNaN(req.query.limit) ? Number(req.query.limit) : 3
 
-    var newEpisodes = await PodcastManager.checkAndDownloadNewEpisodes(libraryItem, maxEpisodesToDownload)
+    var newEpisodes = await this.podcastManager.checkAndDownloadNewEpisodes(libraryItem, maxEpisodesToDownload)
     res.json({
       episodes: newEpisodes || []
     })
@@ -240,6 +239,8 @@ class PodcastController {
   /**
    * GET: /api/podcasts/:id/clear-queue
    *
+   * @this {import('../routers/ApiRouter')}
+   *
    * @param {RequestWithUser} req
    * @param {Response} res
    */
@@ -248,20 +249,22 @@ class PodcastController {
       Logger.error(`[PodcastController] Non-admin user "${req.user.username}" attempting to clear download queue`)
       return res.sendStatus(403)
     }
-    PodcastManager.clearDownloadQueue(req.params.id)
+    this.podcastManager.clearDownloadQueue(req.params.id)
     res.sendStatus(200)
   }
 
   /**
    * GET: /api/podcasts/:id/downloads
    *
+   * @this {import('../routers/ApiRouter')}
+   *
    * @param {RequestWithUser} req
    * @param {Response} res
    */
   getEpisodeDownloads(req, res) {
     var libraryItem = req.libraryItem
 
-    var downloadsInQueue = PodcastManager.getEpisodeDownloadsInQueue(libraryItem.id)
+    var downloadsInQueue = this.podcastManager.getEpisodeDownloadsInQueue(libraryItem.id)
     res.json({
       downloads: downloadsInQueue.map((d) => d.toJSONForClient())
     })
@@ -287,6 +290,8 @@ class PodcastController {
   /**
    * POST: /api/podcasts/:id/download-episodes
    *
+   * @this {import('../routers/ApiRouter')}
+   *
    * @param {RequestWithUser} req
    * @param {Response} res
    */
@@ -301,7 +306,7 @@ class PodcastController {
       return res.sendStatus(400)
     }
 
-    PodcastManager.downloadPodcastEpisodes(libraryItem, episodes)
+    this.podcastManager.downloadPodcastEpisodes(libraryItem, episodes)
     res.sendStatus(200)
   }
 

server/managers/CronManager.js

@@ -5,10 +5,11 @@ const Database = require('../Database')
 const LibraryScanner = require('../scanner/LibraryScanner')
 
 const ShareManager = require('./ShareManager')
-const PodcastManager = require('./PodcastManager')
 
 class CronManager {
-  constructor(playbackSessionManager) {
+  constructor(podcastManager, playbackSessionManager) {
+    /** @type {import('./PodcastManager')} */
+    this.podcastManager = podcastManager
     /** @type {import('./PlaybackSessionManager')} */
     this.playbackSessionManager = playbackSessionManager
 
@@ -162,7 +163,7 @@ class CronManager {
         task
       })
     } catch (error) {
-      Logger.error(`[CronManager] Failed to schedule podcast cron ${this.serverSettings.podcastEpisodeSchedule}`, error)
+      Logger.error(`[PodcastManager] Failed to schedule podcast cron ${this.serverSettings.podcastEpisodeSchedule}`, error)
     }
   }
 
@@ -191,7 +192,7 @@ class CronManager {
 
     // Run episode checks
     for (const libraryItem of libraryItems) {
-      const keepAutoDownloading = await PodcastManager.runEpisodeCheck(libraryItem)
+      const keepAutoDownloading = await this.podcastManager.runEpisodeCheck(libraryItem)
       if (!keepAutoDownloading) {
         // auto download was disabled
         podcastCron.libraryItemIds = podcastCron.libraryItemIds.filter((lid) => lid !== libraryItem.id) // Filter it out

server/managers/PluginManager.js

@@ -1,274 +0,0 @@
-const Path = require('path')
-const Logger = require('../Logger')
-const Database = require('../Database')
-const SocketAuthority = require('../SocketAuthority')
-const TaskManager = require('../managers/TaskManager')
-const ShareManager = require('../managers/ShareManager')
-const RssFeedManager = require('../managers/RssFeedManager')
-const PodcastManager = require('../managers/PodcastManager')
-const fsExtra = require('../libs/fsExtra')
-const { isUUID, parseSemverStrict } = require('../utils')
-
-/**
- * @typedef PluginContext
- * @property {import('../Logger')} Logger
- * @property {import('../Database')} Database
- * @property {import('../SocketAuthority')} SocketAuthority
- * @property {import('../managers/TaskManager')} TaskManager
- * @property {import('../models/Plugin')} pluginInstance
- * @property {import('../managers/ShareManager')} ShareManager
- * @property {import('../managers/RssFeedManager')} RssFeedManager
- * @property {import('../managers/PodcastManager')} PodcastManager
- */
-
-/**
- * @typedef PluginData
- * @property {string} id
- * @property {Object} manifest
- * @property {import('../models/Plugin')} instance
- * @property {Function} init
- * @property {Function} onAction
- * @property {Function} onConfigSave
- */
-
-class PluginManager {
-  constructor() {
-    /** @type {PluginData[]} */
-    this.plugins = []
-  }
-
-  get pluginMetadataPath() {
-    return Path.posix.join(global.MetadataPath, 'plugins')
-  }
-
-  get pluginManifests() {
-    return this.plugins.map((plugin) => plugin.manifest)
-  }
-
-  /**
-   *
-   * @param {import('../models/Plugin')} pluginInstance
-   * @returns {PluginContext}
-   */
-  getPluginContext(pluginInstance) {
-    return {
-      Logger,
-      Database,
-      SocketAuthority,
-      TaskManager,
-      pluginInstance,
-      ShareManager,
-      RssFeedManager,
-      PodcastManager
-    }
-  }
-
-  /**
-   *
-   * @param {string} id
-   * @returns {PluginData}
-   */
-  getPluginDataById(id) {
-    return this.plugins.find((plugin) => plugin.manifest.id === id)
-  }
-
-  /**
-   * Validate and load a plugin from a directory
-   * TODO: Validatation
-   *
-   * @param {string} dirname
-   * @param {string} pluginPath
-   * @returns {Promise<PluginData>}
-   */
-  async loadPlugin(dirname, pluginPath) {
-    const pluginFiles = await fsExtra.readdir(pluginPath, { withFileTypes: true }).then((files) => files.filter((file) => !file.isDirectory()))
-
-    if (!pluginFiles.length) {
-      Logger.error(`No files found in plugin ${pluginPath}`)
-      return null
-    }
-    const manifestFile = pluginFiles.find((file) => file.name === 'manifest.json')
-    if (!manifestFile) {
-      Logger.error(`No manifest found for plugin ${pluginPath}`)
-      return null
-    }
-    const indexFile = pluginFiles.find((file) => file.name === 'index.js')
-    if (!indexFile) {
-      Logger.error(`No index file found for plugin ${pluginPath}`)
-      return null
-    }
-
-    let manifestJson = null
-    try {
-      manifestJson = await fsExtra.readFile(Path.join(pluginPath, manifestFile.name), 'utf8').then((data) => JSON.parse(data))
-    } catch (error) {
-      Logger.error(`Error parsing manifest file for plugin ${pluginPath}`, error)
-      return null
-    }
-
-    // TODO: Validate manifest json
-    if (!isUUID(manifestJson.id)) {
-      Logger.error(`Invalid plugin ID in manifest for plugin ${pluginPath}`)
-      return null
-    }
-    if (!parseSemverStrict(manifestJson.version)) {
-      Logger.error(`Invalid plugin version in manifest for plugin ${pluginPath}`)
-      return null
-    }
-    // TODO: Enforcing plugin name to be the same as the directory name? Ensures plugins are identifiable in the file system. May have issues with unicode characters.
-    if (dirname !== manifestJson.name) {
-      Logger.error(`Plugin directory name "${dirname}" does not match manifest name "${manifestJson.name}"`)
-      return null
-    }
-
-    let pluginContents = null
-    try {
-      pluginContents = require(Path.join(pluginPath, indexFile.name))
-    } catch (error) {
-      Logger.error(`Error loading plugin ${pluginPath}`, error)
-      return null
-    }
-
-    if (typeof pluginContents.init !== 'function') {
-      Logger.error(`Plugin ${pluginPath} does not have an init function`)
-      return null
-    }
-
-    return {
-      id: manifestJson.id,
-      manifest: manifestJson,
-      init: pluginContents.init,
-      onAction: pluginContents.onAction,
-      onConfigSave: pluginContents.onConfigSave
-    }
-  }
-
-  /**
-   * Get all plugins from the /metadata/plugins directory
-   */
-  async getPluginsFromDirPath(pluginsPath) {
-    // Get all directories in the plugins directory
-    const pluginDirs = await fsExtra.readdir(pluginsPath, { withFileTypes: true }).then((files) => files.filter((file) => file.isDirectory()))
-
-    const pluginsFound = []
-    for (const pluginDir of pluginDirs) {
-      Logger.debug(`[PluginManager] Checking if directory "${pluginDir.name}" is a plugin`)
-      const plugin = await this.loadPlugin(pluginDir.name, Path.join(pluginsPath, pluginDir.name))
-      if (plugin) {
-        Logger.debug(`[PluginManager] Found plugin "${plugin.manifest.name}"`)
-        pluginsFound.push(plugin)
-      }
-    }
-
-    return pluginsFound
-  }
-
-  /**
-   * Load plugins from the /metadata/plugins directory and update the database
-   */
-  async loadPlugins() {
-    await fsExtra.ensureDir(this.pluginMetadataPath)
-
-    const pluginsFound = await this.getPluginsFromDirPath(this.pluginMetadataPath)
-
-    if (process.env.DEV_PLUGINS_PATH) {
-      const devPluginsFound = await this.getPluginsFromDirPath(process.env.DEV_PLUGINS_PATH)
-      if (!devPluginsFound.length) {
-        Logger.warn(`[PluginManager] No plugins found in DEV_PLUGINS_PATH: ${process.env.DEV_PLUGINS_PATH}`)
-      } else {
-        pluginsFound.push(...devPluginsFound)
-      }
-    }
-
-    const existingPlugins = await Database.pluginModel.findAll()
-
-    // Add new plugins or update existing plugins
-    for (const plugin of pluginsFound) {
-      const existingPlugin = existingPlugins.find((p) => p.id === plugin.manifest.id)
-      if (existingPlugin) {
-        // TODO: Should automatically update?
-        if (existingPlugin.version !== plugin.manifest.version) {
-          Logger.info(`[PluginManager] Updating plugin "${plugin.manifest.name}" version from "${existingPlugin.version}" to version "${plugin.manifest.version}"`)
-          await existingPlugin.update({ version: plugin.manifest.version, isMissing: false })
-        } else if (existingPlugin.isMissing) {
-          Logger.info(`[PluginManager] Plugin "${plugin.manifest.name}" was missing but is now found`)
-          await existingPlugin.update({ isMissing: false })
-        } else {
-          Logger.debug(`[PluginManager] Plugin "${plugin.manifest.name}" already exists in the database with version "${plugin.manifest.version}"`)
-        }
-        plugin.instance = existingPlugin
-      } else {
-        plugin.instance = await Database.pluginModel.create({
-          id: plugin.manifest.id,
-          name: plugin.manifest.name,
-          version: plugin.manifest.version
-        })
-        Logger.info(`[PluginManager] Added plugin "${plugin.manifest.name}" to the database`)
-      }
-    }
-
-    // Mark missing plugins
-    for (const plugin of existingPlugins) {
-      const foundPlugin = pluginsFound.find((p) => p.manifest.id === plugin.id)
-      if (!foundPlugin && !plugin.isMissing) {
-        Logger.info(`[PluginManager] Plugin "${plugin.name}" not found or invalid - marking as missing`)
-        await plugin.update({ isMissing: true })
-      }
-    }
-
-    this.plugins = pluginsFound
-  }
-
-  /**
-   * Load and initialize all plugins
-   */
-  async init() {
-    await this.loadPlugins()
-
-    for (const plugin of this.plugins) {
-      Logger.info(`[PluginManager] Initializing plugin ${plugin.manifest.name}`)
-      plugin.init(this.getPluginContext(plugin.instance))
-    }
-  }
-
-  /**
-   *
-   * @param {PluginData} plugin
-   * @param {string} actionName
-   * @param {string} target
-   * @param {Object} data
-   * @returns {Promise<boolean|{error:string}>}
-   */
-  onAction(plugin, actionName, target, data) {
-    if (!plugin.onAction) {
-      Logger.error(`[PluginManager] onAction not implemented for plugin ${plugin.manifest.name}`)
-      return false
-    }
-
-    const pluginExtension = plugin.manifest.extensions.find((extension) => extension.name === actionName)
-    if (!pluginExtension) {
-      Logger.error(`[PluginManager] Extension ${actionName} not found for plugin ${plugin.manifest.name}`)
-      return false
-    }
-
-    Logger.info(`[PluginManager] Calling onAction for plugin ${plugin.manifest.name}`)
-    return plugin.onAction(this.getPluginContext(plugin.instance), actionName, target, data)
-  }
-
-  /**
-   *
-   * @param {PluginData} plugin
-   * @param {Object} config
-   * @returns {Promise<boolean|{error:string}>}
-   */
-  onConfigSave(plugin, config) {
-    if (!plugin.onConfigSave) {
-      Logger.error(`[PluginManager] onConfigSave not implemented for plugin ${plugin.manifest.name}`)
-      return false
-    }
-
-    Logger.info(`[PluginManager] Calling onConfigSave for plugin ${plugin.manifest.name}`)
-    return plugin.onConfigSave(this.getPluginContext(plugin.instance), config)
-  }
-}
-module.exports = new PluginManager()

server/managers/PodcastManager.js

@@ -586,4 +586,4 @@ class PodcastManager {
     Logger.info(`[PodcastManager] createPodcastsFromFeedUrls: Finished OPML import. Created ${numPodcastsAdded} podcasts out of ${rssFeedUrls.length} RSS feed URLs`)
   }
 }
-module.exports = new PodcastManager()
+module.exports = PodcastManager

server/migrations/v2.18.0-add-plugins-table.js

@@ -1,68 +0,0 @@
-/**
- * @typedef MigrationContext
- * @property {import('sequelize').QueryInterface} queryInterface - a suquelize QueryInterface object.
- * @property {import('../Logger')} logger - a Logger object.
- *
- * @typedef MigrationOptions
- * @property {MigrationContext} context - an object containing the migration context.
- */
-
-const migrationVersion = '2.18.0'
-const migrationName = `${migrationVersion}-add-plugins-table`
-const loggerPrefix = `[${migrationVersion} migration]`
-
-/**
- * This upward migration creates the plugins table if it does not exist.
- *
- * @param {MigrationOptions} options - an object containing the migration context.
- * @returns {Promise<void>} - A promise that resolves when the migration is complete.
- */
-async function up({ context: { queryInterface, logger } }) {
-  // Upwards migration script
-  logger.info(`${loggerPrefix} UPGRADE BEGIN: ${migrationName}`)
-
-  if (!(await queryInterface.tableExists('plugins'))) {
-    const DataTypes = queryInterface.sequelize.Sequelize.DataTypes
-    await queryInterface.createTable('plugins', {
-      id: {
-        type: DataTypes.UUID,
-        defaultValue: DataTypes.UUIDV4,
-        primaryKey: true
-      },
-      name: DataTypes.STRING,
-      version: DataTypes.STRING,
-      isMissing: DataTypes.BOOLEAN,
-      config: DataTypes.JSON,
-      extraData: DataTypes.JSON,
-      createdAt: DataTypes.DATE,
-      updatedAt: DataTypes.DATE
-    })
-    logger.info(`${loggerPrefix} Table 'plugins' created`)
-  } else {
-    logger.info(`${loggerPrefix} Table 'plugins' already exists`)
-  }
-
-  logger.info(`${loggerPrefix} UPGRADE END: ${migrationName}`)
-}
-
-/**
- * This downward migration script drops the plugins table if it exists.
- *
- * @param {MigrationOptions} options - an object containing the migration context.
- * @returns {Promise<void>} - A promise that resolves when the migration is complete.
- */
-async function down({ context: { queryInterface, logger } }) {
-  // Downward migration script
-  logger.info(`${loggerPrefix} DOWNGRADE BEGIN: ${migrationName}`)
-
-  if (await queryInterface.tableExists('plugins')) {
-    await queryInterface.dropTable('plugins')
-    logger.info(`${loggerPrefix} Table 'plugins' dropped`)
-  } else {
-    logger.info(`${loggerPrefix} Table 'plugins' does not exist`)
-  }
-
-  logger.info(`${loggerPrefix} DOWNGRADE END: ${migrationName}`)
-}
-
-module.exports = { up, down }

server/models/Collection.js

@@ -1,7 +1,5 @@
 const { DataTypes, Model, Sequelize } = require('sequelize')
 
-const oldCollection = require('../objects/Collection')
-
 class Collection extends Model {
   constructor(values, options) {
     super(values, options)
@@ -26,12 +24,12 @@ class Collection extends Model {
   }
 
   /**
-   * Get all old collections toJSONExpanded, items filtered for user permissions
+   * Get all toOldJSONExpanded, items filtered for user permissions
    *
    * @param {import('./User')} user
    * @param {string} [libraryId]
    * @param {string[]} [include]
-   * @returns {Promise<oldCollection[]>} oldCollection.toJSONExpanded
+   * @async
    */
   static async getOldCollectionsJsonExpanded(user, libraryId, include) {
     let collectionWhere = null
@@ -79,8 +77,6 @@ class Collection extends Model {
     // TODO: Handle user permission restrictions on initial query
     return collections
       .map((c) => {
-        const oldCollection = this.getOldCollection(c)
-
         // Filter books using user permissions
         const books =
           c.books?.filter((b) => {
@@ -95,20 +91,14 @@ class Collection extends Model {
             return true
           }) || []
 
-        // Map to library items
-        const libraryItems = books.map((b) => {
-          const libraryItem = b.libraryItem
-          delete b.libraryItem
-          libraryItem.media = b
-          return this.sequelize.models.libraryItem.getOldLibraryItem(libraryItem)
-        })
-
         // Users with restricted permissions will not see this collection
-        if (!books.length && oldCollection.books.length) {
+        if (!books.length && c.books.length) {
           return null
         }
 
-        const collectionExpanded = oldCollection.toJSONExpanded(libraryItems)
+        this.books = books
+
+        const collectionExpanded = c.toOldJSONExpanded()
 
         // Map feed if found
         if (c.feeds?.length) {
@@ -153,69 +143,6 @@ class Collection extends Model {
     })
   }
 
-  /**
-   * Get old collection from Collection
-   * @param {Collection} collectionExpanded
-   * @returns {oldCollection}
-   */
-  static getOldCollection(collectionExpanded) {
-    const libraryItemIds = collectionExpanded.books?.map((b) => b.libraryItem?.id || null).filter((lid) => lid) || []
-    return new oldCollection({
-      id: collectionExpanded.id,
-      libraryId: collectionExpanded.libraryId,
-      name: collectionExpanded.name,
-      description: collectionExpanded.description,
-      books: libraryItemIds,
-      lastUpdate: collectionExpanded.updatedAt.valueOf(),
-      createdAt: collectionExpanded.createdAt.valueOf()
-    })
-  }
-
-  /**
-   *
-   * @param {oldCollection} oldCollection
-   * @returns {Promise<Collection>}
-   */
-  static createFromOld(oldCollection) {
-    const collection = this.getFromOld(oldCollection)
-    return this.create(collection)
-  }
-
-  static getFromOld(oldCollection) {
-    return {
-      id: oldCollection.id,
-      name: oldCollection.name,
-      description: oldCollection.description,
-      libraryId: oldCollection.libraryId
-    }
-  }
-
-  static removeById(collectionId) {
-    return this.destroy({
-      where: {
-        id: collectionId
-      }
-    })
-  }
-
-  /**
-   * Get old collection by id
-   * @param {string} collectionId
-   * @returns {Promise<oldCollection|null>} returns null if not found
-   */
-  static async getOldById(collectionId) {
-    if (!collectionId) return null
-    const collection = await this.findByPk(collectionId, {
-      include: {
-        model: this.sequelize.models.book,
-        include: this.sequelize.models.libraryItem
-      },
-      order: [[this.sequelize.models.book, this.sequelize.models.collectionBook, 'order', 'ASC']]
-    })
-    if (!collection) return null
-    return this.getOldCollection(collection)
-  }
-
   /**
    * Remove all collections belonging to library
    * @param {string} libraryId
@@ -286,64 +213,37 @@ class Collection extends Model {
   }
 
   /**
-   * Get old collection toJSONExpanded, items filtered for user permissions
+   * Get toOldJSONExpanded, items filtered for user permissions
    *
    * @param {import('./User')|null} user
    * @param {string[]} [include]
-   * @returns {Promise<oldCollection>} oldCollection.toJSONExpanded
+   * @async
    */
   async getOldJsonExpanded(user, include) {
-    this.books =
-      (await this.getBooks({
-        include: [
-          {
-            model: this.sequelize.models.libraryItem
-          },
-          {
-            model: this.sequelize.models.author,
-            through: {
-              attributes: []
-            }
-          },
-          {
-            model: this.sequelize.models.series,
-            through: {
-              attributes: ['sequence']
-            }
-          }
-        ],
-        order: [Sequelize.literal('`collectionBook.order` ASC')]
-      })) || []
+    this.books = await this.getBooksExpandedWithLibraryItem()
 
     // Filter books using user permissions
     // TODO: Handle user permission restrictions on initial query
-    const books =
-      this.books?.filter((b) => {
-        if (user) {
-          if (b.tags?.length && !user.checkCanAccessLibraryItemWithTags(b.tags)) {
-            return false
-          }
-          if (b.explicit === true && !user.canAccessExplicitContent) {
-            return false
-          }
+    if (user) {
+      const books = this.books.filter((b) => {
+        if (b.tags?.length && !user.checkCanAccessLibraryItemWithTags(b.tags)) {
+          return false
+        }
+        if (b.explicit === true && !user.canAccessExplicitContent) {
+          return false
         }
         return true
-      }) || []
+      })
 
-    // Map to library items
-    const libraryItems = books.map((b) => {
-      const libraryItem = b.libraryItem
-      delete b.libraryItem
-      libraryItem.media = b
-      return this.sequelize.models.libraryItem.getOldLibraryItem(libraryItem)
-    })
+      // Users with restricted permissions will not see this collection
+      if (!books.length && this.books.length) {
+        return null
+      }
 
-    // Users with restricted permissions will not see this collection
-    if (!books.length && this.books.length) {
-      return null
+      this.books = books
     }
 
-    const collectionExpanded = this.toOldJSONExpanded(libraryItems)
+    const collectionExpanded = this.toOldJSONExpanded()
 
     if (include?.includes('rssfeed')) {
       const feeds = await this.getFeeds()
@@ -357,10 +257,10 @@ class Collection extends Model {
 
   /**
    *
-   * @param {string[]} libraryItemIds
+   * @param {string[]} [libraryItemIds=[]]
    * @returns
    */
-  toOldJSON(libraryItemIds) {
+  toOldJSON(libraryItemIds = []) {
     return {
       id: this.id,
       libraryId: this.libraryId,
@@ -372,19 +272,19 @@ class Collection extends Model {
     }
   }
 
-  /**
-   *
-   * @param {import('../objects/LibraryItem')} oldLibraryItems
-   * @returns
-   */
-  toOldJSONExpanded(oldLibraryItems) {
-    const json = this.toOldJSON(oldLibraryItems.map((li) => li.id))
-    json.books = json.books
-      .map((libraryItemId) => {
-        const book = oldLibraryItems.find((li) => li.id === libraryItemId)
-        return book ? book.toJSONExpanded() : null
-      })
-      .filter((b) => !!b)
+  toOldJSONExpanded() {
+    if (!this.books) {
+      throw new Error('Books are required to expand Collection')
+    }
+
+    const json = this.toOldJSON()
+    json.books = this.books.map((book) => {
+      const libraryItem = book.libraryItem
+      delete book.libraryItem
+      libraryItem.media = book
+      return this.sequelize.models.libraryItem.getOldLibraryItem(libraryItem).toJSONExpanded()
+    })
+
     return json
   }
 }

server/models/CollectionBook.js

@@ -16,15 +16,6 @@ class CollectionBook extends Model {
     this.createdAt
   }
 
-  static removeByIds(collectionId, bookId) {
-    return this.destroy({
-      where: {
-        bookId,
-        collectionId
-      }
-    })
-  }
-
   static init(sequelize) {
     super.init(
       {

server/models/LibraryItem.js

@@ -123,7 +123,7 @@ class LibraryItem extends Model {
   }
 
   /**
-   * Currently unused because this is too slow and uses too much mem
+   *
    * @param {import('sequelize').WhereOptions} [where]
    * @returns {Array<objects.LibraryItem>} old library items
    */

server/models/Plugin.js

@@ -1,54 +0,0 @@
-const { DataTypes, Model } = require('sequelize')
-
-class Plugin extends Model {
-  constructor(values, options) {
-    super(values, options)
-
-    /** @type {UUIDV4} */
-    this.id
-    /** @type {string} */
-    this.name
-    /** @type {string} */
-    this.version
-    /** @type {boolean} */
-    this.isMissing
-    /** @type {Object} */
-    this.config
-    /** @type {Object} */
-    this.extraData
-    /** @type {Date} */
-    this.createdAt
-    /** @type {Date} */
-    this.updatedAt
-  }
-
-  /**
-   * Initialize model
-   * @param {import('../Database').sequelize} sequelize
-   */
-  static init(sequelize) {
-    super.init(
-      {
-        id: {
-          type: DataTypes.UUID,
-          defaultValue: DataTypes.UUIDV4,
-          primaryKey: true
-        },
-        name: DataTypes.STRING,
-        version: DataTypes.STRING,
-        isMissing: {
-          type: DataTypes.BOOLEAN,
-          defaultValue: false
-        },
-        config: DataTypes.JSON,
-        extraData: DataTypes.JSON
-      },
-      {
-        sequelize,
-        modelName: 'plugin'
-      }
-    )
-  }
-}
-
-module.exports = Plugin

server/objects/Collection.js

@@ -1,115 +0,0 @@
-const uuidv4 = require("uuid").v4
-
-class Collection {
-  constructor(collection) {
-    this.id = null
-    this.libraryId = null
-
-    this.name = null
-    this.description = null
-
-    this.cover = null
-    this.coverFullPath = null
-    this.books = []
-
-    this.lastUpdate = null
-    this.createdAt = null
-
-    if (collection) {
-      this.construct(collection)
-    }
-  }
-
-  toJSON() {
-    return {
-      id: this.id,
-      libraryId: this.libraryId,
-      name: this.name,
-      description: this.description,
-      cover: this.cover,
-      coverFullPath: this.coverFullPath,
-      books: [...this.books],
-      lastUpdate: this.lastUpdate,
-      createdAt: this.createdAt
-    }
-  }
-
-  toJSONExpanded(libraryItems, minifiedBooks = false) {
-    const json = this.toJSON()
-    json.books = json.books.map(bookId => {
-      const book = libraryItems.find(li => li.id === bookId)
-      return book ? minifiedBooks ? book.toJSONMinified() : book.toJSONExpanded() : null
-    }).filter(b => !!b)
-    return json
-  }
-
-  // Expanded and filtered out items not accessible to user
-  toJSONExpandedForUser(user, libraryItems) {
-    const json = this.toJSON()
-    json.books = json.books.map(libraryItemId => {
-      const libraryItem = libraryItems.find(li => li.id === libraryItemId)
-      return libraryItem ? libraryItem.toJSONExpanded() : null
-    }).filter(li => {
-      return li && user.checkCanAccessLibraryItem(li)
-    })
-    return json
-  }
-
-  construct(collection) {
-    this.id = collection.id
-    this.libraryId = collection.libraryId
-    this.name = collection.name
-    this.description = collection.description || null
-    this.cover = collection.cover || null
-    this.coverFullPath = collection.coverFullPath || null
-    this.books = collection.books ? [...collection.books] : []
-    this.lastUpdate = collection.lastUpdate || null
-    this.createdAt = collection.createdAt || null
-  }
-
-  setData(data) {
-    if (!data.libraryId || !data.name) {
-      return false
-    }
-    this.id = uuidv4()
-    this.libraryId = data.libraryId
-    this.name = data.name
-    this.description = data.description || null
-    this.cover = data.cover || null
-    this.coverFullPath = data.coverFullPath || null
-    this.books = data.books ? [...data.books] : []
-    this.lastUpdate = Date.now()
-    this.createdAt = Date.now()
-    return true
-  }
-
-  addBook(bookId) {
-    this.books.push(bookId)
-    this.lastUpdate = Date.now()
-  }
-
-  removeBook(bookId) {
-    this.books = this.books.filter(bid => bid !== bookId)
-    this.lastUpdate = Date.now()
-  }
-
-  update(payload) {
-    let hasUpdates = false
-    for (const key in payload) {
-      if (key === 'books') {
-        if (payload.books && this.books.join(',') !== payload.books.join(',')) {
-          this.books = [...payload.books]
-          hasUpdates = true
-        }
-      } else if (this[key] !== undefined && this[key] !== payload[key]) {
-        hasUpdates = true
-        this[key] = payload[key]
-      }
-    }
-    if (hasUpdates) {
-      this.lastUpdate = Date.now()
-    }
-    return hasUpdates
-  }
-}
-module.exports = Collection

server/routers/ApiRouter.js

@@ -33,7 +33,6 @@ const RSSFeedController = require('../controllers/RSSFeedController')
 const CustomMetadataProviderController = require('../controllers/CustomMetadataProviderController')
 const MiscController = require('../controllers/MiscController')
 const ShareController = require('../controllers/ShareController')
-const PluginController = require('../controllers/PluginController')
 
 const { getTitleIgnorePrefix } = require('../utils/index')
 
@@ -47,6 +46,8 @@ class ApiRouter {
     this.abMergeManager = Server.abMergeManager
     /** @type {import('../managers/BackupManager')} */
     this.backupManager = Server.backupManager
+    /** @type {import('../managers/PodcastManager')} */
+    this.podcastManager = Server.podcastManager
     /** @type {import('../managers/AudioMetadataManager')} */
     this.audioMetadataManager = Server.audioMetadataManager
     /** @type {import('../managers/CronManager')} */
@@ -319,13 +320,6 @@ class ApiRouter {
     this.router.post('/share/mediaitem', ShareController.createMediaItemShare.bind(this))
     this.router.delete('/share/mediaitem/:id', ShareController.deleteMediaItemShare.bind(this))
 
-    //
-    // Plugin routes
-    //
-    this.router.get('/plugins/:id/config', PluginController.middleware.bind(this), PluginController.getConfig.bind(this))
-    this.router.post('/plugins/:id/action', PluginController.middleware.bind(this), PluginController.handleAction.bind(this))
-    this.router.post('/plugins/:id/config', PluginController.middleware.bind(this), PluginController.handleConfigSave.bind(this))
-
     //
     // Misc Routes
     //

server/utils/index.js

@@ -243,21 +243,3 @@ module.exports.isValidASIN = (str) => {
   if (!str || typeof str !== 'string') return false
   return /^[A-Z0-9]{10}$/.test(str)
 }
-
-/**
- * Parse semver string that must be in format "major.minor.patch" all numbers
- *
- * @param {string} version
- * @returns {{major: number, minor: number, patch: number} | null}
- */
-module.exports.parseSemverStrict = (version) => {
-  if (typeof version !== 'string') {
-    return null
-  }
-  const [major, minor, patch] = version.split('.').map(Number)
-
-  if (isNaN(major) || isNaN(minor) || isNaN(patch)) {
-    return null
-  }
-  return { major, minor, patch }
-}

test/server/managers/PluginManager.test.js

@@ -1,5 +0,0 @@
-describe('PluginManager', () => {
-  it('should register a plugin', () => {
-    // Test implementation
-  })
-})

test/server/managers/plugins/Example/index.js

@@ -1,152 +0,0 @@
-/**
- * Called on initialization of the plugin
- *
- * @param {import('../../../server/managers/PluginManager').PluginContext} context
- */
-module.exports.init = async (context) => {
-  // Set default config on first init
-  if (!context.pluginInstance.config) {
-    context.Logger.info('[ExamplePlugin] First init. Setting default config')
-    context.pluginInstance.config = {
-      requestAddress: '',
-      enable: false
-    }
-    await context.pluginInstance.save()
-  }
-
-  context.Database.mediaProgressModel.addHook('afterSave', (instance, options) => {
-    context.Logger.debug(`[ExamplePlugin] mediaProgressModel afterSave hook for mediaProgress ${instance.id}`)
-    handleMediaProgressUpdate(context, instance)
-  })
-
-  context.Logger.info('[ExamplePlugin] Example plugin initialized')
-}
-
-/**
- * Called when an extension action is triggered
- *
- * @param {import('../../../server/managers/PluginManager').PluginContext} context
- * @param {string} actionName
- * @param {string} target
- * @param {*} data
- * @returns {Promise<boolean|{error: string}>}
- */
-module.exports.onAction = async (context, actionName, target, data) => {
-  context.Logger.info('[ExamplePlugin] Example plugin onAction', actionName, target, data)
-
-  createTask(context)
-
-  return true
-}
-
-/**
- * Called when the plugin config page is saved
- *
- * @param {import('../../../server/managers/PluginManager').PluginContext} context
- * @param {*} config
- * @returns {Promise<boolean|{error: string}>}
- */
-module.exports.onConfigSave = async (context, config) => {
-  context.Logger.info('[ExamplePlugin] Example plugin onConfigSave', config)
-
-  if (!config.requestAddress || typeof config.requestAddress !== 'string') {
-    context.Logger.error('[ExamplePlugin] Invalid request address')
-    return {
-      error: 'Invalid request address'
-    }
-  }
-  if (typeof config.enable !== 'boolean') {
-    context.Logger.error('[ExamplePlugin] Invalid enable value')
-    return {
-      error: 'Invalid enable value'
-    }
-  }
-
-  // Config would need to be validated
-  const updatedConfig = {
-    requestAddress: config.requestAddress,
-    enable: config.enable
-  }
-  context.pluginInstance.config = updatedConfig
-  await context.pluginInstance.save()
-  context.Logger.info('[ExamplePlugin] Example plugin config saved', updatedConfig)
-  return true
-}
-
-//
-// Helper functions
-//
-let numProgressSyncs = 0
-
-/**
- * Send media progress update to external requestAddress defined in config
- *
- * @param {import('../../../server/managers/PluginManager').PluginContext} context
- * @param {import('../../../server/models/MediaProgress')} mediaProgress
- */
-async function handleMediaProgressUpdate(context, mediaProgress) {
-  // Need to reload the model instance since it was passed in during init and may have values changed
-  await context.pluginInstance.reload()
-
-  if (!context.pluginInstance.config?.enable) {
-    return
-  }
-  const requestAddress = context.pluginInstance.config.requestAddress
-  if (!requestAddress) {
-    context.Logger.error('[ExamplePlugin] Request address not set')
-    return
-  }
-
-  const mediaItem = await mediaProgress.getMediaItem()
-  if (!mediaItem) {
-    context.Logger.error(`[ExamplePlugin] Media item not found for mediaProgress ${mediaProgress.id}`)
-  } else {
-    const mediaProgressDuration = mediaProgress.duration
-    const progressPercent = mediaProgressDuration > 0 ? (mediaProgress.currentTime / mediaProgressDuration) * 100 : 0
-    context.Logger.info(`[ExamplePlugin] Media progress update for "${mediaItem.title}" ${Math.round(progressPercent)}% (total numProgressSyncs: ${numProgressSyncs})`)
-
-    fetch(requestAddress, {
-      method: 'POST',
-      headers: {
-        'Content-Type': 'application/json'
-      },
-      body: JSON.stringify({
-        title: mediaItem.title,
-        progress: progressPercent
-      })
-    })
-      .then(() => {
-        context.Logger.info(`[ExamplePlugin] Media progress update sent for "${mediaItem.title}" ${Math.round(progressPercent)}%`)
-        numProgressSyncs++
-        sendAdminMessageToast(context, `Synced "${mediaItem.title}" (total syncs: ${numProgressSyncs})`)
-      })
-      .catch((error) => {
-        context.Logger.error(`[ExamplePlugin] Error sending media progress update: ${error.message}`)
-      })
-  }
-}
-
-/**
- * Test socket authority
- *
- * @param {import('../../../server/managers/PluginManager').PluginContext} context
- * @param {string} message
- */
-async function sendAdminMessageToast(context, message) {
-  context.SocketAuthority.adminEmitter('admin_message', message)
-}
-
-/**
- * Test task manager
- *
- * @param {import('../../../server/managers/PluginManager').PluginContext} context
- */
-async function createTask(context) {
-  const task = context.TaskManager.createAndAddTask('example_action', { text: 'Example Task' }, { text: 'This is an example task' }, true)
-  const pluginConfigEnabled = !!context.pluginInstance.config.enable
-
-  setTimeout(() => {
-    task.setFinished({ text: `Plugin is ${pluginConfigEnabled ? 'enabled' : 'disabled'}` })
-    context.TaskManager.taskFinished(task)
-  }, 5000)
-}

test/server/managers/plugins/Example/manifest.json

@@ -1,53 +0,0 @@
-{
-  "id": "e6205690-916c-4add-9a2b-2548266996ef",
-  "name": "Example",
-  "version": "1.0.0",
-  "owner": "advplyr",
-  "repositoryUrl": "https://github.com/example/example-plugin",
-  "documentationUrl": "https://example.com",
-  "description": "This is an example plugin",
-  "descriptionKey": "ExamplePluginDescription",
-  "extensions": [
-    {
-      "target": "item.detail.actions",
-      "name": "itemActionExample",
-      "label": "Item Example Action",
-      "labelKey": "ItemExampleAction"
-    }
-  ],
-  "config": {
-    "description": "This is a description on how to configure the plugin",
-    "descriptionKey": "ExamplePluginConfigurationDescription",
-    "formFields": [
-      {
-        "name": "requestAddress",
-        "label": "Request Address",
-        "labelKey": "LabelRequestAddress",
-        "type": "text"
-      },
-      {
-        "name": "enable",
-        "label": "Enable",
-        "labelKey": "LabelEnable",
-        "type": "checkbox"
-      }
-    ]
-  },
-  "localization": {
-    "de": {
-      "ExamplePluginDescription": "Dies ist ein Beispiel-Plugin",
-      "ItemExampleAction": "Item Example Action",
-      "LabelEnable": "Enable",
-      "ExamplePluginConfigurationDescription": "This is a description on how to configure the plugin",
-      "LabelRequestAddress": "Request Address"
-    }
-  },
-  "releases": [
-    {
-      "version": "1.0.0",
-      "changelog": "Initial release",
-      "timestamp": "2022-01-01T00:00:00Z",
-      "downloadUrl": ""
-    }
-  ]
-}

test/server/managers/plugins/Template/index.js

@@ -1,36 +0,0 @@
-/**
- * Called on initialization of the plugin
- *
- * @param {import('../../../server/managers/PluginManager').PluginContext} context
- */
-module.exports.init = async (context) => {
-  context.Logger.info('[TemplatePlugin] plugin initialized')
-  // Can be used to initialize plugin config and/or setup Database hooks
-}
-
-/**
- * Called when an extension action is triggered
- *
- * @param {import('../../../server/managers/PluginManager').PluginContext} context
- * @param {string} actionName
- * @param {string} target
- * @param {Object} data
- * @returns {Promise<boolean|{error: string}>}
- */
-module.exports.onAction = async (context, actionName, target, data) => {
-  context.Logger.info('[TemplatePlugin] plugin onAction', actionName, target, data)
-  return true
-}
-
-/**
- * Called when the plugin config page is saved
- *
- * @param {import('../../../server/managers/PluginManager').PluginContext} context
- * @param {Object} config
- * @returns {Promise<boolean|{error: string}>}
- */
-module.exports.onConfigSave = async (context, config) => {
-  context.Logger.info('[TemplatePlugin] plugin onConfigSave', config)
-  // Maintener is responsible for validating and saving the config to their `pluginInstance`
-  return true
-}

test/server/managers/plugins/Template/manifest.json

@@ -1,20 +0,0 @@
-{
-  "id": "e6205690-916c-4add-9a2b-2548266996eg",
-  "name": "Template",
-  "version": "1.0.0",
-  "owner": "advplyr",
-  "repositoryUrl": "https://github.com/advplr/abs-report-for-review-plugin",
-  "documentationUrl": "https://audiobookshelf.org/guides",
-  "description": "This is a minimal template for an abs plugin",
-  "extensions": [],
-  "config": {},
-  "localization": {},
-  "releases": [
-    {
-      "version": "1.0.0",
-      "changelog": "Initial release",
-      "timestamp": "2022-01-01T00:00:00Z",
-      "downloadUrl": ""
-    }
-  ]
-}