mirror/booklore
1
0
Fork 0
mirror of https://github.com/booklore-app/booklore.git synced 2025-12-23 22:28:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

Lesson: Avoid using entities in bad operations, prefer DTOs

Browse Source
This commit is contained in:
aditya.chandel
2025-01-17 20:21:49 -07:00
parent 0940fcbbeb
commit 42ccd2ce4d
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
booklore-api/src/main/java/com/adityachandel/booklore/service/metadata/BookMetadataService.java
View File

@@ -46,9 +46,9 @@ public class BookMetadataService {
public List<FetchedBookMetadata> fetchMetadataForRequest(long bookId, FetchMetadataRequest request) {
BookEntity bookEntity = bookRepository.findById(bookId).orElseThrow(() -> ApiError.BOOK_NOT_FOUND.createException(bookId));
Book book = bookMapper.toBook(bookEntity);
List<List<FetchedBookMetadata>> allMetadata = request.getProviders().stream()
.map(provider -> CompletableFuture.supplyAsync(() -> fetchMetadataListFromAProvider(provider, bookMapper.toBook(bookEntity), request))
.map(provider -> CompletableFuture.supplyAsync(() -> fetchMetadataListFromAProvider(provider, book, request))
.exceptionally(e -> {
log.error("Error fetching metadata from provider: {}", provider, e);
return List.of();