mirror/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-02-06 20:56:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix Element.replaceWith crash when self replacing

Browse Source 
Fix a crash with the WPT test dom/nodes/ChildNode-replaceWith.html
When we call `div.replaceWith(div);` we don't want to touch self at all.
This commit is contained in:
Pierre Tachoire
2026-02-06 18:23:38 +01:00
parent 7c4c80fe4a
commit 0406bba384
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/browser/webapi/Element.zig
View File

@@ -722,8 +722,19 @@ pub fn replaceWith(self: *Element, nodes: []const Node.NodeOrText, page: *Page)
const parent_is_connected = parent.isConnected();
// Detect if the ref_node must be removed (byt default) or kept.
// We kept it when ref_node is present into the nodes list.
var rm_ref_node = true;
for (nodes) |node_or_text| {
const child = try node_or_text.toNode(page);
// If a child is the ref node. We keep it at its own current position.
if (child == ref_node) {
rm_ref_node = false;
continue;
}
if (child._parent) |current_parent| {
page.removeNode(current_parent, child, .{ .will_be_reconnected = parent_is_connected });
}
@@ -736,7 +747,9 @@ pub fn replaceWith(self: *Element, nodes: []const Node.NodeOrText, page: *Page)
);
}
page.removeNode(parent, ref_node, .{ .will_be_reconnected = false });
if (rm_ref_node) {
page.removeNode(parent, ref_node, .{ .will_be_reconnected = false });
}
}
pub fn remove(self: *Element, page: *Page) void {