mirror/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-06-11 09:35:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

Simplifies NodeList.foreach

Browse Source 
Removes 2 layers of indirection (including 1 allocation) that is unnecessary for
an internal call.
This commit is contained in:
Karl Seguin
2026-04-08 17:02:40 +08:00
parent 16685019d4
commit 077263bae4
1 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/browser/webapi/collections/NodeList.zig
View File

@@ -92,20 +92,11 @@ pub fn entries(self: *NodeList, page: *Page) !*EntryIterator {
pub fn forEach(self: *NodeList, cb: js.Function, page: *Page) !void {
var i: i32 = 0;
var it = try self.values(page);
// the iterator takes a reference against our list
defer self.releaseRef(page._session);
while (true) : (i += 1) {
const next = try it.next(page);
if (next.done) {
return;
}
const node = try self.getAtIndex(@intCast(i), page) orelse return;
var caught: js.TryCatch.Caught = undefined;
cb.tryCall(void, .{ next.value, i, self }, &caught) catch {
cb.tryCall(void, .{ node, i, self }, &caught) catch {
log.debug(.js, "forEach callback", .{ .caught = caught, .source = "nodelist" });
return;
};