mirror/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-06-11 01:25:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

change sameSite to string to deal with case-insensitive values

Browse Source
This commit is contained in:
Karl Seguin
2026-05-02 12:10:57 +08:00
parent 55a1efc7ed
commit 3ec507773c
1 changed files with 6 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/cookies.zig
View File

@@ -43,7 +43,7 @@ fn _loadFromFile(session: *Session, path: []const u8) !void {
return;
};
const json_cookies = std.json.parseFromSliceLeaky([]const LoadJsonCookie, arena, content, .{
const json_cookies = std.json.parseFromSliceLeaky([]const JsonCookie, arena, content, .{
.ignore_unknown_fields = true,
}) catch |err| {
log.err(.app, "Cookie.parseFile", .{ .path = path, .err = err });
@@ -111,7 +111,7 @@ fn _saveToFile(jar: *Cookie.Jar, path: []const u8) !void {
}
try w.writeAll("\n ");
try std.json.Stringify.value(SaveJsonCookie{
try std.json.Stringify.value(JsonCookie{
.name = c.name,
.value = c.value,
.domain = c.domain,
@@ -119,7 +119,7 @@ fn _saveToFile(jar: *Cookie.Jar, path: []const u8) !void {
.expires = c.expires,
.secure = c.secure,
.httpOnly = c.http_only,
.sameSite = c.same_site,
.sameSite = @tagName(c.same_site),
}, .{}, w);
}
@@ -132,7 +132,7 @@ fn _saveToFile(jar: *Cookie.Jar, path: []const u8) !void {
log.info(.app, "Cookie.saveToFile", .{ .path = path, .count = jar.cookies.items.len });
}
const LoadJsonCookie = struct {
const JsonCookie = struct {
name: []const u8,
value: []const u8,
domain: []const u8,
@@ -143,17 +143,6 @@ const LoadJsonCookie = struct {
sameSite: ?[]const u8 = null,
};
const SaveJsonCookie = struct {
name: []const u8,
value: []const u8,
domain: []const u8,
path: []const u8,
expires: ?f64 = null,
secure: bool,
httpOnly: bool,
sameSite: Cookie.SameSite = .none,
};
fn parseJsonSameSite(value: ?[]const u8) Cookie.SameSite {
const same_site = value orelse return .none;
if (std.ascii.eqlIgnoreCase(same_site, "strict")) return .strict;
@@ -167,11 +156,11 @@ test "cookies: load JSON accepts CDP SameSite casing" {
defer arena.deinit();
const parsed = try std.json.parseFromSliceLeaky(
[]const LoadJsonCookie,
[]const JsonCookie,
arena.allocator(),
"[{\"name\":\"sid\",\"value\":\"1\",\"domain\":\"example.com\",\"sameSite\":\"Lax\"}]",
.{ .ignore_unknown_fields = true },
);
try std.testing.expectEqual(Cookie.SameSite.lax, parseJsonSameSite(parsed[0].sameSite));
}
}