mirror/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-06-11 01:25:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2560 from lightpanda-io/capture_401_407

Browse Source 
Capture 401 and 407 bodies
This commit is contained in:
Karl Seguin
2026-05-28 06:57:21 +08:00
committed by GitHub
parent 7743e68c58 f614d898aa
commit 4e2f21990c
4 changed files with 29 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/TestHTTPServer.zig
View File

@@ -90,8 +90,13 @@ fn handleConnection(self: *TestHTTPServer, conn: std.net.Server.Connection) !voi
};
self.handler(&req) catch |err| {
std.debug.print("test http error '{s}': {}\n", .{ req.head.target, err });
try req.respond("server error", .{ .status = .internal_server_error });
switch (err) {
error.BrokenPipe => {},
else => {
std.debug.print("test http error '{s}': {}\n", .{ req.head.target, err });
try req.respond("server error", .{ .status = .internal_server_error });
},
}
return;
};
}

13
src/browser/Frame.zig
View File

@@ -4300,5 +4300,16 @@ test "Frame: httpMetadata 404" {
defer testing.test_session.removePage();
const meta = frame.httpMetadata();
try testing.expect(meta.status != null);
try std.testing.expectEqual(@as(u16, 404), meta.status.?);
try testing.expectEqual(404, meta.status.?);
}
test "Frame: 401" {
var frame = try testing.pageTest("401", .{});
defer testing.reset();
defer frame._session.removePage();
var buf = std.Io.Writer.Allocating.init(testing.allocator);
defer buf.deinit();
try @import("dump.zig").root(frame.document, .{}, &buf.writer, frame);
try testing.expectEqual("<!DOCTYPE html><html><head><meta charset=\"utf-8\"></head><body><pre>No</pre></body></html>", buf.written());
}

2
src/browser/HttpClient.zig
View File

@@ -1871,7 +1871,7 @@ pub const Transfer = struct {
log.err(.http, "getResponseCode", .{ .err = err, .source = "body callback" });
return http.writefunc_error;
};
if ((status >= 300 and status <= 399) or status == 401 or status == 407) {
if (status >= 300 and status <= 399) {
res.skip_body = true;
return @intCast(chunk_len);
}

9
src/testing.zig
View File

@@ -653,6 +653,15 @@ fn testHTTPHandler(req: *std.http.Server.Request) !void {
});
}
if (std.mem.eql(u8, path, "/src/browser/tests/401")) {
return req.respond("No", .{
.status = .unauthorized,
.extra_headers = &.{
.{ .name = "Content-Type", .value = "text/plain" },
},
});
}
if (std.mem.eql(u8, path, "/404.js")) {
// Valid JS body served with a 404 status. Used to assert that
// ScriptManager does NOT execute the body of a failed script