mirror/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-07-31 01:36:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

extract: resolve href/src attributes to absolute URLs

Browse Source 
The schema walker returned raw attribute values, so `attr: "href"` /
`attr: "src"` yielded whatever the markup contained — usually a relative
URL. That is inconsistent with the links and structuredData tools (which
resolve against the document base) and with the DOM .href/.src
properties, and it makes the common extract-then-goto pattern fail on
sites with relative links, since goto needs an absolute URL.

Resolve href/src via `new URL(raw, document.baseURI)`, falling back to
the raw value on parse failure. Other attributes pass through unchanged;
absolute URLs are unaffected.
This commit is contained in:
Adrià Arrufat
2026-06-18 17:46:06 +02:00
parent a83b9b1e7e
commit 56e4401db4
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/browser/tools.zig
View File

@@ -398,7 +398,7 @@ pub const Tool = enum {
\\Extract structured data from the current page (navigate first). `schema` is a JSON object (passed as a string) mapping output field names to CSS-selector specs. It is NOT a JSON Schema — no "type"/"properties" wrappers; the keys ARE your output fields. Value shapes:
\\ "<sel>" → first match's text (trimmed; null if no match)
\\ ["<sel>"] → every match's text (string[])
\\ {"selector":"<sel>","attr":"<name>"} → first match's attribute value
\\ {"selector":"<sel>","attr":"<name>"} → first match's attribute value (href/src resolved to absolute URLs)
\\ [{"selector":"<sel>","attr":"<name>"}] → every match's attribute (string[])
\\ [{"selector":"<sel>","fields":{…}}] → one object per match; field selectors resolve relative to that match and accept any shape above ("" = the match's own text; nest arrays for per-item sub-lists)
\\Add "limit": N inside any array's object spec to cap matches.
@@ -409,7 +409,7 @@ pub const Tool = enum {
\\ {"karma": "#karma"} → {"karma":"42"}
\\ {"items": [".story .title"]} → {"items":["Title 1","Title 2"]}
\\ {"top3": [{"selector":".story .title","limit":3}]} → {"top3":["A","B","C"]}
\\ {"links": [{"selector":"a.title","attr":"href"}]} → {"links":["/a","/b"]}
\\ {"links": [{"selector":"a.title","attr":"href"}]} → {"links":["https://site/a","https://site/b"]}
\\ {"stories": [{"selector":".athing","fields":{"title":".titleline","rank":".rank"}}]} → {"stories":[{"title":"Foo","rank":"1"}]}
,
.summary = "Extract structured data via a CSS-selector schema",
@@ -884,7 +884,15 @@ const schema_walker_prefix =
\\ for (const k in inner.fields) r[k] = ext(m, inner.fields[k]);
\\ return r;
\\ }
\\ if (inner.attr) return m.getAttribute(inner.attr);
\\ if (inner.attr) {
\\ const raw = m.getAttribute(inner.attr);
\\ // Resolve href/src like the DOM .href/.src properties do, so extracted
\\ // URLs are usable by goto.
\\ if (raw !== null && (inner.attr === 'href' || inner.attr === 'src')) {
\\ try { return new URL(raw, document.baseURI).href; } catch (e) { return raw; }
\\ }
\\ return raw;
\\ }
\\ return m.textContent.trim();
\\ }
\\ function ext(el, v){